Skip to contentSkip to conversation

white space fixes wanted?

DISCUSSION Jens-Michael Hoffmann 3 participants 5 messages Nov 21, 2005 – Nov 22, 2005

lore
Share & tools
lore
#0 lore raw

When looking in drivers/ieee1394/pcilynx.c, I noticed that there are a lot of spaces instead of tabs. I prepared a patch to fix that.

file size of pcilynx.c before: 53775 bytes
file size after: 42870 bytes

patch size is 85356 bytes.

Should I send this patch to the mailing list?

Jens-Michael

#1 lore raw
Quoted 9 lines · Jens-Michael Hoffmann

When looking in drivers/ieee1394/pcilynx.c, I noticed that there are a lot of spaces instead of tabs. I prepared a patch to fix that.

file size of pcilynx.c before: 53775 bytes
file size after: 42870 bytes

patch size is 85356 bytes.

Should I send this patch to the mailing list?

How about to the ieee1394 developers? They would be the best people to be able to accept this change.

thanks,

greg k-h

#2 lore raw
Quoted 6 lines · Greg KH
Quoted 3 lines

patch size is 85356 bytes.

Should I send this patch to the mailing list?

How about to the ieee1394 developers? They would be the best people to be able to accept this change.

Done.
Since this is my first contribution to the linux kernel I don't know if it is mandatory to publish patches on lkml.

thanks

Jens-Michael

(sorry for my bad english)

#3 lore raw
In reply to Greg KH
Quoted 4 lines · Greg KH
Quoted 1 line

Should I send this patch to the mailing list?

How about to the ieee1394 developers? They would be the best people to be able to accept this change.

I second that. I'll gladly take code cleanup patches for ieee1394 - it needs them :)

Cheers,
Jody (1394 maintainer)

Quoted 9 lines

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

#4 lore raw
Quoted 9 lines · Jody McIntyre
Quoted 4 lines · Greg KH
Quoted 1 line

Should I send this patch to the mailing list?

How about to the ieee1394 developers? They would be the best people to be able to accept this change.

I second that. I'll gladly take code cleanup patches for ieee1394 - it needs them :)

Great, I'll send the patches directly to you because they are quite large.

Jens-Michael