Skip to contentSkip to conversation

2.6.15-rc2 pci_ids.h cleanup is a pain

DISCUSSION David Fox 6 participants 10 messages Nov 21, 2005 – Nov 24, 2005

lore
Share & tools
lore

David Fox

author
#0 lore raw

I'm sure I'm not the only person that applies patches to the kernel that use some of the 500 plus PCI IDS eliminated from pci_ids.h by rc2. I would like to see the PCI ids that were removed simply because the don't occur in the main kernel source restored. Is there a rationale for removing them that I'm not aware of?

#1 lore raw
Quoted 5 lines · David Fox

I'm sure I'm not the only person that applies patches to the kernel that use some of the 500 plus PCI IDS eliminated from pci_ids.h by rc2. I would like to see the PCI ids that were removed simply because the don't occur in the main kernel source restored. Is there a rationale for removing them that I'm not aware of?

As long as you are patching the kernel, is there some reason you can't add back the PCI IDs you require?

Phil

#2 lore raw
In reply to David Fox
Quoted 5 lines · David Fox

I'm sure I'm not the only person that applies patches to the kernel that use some of the 500 plus PCI IDS eliminated from pci_ids.h by rc2. I would like to see the PCI ids that were removed simply because the don't occur in the main kernel source restored. Is there a rationale for removing them that I'm not aware of?

They were not being used. Why would you want them in there?

And, what pending patches do you have that patched this file? Is there a reason you have not submitted it for inclusion?

thanks,

greg k-h

#3 lore raw
Quoted 9 lines · Greg KH
Quoted 5 lines · David Fox

I'm sure I'm not the only person that applies patches to the kernel that use some of the 500 plus PCI IDS eliminated from pci_ids.h by rc2. I would like to see the PCI ids that were removed simply because the don't occur in the main kernel source restored. Is there a rationale for removing them that I'm not aware of?

They were not being used. Why would you want them in there?

Because they contained useful information which had been accumulated by many people over a long period of time.

Throwing that information away seemed rather pointless, especially as the cost of retaining it was so low.

#4 lore raw

Hi Andrew, Greg,

Quoted 9 lines · Andrew Morton
Quoted 8 lines · Greg KH
Quoted 5 lines · David Fox

I'm sure I'm not the only person that applies patches to the kernel that use some of the 500 plus PCI IDS eliminated from pci_ids.h by rc2. I would like to see the PCI ids that were removed simply because the don't occur in the main kernel source restored. Is there a rationale for removing them that I'm not aware of?

Quoted 7 lines
Quoted 1 line

They were not being used. Why would you want them in there?

Because they contained useful information which had been accumulated by many people over a long period of time.

Throwing that information away seemed rather pointless, especially as the cost of retaining it was so low.

There's an out-of-tree reference, the pci.ids website, that carries this information, do we need the reference info in the kernel as well?

So far two people raised an objection, the other wants to maintain an out-of-tree driver, D. Fox didn't say why he needs the symbols.

There's some other cleanups to be done yet, as >100 files define own PCI_* symbols instead of referencing the header...

Would you prefer to revert the patches or rather me put the removed symbols back again via a new patch series?

Cheers,
Grant.

#5 lore raw
Quoted 3 lines · Grant Coady

Would you prefer to revert the patches or rather me put the removed
symbols back again via a new patch series?

It's probably too late now - I'm just having a little grump.

#6 lore raw
In reply to Grant Coady
Quoted 18 lines · Grant Coady

Hi Andrew, Greg,

Quoted 14 lines · Andrew Morton
Quoted 9 lines · Greg KH
Quoted 5 lines · David Fox

I'm sure I'm not the only person that applies patches to the kernel that use some of the 500 plus PCI IDS eliminated from pci_ids.h by rc2. I would like to see the PCI ids that were removed simply because the don't occur in the main kernel source restored. Is there a rationale for removing them that I'm not aware of?

They were not being used. Why would you want them in there?

Because they contained useful information which had been accumulated by many people over a long period of time.

Quoted 8 lines
Quoted 2 lines

Throwing that information away seemed rather pointless, especially as the cost of retaining it was so low.

There's an out-of-tree reference, the pci.ids website, that carries this information, do we need the reference info in the kernel as well?

So far two people raised an objection, the other wants to maintain an out-of-tree driver, D. Fox didn't say why he needs the symbols.

Three. I already mentioned we broke the compilation of the advansys driver because of this.

Dave

#7 lore raw
Quoted 2 lines · Dave Jones

Three. I already mentioned we broke the compilation of the advansys driver because of this.

Nah, two. Dave J. is the other, broken BROKEN driver, out of tree for working driver, patches not in mainline?

I may have misunderstood... You want advansys back? Perhaps my boo-boo for not checking with allyesconfig + BROKEN re: unused symbols?

Grant.

#8 lore raw
In reply to Dave Jones
Quoted 22 lines · Dave Jones
Quoted 21 lines · Grant Coady

Hi Andrew, Greg,

Quoted 16 lines · Andrew Morton
Quoted 9 lines · Greg KH
Quoted 5 lines · David Fox

I'm sure I'm not the only person that applies patches to the kernel that use some of the 500 plus PCI IDS eliminated from pci_ids.h by rc2. I would like to see the PCI ids that were removed simply because the don't occur in the main kernel source restored. Is there a rationale for removing them that I'm not aware of?

They were not being used. Why would you want them in there?

Because they contained useful information which had been accumulated by many people over a long period of time.

Throwing that information away seemed rather pointless, especially as the cost of retaining it was so low.

Quoted 8 lines
Quoted 5 lines

There's an out-of-tree reference, the pci.ids website, that carries this information, do we need the reference info in the kernel as well?

So far two people raised an objection, the other wants to maintain an out-of-tree driver, D. Fox didn't say why he needs the symbols.

Three. I already mentioned we broke the compilation of the advansys driver because of this.

Nope, advansys.* don't appear to use PCI_* Defines its own ASC_PCI* instead?

Checked: linux-2.6.13.4, linux-2.6.15-rc2

Grant.

#9 lore raw
Quoted 5 lines · Grant Coady
Quoted 2 lines

Three. I already mentioned we broke the compilation of the advansys driver because of this.

Nope, advansys.* don't appear to use PCI_* Defines its own ASC_PCI* instead?

I stand corrected.

Dave