Skip to contentSkip to conversation

pcilynx.c LIndent fixes

PATCH Jody McIntyre 1 participant 1 message Nov 22, 2005 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

(I'm also sending this to lkml in case people disagree with me or I missed something. Should we put something like this in CodingStyle as a warning to future Lindent users?)

Things that Lindent generally screws up on:

Review

Quoted 4 lines · Jens-Michael Hoffmann
(quoted diff) +2 -2
-MODULE_PARM_DESC(skip_eeprom, "Use generic bus info block instead of serial eeprom (default = 0).");
-
+MODULE_PARM_DESC(skip_eeprom,
+		 "Use generic bus info block instead of serial eeprom (default = 0).");

String handling. I guess this is difficult to sensibly automate, but this should really be something like:

MODULE_PARM_DESC(skip_eeprom,

		 "Use generic bus info block instead of serial eeprom "
		 "(default = 0).");

Review

Quoted 12 lines

[...]

static struct i2c_adapter bit_ops = {

(quoted diff) +4 -4
-	.id 			= 0xAA, //FIXME: probably we should get an id in i2c-id.h
-	.client_register	= bit_reg,
-	.client_unregister	= bit_unreg,
-	.name			= "PCILynx I2C",
+	.id = 0xAA,		//FIXME: probably we should get an id in i2c-id.h
+	.client_register = bit_reg,
+	.client_unregister = bit_unreg,
+	.name = "PCILynx I2C",
 };

That's not better :) The structure was much more readable before the change. This is especially apparent with large structures.

Cheers,
Jody