Skip to contentSkip to conversation

net/ipv4/netfilter/: small cleanups

PATCH Applied Adrian Bunk 2 participants 2 messages Nov 23, 2005 – Nov 30, 2005

Subsystems (3)
Networking Network drivers netfilter
lore
Share & tools
lore

Adrian Bunk

author
#0 lore raw

PATCH 1/1 net/ipv4/netfilter/: small cleanups

This patch contains the following cleanups:
- make needlessly global code static
- ip_conntrack_core.c: ip_conntrack_flush() -> ip_conntrack_flush(void)

Signed-off-by Adrian Bunk <[email protected]>

---

 net/ipv4/netfilter/ip_conntrack_core.c |    4 ++--
 net/ipv4/netfilter/ip_nat_core.c       |    2 +-
 net/ipv4/netfilter/ipt_LOG.c           |    2 +-
 3 files changed, 4 insertions(+), 4 deletions(-)
net/ipv4/netfilter/ip_conntrack_core.c renamed from net/ipv4/netfilter/ip_conntrack_core.c.old +2 -2
@@ -1354,7 +1354,7 @@
 			   get_order(sizeof(struct list_head) * size));
 }
 
-void ip_conntrack_flush()
+void ip_conntrack_flush(void)
 {
 	/* This makes sure all current packets have passed through
            netfilter framework.  Roll on, two-stage module

@@ -1408,7 +1408,7 @@
 	return hash;
 }
 
-int set_hashsize(const char *val, struct kernel_param *kp)
+static int set_hashsize(const char *val, struct kernel_param *kp)
 {
 	int i, bucket, hashsize, vmalloced;
 	int old_vmalloced, old_size;
net/ipv4/netfilter/ipt_LOG.c renamed from net/ipv4/netfilter/ipt_LOG.c.old +1 -1
@@ -351,7 +351,7 @@
 	/* maxlen = 230+   91  + 230 + 252 = 803 */
 }
 
-struct nf_loginfo default_loginfo = {
+static struct nf_loginfo default_loginfo = {
 	.type	= NF_LOG_TYPE_LOG,
 	.u = {
 		.log = {
net/ipv4/netfilter/ip_nat_core.c renamed from net/ipv4/netfilter/ip_nat_core.c.old +1 -1
@@ -49,7 +49,7 @@
 static struct list_head *bysource;
 
 #define MAX_IP_NAT_PROTO 256
-struct ip_nat_protocol *ip_nat_protos[MAX_IP_NAT_PROTO];
+static struct ip_nat_protocol *ip_nat_protos[MAX_IP_NAT_PROTO];
 
 static inline struct ip_nat_protocol *
 __ip_nat_proto_find(u_int8_t protonum)
maintainer Applied
#1 lore raw

From: Adrian Bunk <[email protected]>
Date: Wed, 23 Nov 2005 01:41:08 +0100

Quoted 5 lines

This patch contains the following cleanups:
- make needlessly global code static
- ip_conntrack_core.c: ip_conntrack_flush() -> ip_conntrack_flush(void)

Signed-off-by Adrian Bunk <[email protected]>

Applied, thanks Adrian.