Skip to contentSkip to conversation

Add MIPS dependency for dm9000 driver

PATCH In review Franck 2 participants 3 messages Nov 30, 2005 – Dec 1, 2005

Subsystems (2)
lore
Share & tools
lore

Franck

author
#0 lore raw

PATCH 1/1 Add MIPS dependency for dm9000 driver

The attached patch adds MIPS dependency for dm9000 ethernet controller. Indeed this controller is used by some embedded platforms based on MIPS CPUs.

---

drivers/net/Kconfig +1 -1
index f15f909..1b00169 100644
@@ -856,7 +856,7 @@ config SMC9194
 
 config DM9000
 	tristate "DM9000 support"
-	depends on ARM && NET_ETHERNET
+	depends on (ARM || MIPS) && NET_ETHERNET
 	select CRC32
 	select MII
 	---help---
#1 lore raw
Quoted 12 lines · Franck

The attached patch adds MIPS dependency for dm9000 ethernet controller. Indeed this controller is used by some embedded platforms based on MIPS CPUs.

---

drivers/net/Kconfig +0 -0
index f15f909..1b00169 100644

drivers/net/Kconfig config SMC9194 · line 861

Quoted 7 lines
drivers/net/Kconfig +1 -1
@@ -856,7 +856,7 @@ config SMC9194
 
 config DM9000
 	tristate "DM9000 support"
-	depends on ARM && NET_ETHERNET
+	depends on (ARM || MIPS) && NET_ETHERNET
 	select CRC32
 	select MII

Is there any reason why we cannot enable this driver on all architectures?

It's moderately important for quality and maintainability reasons that it be included in the x86 build, at least..

author
#2 lore raw

Hi Andrew

2005/11/30, Andrew Morton <[email protected]>:

Quoted 7 lines
Quoted 5 lines · Franck

The attached patch adds MIPS dependency for dm9000 ethernet controller. Indeed this controller is used by some embedded platforms based on MIPS CPUs.

Quoted 5 lines

Is there any reason why we cannot enable this driver on all architectures?

It's moderately important for quality and maintainability reasons that it be included in the x86 build, at least..

Actually there's a discussion about that. I previously sent a RFC (subject is "[NET] Remove ARM dependency for dm9000 driver") for that. Now some people are reacting so we should wait for the last words before applying something.

thanks
--
Franck