Skip to contentSkip to conversation

arch/i386/crypto/aes.c: removing unused local variable

PATCH In review Daniel Marjamäki 3 participants 5 messages Nov 29, 2005 – Nov 30, 2005

Subsystems (2)
Kernel janitors Crypto API
lore
Share & tools
lore

Daniel Marjamäki

author
#0 lore raw

PATCH 1/1 arch/i386/crypto/aes.c: removing unused local variable

Hello friends!
There was a warning message (unused variable) about this on the LinuxICC website.

I've removed a variable that is not needed. It is assigned but never read.

Signed-off-by Daniel Marjamäki
arch/i386/crypto/aes.c +0 -10
@@ -93,7 +93,6 @@ static u32 rcon_tab[RC_LENGTH];
 
  u32 ft_tab[4][256];
  u32 fl_tab[4][256];
-static u32 ls_tab[4][256];
  static u32 im_tab[4][256];
  u32 il_tab[4][256];
  u32 it_tab[4][256];

@@ -144,15 +143,6 @@ static void gen_tabs(void)
  		fl_tab[2][i] = upr(w, 2);
  		fl_tab[3][i] = upr(w, 3);
  		
-		/*
-		 * table for key schedule if fl_tab above is
-		 * not of the required form
-		 */
-		ls_tab[0][i] = w;
-		ls_tab[1][i] = upr(w, 1);
-		ls_tab[2][i] = upr(w, 2);
-		ls_tab[3][i] = upr(w, 3);
-		
  		b = fi(inv_affine((u8)i));
  		w = bytes2word(fe(b), f9(b), fd(b), fb(b));

_______________________________________________
Kernel-janitors mailing list
[email protected]
https://lists.osdl.org/mailman/listinfo/kernel-janitors

#1 lore raw

Re: [KJ] [PATCH] arch/i386/crypto/aes.c: removing unused local

Quoted 8 lines · Daniel Marjamäki

Hello friends!
There was a warning message (unused variable) about this on the LinuxICC website.

I've removed a variable that is not needed. It is assigned but never read.

Signed-off-by Daniel Marjamäki

http://www.zip.com.au/~akpm/linux/patches/stuff/tpp.txt

Have a nice day,

- Christophe ([email protected])

_______________________________________________
Kernel-janitors mailing list
[email protected]
https://lists.osdl.org/mailman/listinfo/kernel-janitors

#2 lore raw

Re: [KJ] [PATCH] arch/i386/crypto/aes.c: removing unused local

In reply to Daniel Marjamäki
Quoted 1 line · Daniel Marjam?ki

Content-Type: text/plain; charset=ISO-8859-1; format=flowed

It must be format=flawed. Seriusly, who doubles spaces on context lines? I see [space][space]u32 ft_tab ... again

Please, send a patch to yourself, than try to apply it.

Quoted 24 lines

u32 ft_tab[4][256];
u32 fl_tab[4][256];

arch/i386/crypto/aes.c +0 -10
-static u32 ls_tab[4][256];
 static u32 im_tab[4][256];
 u32 il_tab[4][256];
 u32 it_tab[4][256];

@@ -144,15 +143,6 @@ static void gen_tabs(void)
 		fl_tab[2][i] = upr(w, 2);
 		fl_tab[3][i] = upr(w, 3);
 
-		/*
-		 * table for key schedule if fl_tab above is
-		 * not of the required form
-		 */
-		ls_tab[0][i] = w;
-		ls_tab[1][i] = upr(w, 1);
-		ls_tab[2][i] = upr(w, 2);
-		ls_tab[3][i] = upr(w, 3);
-		
 		b = fi(inv_affine((u8)i));
 		w = bytes2word(fe(b), f9(b), fd(b), fb(b));
Quoted 4 lines

_______________________________________________
Kernel-janitors mailing list
[email protected]
https://lists.osdl.org/mailman/listinfo/kernel-janitors

_______________________________________________
Kernel-janitors mailing list
[email protected]
https://lists.osdl.org/mailman/listinfo/kernel-janitors

author
#3 lore raw

PATCH 1/1 arch/i386/crypto/aes.c: removing unused local variable

In reply to Daniel Marjamäki

This patch removes an unused local variable. The variable is assigned but never read.

Signed-off-by Daniel Marjamäki
arch/i386/crypto/aes.c +0 -10
@@ -93,7 +93,6 @@ static u32 rcon_tab[RC_LENGTH];
 
 u32 ft_tab[4][256];
 u32 fl_tab[4][256];
-static u32 ls_tab[4][256];
 static u32 im_tab[4][256];
 u32 il_tab[4][256];
 u32 it_tab[4][256];

@@ -144,15 +143,6 @@ static void gen_tabs(void)
 		fl_tab[2][i] = upr(w, 2);
 		fl_tab[3][i] = upr(w, 3);
 		
-		/*
-		 * table for key schedule if fl_tab above is
-		 * not of the required form
-		 */
-		ls_tab[0][i] = w;
-		ls_tab[1][i] = upr(w, 1);
-		ls_tab[2][i] = upr(w, 2);
-		ls_tab[3][i] = upr(w, 3);
-		
 		b = fi(inv_affine((u8)i));
 		w = bytes2word(fe(b), f9(b), fd(b), fb(b));

_______________________________________________
Kernel-janitors mailing list
[email protected]
https://lists.osdl.org/mailman/listinfo/kernel-janitors

#4 lore raw

Re: [KJ] [PATCH] arch/i386/crypto/aes.c: removing unused local

In reply to Daniel Marjamäki
Quoted 4 lines · Daniel Marjamäki

This patch removes an unused local variable. The variable is assigned but never read.

Signed-off-by Daniel Marjamäki

A correct Signed-off-by is :

Signed-off-by Christophe Lucas <[email protected]>

Have a nice day,

- Christophe ([email protected])

_______________________________________________
Kernel-janitors mailing list
[email protected]
https://lists.osdl.org/mailman/listinfo/kernel-janitors