Skip to contentSkip to conversation

fs/qnx4/bitmap.c: #if 0 qnx4_new_block()

PATCH In review Adrian Bunk 2 participants 3 messages Dec 3, 2005 QNX4 filesystem

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 fs/qnx4/bitmap.c: #if 0 qnx4_new_block()

qnx4_new_block() is neither implemented nor used.

fs/qnx4/bitmap.c renamed from fs/qnx4/bitmap.c.old +2 -0
@@ -23,10 +23,12 @@
 #include <linux/buffer_head.h>
 #include <linux/bitops.h>
 
+#if 0
 int qnx4_new_block(struct super_block *sb)
 {
 	return 0;
 }
+#endif  /*  0  */
 
 static void count_bits(register const char *bmPart, register int size,
 		       int *const tf)
#1 lore raw
Quoted 11 lines · Adrian Bunk

qnx4_new_block() is neither implemented nor used.

fs/qnx4/bitmap.c 2005-12-03 11:33:07.000000000 +0100 renamed from fs/qnx4/bitmap.c.old 2005-12-03 11:32:46.000000000 +0100 +0 -0
@@ -23,10 +23,12 @@
 #include <linux/buffer_head.h>
 #include <linux/bitops.h>

fs/qnx4/bitmap.c 2005-12-03 11:33:07.000000000 +0100 line 34

Quoted 10 lines
fs/qnx4/bitmap.c 2005-12-03 11:33:07.000000000 +0100 renamed from fs/qnx4/bitmap.c.old 2005-12-03 11:32:46.000000000 +0100 +2 -0
 
+#if 0
 int qnx4_new_block(struct super_block *sb)
 {
        return 0;
 }
+#endif  /*  0  */
 
 static void count_bits(register const char *bmPart, register int size,
                       int *const tf)

Adrian,
You submit a lot of nice patches, but your "#if 0" patches have always puzzled me. Why is it that you prefer to use #if 0 to remove code rather than simply delete it?

--
Jesper Juhl <[email protected]>
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please http://www.expita.com/nomime.html

#2 lore raw
Quoted 19 lines · Jesper Juhl
Quoted 18 lines · Adrian Bunk

qnx4_new_block() is neither implemented nor used.

fs/qnx4/bitmap.c 2005-12-03 11:33:07.000000000 +0100 renamed from fs/qnx4/bitmap.c.old 2005-12-03 11:32:46.000000000 +0100 +2 -0
@@ -23,10 +23,12 @@
 #include <linux/buffer_head.h>
 #include <linux/bitops.h>
 
+#if 0
 int qnx4_new_block(struct super_block *sb)
 {
        return 0;
 }
+#endif  /*  0  */
 
Quoted 8 lines

fs/qnx4/bitmap.c 2005-12-03 11:33:07.000000000 +0100 line 34

Quoted 3 lines
fs/qnx4/bitmap.c 2005-12-03 11:33:07.000000000 +0100 renamed from fs/qnx4/bitmap.c.old 2005-12-03 11:32:46.000000000 +0100 +0 -0
 static void count_bits(register const char *bmPart, register int size,
                       int *const tf)

Adrian,
You submit a lot of nice patches, but your "#if 0" patches have always puzzled me. Why is it that you prefer to use #if 0 to remove code rather than simply delete it?

I started with patches simply deleting the code, but since too often people complained "we might need this code at some time in the future", I've switched to using the #if 0's...

cu
Adrian

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed