swsusp: make image size limit tunable
Subsystems (2)
PATCH 1/1 swsusp: make image size limit tunable
Hi,
The following patch makes the suspend image size limit tunable via /sys/power/image_size.
It is necessary for systems on which there is a limited amount of swap available for suspend. It can also be useful for optimizing performance of swsusp on systems with 1 GB of RAM or more.
This patch depends on the swsusp-limit-image-size patch.
Please apply.
Greetings,
Rafael
Documentation/power/interface.txt | 11 +++++++++++ Documentation/power/swsusp.txt | 7 ++++++- kernel/power/disk.c | 20 ++++++++++++++++++++ kernel/power/power.h | 7 ++----- kernel/power/swsusp.c | 10 +++++++++- 5 files changed, 48 insertions(+), 7 deletions(-)
kernel/power/disk.c +20 -0
@@ -367,9 +367,29 @@power_attr (resume); +static ssize_t image_size_show (struct subsystem * subsys,char *buf) +{ +return sprintf (buf,"%u\n" , image_size); +} + +static ssize_t image_size_store (struct subsystem * subsys,const char * buf,size_t n) +{ +unsigned int size; + +if (sscanf (buf,"%u" , &size) ==1 ) { + image_size = size; +return n; + } + +return -EINVAL ; +} + +power_attr (image_size); +static struct attribute * g[] = { &disk_attr.attr, &resume_attr.attr, + &image_size_attr.attr,NULL , };
kernel/power/power.h +2 -5
@@ -52,11 +52,8 @@extern unsigned int nr_copy_pages;extern struct pbe *pagedir_nosave; -/* -* Preferred image size in MB (set it to zero to get the smallest -* image possible) -*/ -#define IMAGE_SIZE 500 +/* Preferred image size in MB (default 500) */ +extern unsigned int image_size; extern asmlinkage int swsusp_arch_suspend(void); extern asmlinkage int swsusp_arch_resume(void);
kernel/power/swsusp.c +9 -1
@@ -69,6 +69,14 @@#include "power.h" +/* +* Preferred image size in MB (tunable via /sys/power/image_size). +* When it is set to N, swsusp will do its best to ensure the image +* size will not exceed N MB, but if that is impossible, it will +* try to create the smallest image possible. +*/ +unsigned int image_size =500 ; +#ifdef CONFIG_HIGHMEM unsigned int count_highmem_pages (void );int save_highmem (void );
@@ -647,7 +655,7 @@if (!tmp)return -ENOMEM ; pages += tmp; - }else if (size > (IMAGE_SIZE *1024 *1024 ) /PAGE_SIZE ) { + }else if (size > (image_size *1024 *1024 ) /PAGE_SIZE ) { tmp =shrink_all_memory (SHRINK_BITE ); pages += tmp; }
Documentation/power/swsusp.txt +5 -0
@@ -27,6 +27,11 @@ echo platform > /sys/power/disk; echo disk > /sys/power/state +If you want to limit the suspend image size to N megabytes, do + +echo N > /sys/power/image_size + +before suspend (it is limited to 500 MB by default). Encrypted suspend image: ------------------------
Documentation/power/interface.txt +11 -0
@@ -41,3 +41,14 @@ It will only change to 'firmware' or 'platform' if the system supports it. +/sys/power/image_size controls the size of the image created by +the suspend-to-disk mechanism. It can be written a string +representing a non-negative integer that will be used as an upper +limit of the image size, in megabytes. The suspend-to-disk mechanism will +do its best to ensure the image size will not exceed that number. However, +if this turns out to be impossible, it will try to suspend anyway using the +smallest image possible. In particular, if "0" is written to this file, the +suspend image will be as small as possible. + +Reading from this file will display the current image size limit, which +is set to 500 MB by default.
Quoted 9 lines · Rafael J. Wysocki
Hi,
The following patch makes the suspend image size limit tunable via
/sys/power/image_size.It is necessary for systems on which there is a limited amount of swap available for suspend. It can also be useful for optimizing performance of swsusp on systems with 1 GB of RAM or more.
Quoted 6 lines
This patch depends on the swsusp-limit-image-size patch.
Please apply.
Signed-off-by Rafael J. Wysocki <[email protected]>
Signature · 1 line
Thanks, Sharp!