Skip to contentSkip to conversation

EDAC: make Kconfig defaults match recommendations in help text

PATCH New Jesper Juhl 1 participant 1 message Dec 11, 2005 EDAC-core

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 EDAC: make Kconfig defaults match recommendations in help text

"config EDAC" and "config EDAC_MM_EDAC" both state clearly that if the user is unsure she should select "Y", yet the default for those options is "N".

This patch brings the default for the options into line with the recommendation stated in the help text.

Please consider for inclusion.

---

 drivers/edac/Kconfig |    2 ++
 1 files changed, 2 insertions(+)
drivers/edac/Kconfig +2 -0
diff -U 7 linux-2.6.15-rc5-mm2-orig/drivers/edac/Kconfig linux-2.6.15-rc5-mm2/drivers/edac/Kconfig
@@ -7,14 +7,15 @@
 #
 
 menu 'EDAC - error detection and reporting (RAS)'
 
 config EDAC
 	tristate "EDAC core system error reporting"
 	depends on X86
+	default y
 	help
 	  EDAC is designed to report errors in the core system.
 	  These are low-level errors that are reported in the CPU or
 	  supporting chipset: memory errors, cache errors, PCI errors,
 	  thermal throttling, etc..  If unsure, select 'Y'.
 
 
@@ -29,14 +30,15 @@
 	  sub-system. You can insert module with "debug_level=x", current
 	  there're four debug levels (x=0,1,2,3 from low to high).
 	  Usually you should select 'N'.
 
 config EDAC_MM_EDAC
 	tristate "Main Memory EDAC (Error Detection And Correction) reporting"
 	depends on EDAC
+	default y
 	help
 	  Some systems are able to detect and correct errors in main
 	  memory.  EDAC can report statistics on memory error
 	  detection and correction (EDAC - or commonly referred to ECC
 	  errors).  EDAC will also try to decode where these errors
 	  occurred so that a particular failing memory module can be
 	  replaced.  If unsure, select 'Y'.