ACPI boot fix for 2.6.15

PATCH Andi Kleen 2 participants 2 messages Dec 13, 2005 1 message not in the archive ACPI

Share & tools

Andi Kleen

author

2005-12-13 05:28 UTC #0 lore raw

Hallo,

I have the following patch in my x86-64 tree because it was needed to boot without acpi=off on several of the machines here. Without it the ACPI device setup code would always create a loop in the ACPI device tree and eventually some other code walking it would hang the machine.

The patch has been around for a long time - it was originally done by Thomas Renninger - and has even been shipped in SUSE 10.0 so it was well tested
(which was 2.6.13 based, there the problem only hit occasionally, in 2.6.14+ it seems to happen more frequently for some reason)

I think it was queued in the ACPI trees too and acked by the ACPI poeople.

I know Len skipped the ACPI update for .15 for some reason, but could we perhaps merge this safe patch. It would help my test machines at least :)

----

From: [email protected]

Avoid endless loops in ACPI device tree.

Cc [email protected]

Signed-off-by Andi Kleen <[email protected]>

drivers/acpi/scan.c +1 -1

Index: linux/drivers/acpi/scan.c
===================================================================
@@ -1110,7 +1110,7 @@ acpi_add_single_object(struct acpi_devic
 	 *
 	 * TBD: Assumes LDM provides driver hot-plug capability.
 	 */
-	result = acpi_bus_find_driver(device);
+	acpi_bus_find_driver(device);
 
       end:
 	if (!result)

-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files for problems? Stop! Download the new AJAX search engine that makes searching your log files as easy as surfing the web. DOWNLOAD SPLUNK!
http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click

A message that is not in the archive (sent off-list or not yet received): [email protected]

Dave Jones

2005-12-13 05:43 UTC #2 lore raw

Quoted 15 lines · Andi Kleen

Hallo,
I have the following patch in my x86-64 tree because it was needed to boot without acpi=off on several of the machines here. Without it the ACPI device setup code would always create a loop in the ACPI device tree and eventually some other code walking it would hang the machine.
The patch has been around for a long time - it was originally done by Thomas Renninger - and has even been shipped in SUSE 10.0 so it was well tested
(which was 2.6.13 based, there the problem only hit occasionally, in 2.6.14+ it seems to happen more frequently for some reason)

Quoted 6 lines

I think it was queued in the ACPI trees too and acked by the ACPI poeople.
I know Len skipped the ACPI update for .15 for some reason, but could we perhaps merge this safe patch. It would help my test machines at least :)

It got merged on Dec 1st.

Dave