Skip to contentSkip to conversation

Fix user direct access in grant_table.c

PATCH New Tony Breeds 1 participant 1 message Dec 13, 2005

lore
Share & tools
lore

Tony Breeds

author
#0 lore raw

PATCH 1/1 Fix user direct access in grant_table.c

From: Rusty Russell <[email protected]>

Tony found a direct userspace access with his unit test for grant_table.c. We access "uop->frame_list" (a pointer) directly, rather than using "op.frame_list".

Signed-off-by Rusty Russell <[email protected]>
Signed-off-by Tony Breeds <[email protected]>
xen/common/grant_table.c +1 -1
diff -r aebe8f5c7069 xen/common/grant_table.c
@@ -579,7 +579,7 @@
         (void)put_user(GNTST_okay, &uop->status);
         for ( i = 0; i < op.nr_frames; i++ )
             (void)put_user(gnttab_shared_mfn(d, d->grant_table, i),
-                           &uop->frame_list[i]);
+                           &op.frame_list[i]);
     }
 
     put_domain(d);

Yours Tony

linux.conf.au http://linux.conf.au/ || http://lca2006.linux.org.au/
Jan 23-28 2006 The Australian Linux Technical Conference!