SATA ACPI suspend/resume support
cover SATA ACPI suspend/resume support
This is an update to the SATA suspend/resume patches to use ACPI methods (specifically _SDD and _GTF). This patch series applies to 2.6.15-rc5-git3.
It boots but needs lots of testing & review/comments, as well as adding a call to write taskfiles on COMRESET event(s) (at least on async. loss of signal) and freeing ata_device->gtf_address on module unload.
The patchset begins with the libata suspend/resume patch from Jens Axboe and builds on that.
---
~Randy
Quoted 11 lines · Randy Dunlap
This is an update to the SATA suspend/resume patches to use ACPI methods (specifically
_SDDand_GTF). This patch series applies to 2.6.15-rc5-git3.It boots but needs lots of testing & review/comments, as well as adding a call to write taskfiles on COMRESET event(s) (at least on async. loss of signal) and freeing
ata_device->gtf_addresson module unload.The patchset begins with the libata suspend/resume patch from Jens Axboe and builds on that.
overall:
* we do need some way of sending BIOS settings to the devices, so I grudgingly accept this, in concept.
* needs a command line arg that disables ACPI use. libata=noacpi[, option...] would be my suggestion.
* currently assumes that to_pci_dev(struct device *) is valid for all cases. so, need some way to limit calling the ATA ACPI functions, depending on runtime hardware configuration.
* at least one endian bug spotted
Quoted 13 lines · On Wed, 14 Dec 2005 17:29:02 -0500 Jeff Garzik wrote:
Quoted 11 lines · Randy Dunlap
This is an update to the SATA suspend/resume patches to use ACPI methods (specifically
_SDDand_GTF). This patch series applies to 2.6.15-rc5-git3.It boots but needs lots of testing & review/comments, as well as adding a call to write taskfiles on COMRESET event(s) (at least on async. loss of signal) and freeing
ata_device->gtf_addresson module unload.The patchset begins with the libata suspend/resume patch from Jens Axboe and builds on that.
Quoted 7 lines
overall:
* we do need some way of sending BIOS settings to the devices, so I grudgingly accept this, in concept.
* needs a command line arg that disables ACPI use. libata=noacpi[, option...] would be my suggestion.
Jeff, please clarify on this module option.
A module_param() that parallels atapi_enabled (like 'noacpi') won't allow for additional ",option" values after it. It would be a simple int.
Are you suggesting a string parameter (charp) and in-module parsing of a comma-separated option string? If so, why? I don't think that is necessary.
Quoted 5 lines
* currently assumes that
to_pci_dev(struct device *)is valid for all cases. so, need some way to limit calling the ATA ACPI functions, depending on runtime hardware configuration.* at least one endian bug spotted
---
~Randy
Quoted 3 lines · Randy Dunlap
This is an update to the SATA suspend/resume patches to use ACPI methods (specifically
_SDDand_GTF). This patch series applies to 2.6.15-rc5-git3.
...
Randy,
Jeff is obviously a bit too overworked, so I'll save him the trouble by THANKING YOU for working on this!
Keep at it, and it'll make it in. Lots of us need it. LONG overdue.
Cheers!
Quoted 9 lines · On Wed, 14 Dec 2005 22:04:27 -0500 Mark Lord wrote:
Quoted 3 lines · Randy Dunlap
This is an update to the SATA suspend/resume patches to use ACPI methods (specifically
_SDDand_GTF). This patch series applies to 2.6.15-rc5-git3....
Randy,
Jeff is obviously a bit too overworked,
Yes, clearly, but he does good stuff.
Quoted 7 lines
so I'll save him the trouble by THANKING YOU
for working on this!Keep at it, and it'll make it in.
Lots of us need it. LONG overdue.Cheers!
Thanks, I'll make the changes that he suggested and resend them.
---
~Randy