use HOSTCC to determine HOSTCFLAGS

PATCH Applied Isaku Yamahata 2 participants 2 messages Dec 14, 2005

lore

Share & tools

lore

Isaku Yamahata

author

2005-12-14 07:38 UTC #0 lore raw

PATCH 1/1 use HOSTCC to determine HOSTCFLAGS

Hi.

HOSTCC should be used to set HOSTCFLAGS instead of CC.
There is a case where HOSTCC doesn't accept -Wdeclaration-after-statement, while CC does. It results in a compilation error.
This patch fixes it

Signed-off-by Isaku Yamahata <[email protected]>

Signature · 22 lines

diff -r 94cb428d363d -r 164e8408c67a Config.mk
--- a/Config.mk	Mon Dec 12 15:20:51 2005 +0900
+++ b/Config.mk	Mon Dec 12 17:36:35 2005 +0900
@@ -38,10 +38,10 @@
 EXTRA_LIB += $(EXTRA_PREFIX)/$(LIBDIR)
 endif
 
-test-gcc-flag = $(shell $(CC) -v --help 2>&1 | grep -q " $(1) " && echo $(1))
+test-gcc-flag = $(shell $(1) -v --help 2>&1 | grep -q " $(2) " && echo $(2))
 
-HOSTCFLAGS += $(call test-gcc-flag,-Wdeclaration-after-statement)
-CFLAGS     += $(call test-gcc-flag,-Wdeclaration-after-statement)
+HOSTCFLAGS += $(call test-gcc-flag,$(HOSTCC),-Wdeclaration-after-statement)
+CFLAGS     += $(call test-gcc-flag,$(CC),-Wdeclaration-after-statement)
 
 LDFLAGS += $(foreach i, $(EXTRA_LIB), -L$(i)) 
 CFLAGS += $(foreach i, $(EXTRA_INCLUDES), -I$(i))



-- 
yamahata

Ewan Mellor

Applied

2005-12-14 12:22 UTC #1 lore raw

Quoted 8 lines · Isaku Yamahata

Hi.
HOSTCC should be used to set HOSTCFLAGS instead of CC.
There is a case where HOSTCC doesn't accept -Wdeclaration-after-statement, while CC does. It results in a compilation error.
This patch fixes it
Signed-off-by Isaku Yamahata <[email protected]>

Applied, thanks.

Ewan.