Skip to contentSkip to conversation

handle scsi_add_host failure for aic79xx and fix compiler warning

PATCH New Jesper Juhl 1 participant 1 message Dec 14, 2005

Subsystems (2)
SCSI AIC7XXX / AIC79XX SCSI driver
lore
Share & tools
lore

Jesper Juhl

author
#0 lore raw

PATCH 1/1 handle scsi_add_host failure for aic79xx and fix compiler warning

Add scsi_add_host() failure handling for aic79xx
Also silence a compiler warning :
drivers/scsi/aic7xxx/aic79xx_osm.c: In function `ahd_linux_register_host':
drivers/scsi/aic7xxx/aic79xx_osm.c:1099: warning: ignoring return value of `scsi_add_host', declared with attribute warn_unused_result

Signed-off-by Jesper Juhl <[email protected]>

---

 drivers/scsi/aic7xxx/aic79xx_osm.c |   11 +++++++++--
 1 files changed, 9 insertions(+), 2 deletions(-)
drivers/scsi/aic7xxx/aic79xx_osm.c +9 -2
@@ -1064,6 +1064,7 @@ ahd_linux_register_host(struct ahd_softc
 	struct	Scsi_Host *host;
 	char	*new_name;
 	u_long	s;
+	int	retval;
 
 	template->name = ahd->description;
 	host = scsi_host_alloc(template, sizeof(struct ahd_softc *));

@@ -1096,9 +1097,15 @@ ahd_linux_register_host(struct ahd_softc
 
 	host->transportt = ahd_linux_transport_template;
 
-	scsi_add_host(host, &ahd->dev_softc->dev); /* XXX handle failure */
+	retval = scsi_add_host(host, &ahd->dev_softc->dev);
+	if (retval) {
+		printk(KERN_WARNING "aic79xx: scsi_add_host failed\n");
+		scsi_host_put(host);
+		return retval;
+	}
+
 	scsi_scan_host(host);
-	return (0);
+	return 0;
 }
 
 uint64_t