kmap_atomic slot collision
Hi!
I'm trying to use kmap_atomic from both interrupt and task context. My idea was to do local_irq_save and then use KM_IRQ0/KM_IRQ1:
since I'm disabling interrupts I assumed that this should be safe. The relevant code is here:
https://openib.org/svn/gen2/trunk/src/linux-kernel/infiniband/ulp/sdp/sdp_iocb.c
However, under stress I see errors from arch/i386/mm/highmem.c:42
if (!pte_none(*(kmap_pte-idx)))
BUG();Apparently, my routine, running from a task context, races with some other kernel code, and so I'm trying to use a slot that was not yet unmapped.
Anyone has an idea on what I could be doing wrong?
Thanks,
Signature · 1 line
MST
Quoted 9 lines · Michael S. Tsirkin
Hi!
I'm trying to usekmap_atomicfrom both interrupt and task context. My idea was to dolocal_irq_saveand then use KM_IRQ0/KM_IRQ1:
since I'm disabling interrupts I assumed that this should be safe. The relevant code is here:
https://openib.org/svn/gen2/trunk/src/linux-kernel/infiniband/ulp/sdp/sdp_iocb.cHowever, under stress I see errors from
arch/i386/mm/highmem.c:42
Quoted 8 lines
if (!pte_none(*(kmap_pte-idx))) BUG();Apparently, my routine, running from a task context, races with some other kernel code, and so I'm trying to use a slot that was not yet unmapped.
Anyone has an idea on what I could be doing wrong?
kmap slots are like any other CPU-local resources - they need to be protected from context switches and from interrupts. The slots such as KM_USER0 are protected by preempt_disable() to prevent this CPU from context switching and scribbling on this CPU's kmap slot from with another task. kmap_atomic() does this preempt_disable() internally.
The IRQ-context per-cpu kmap slots need to be protected from another IRQ on this CPU by taking local_irq_disable(). IOW:
local_irq_save(flags); vaddr = kmap_atomic(page, KM_IRQ0); diddle(*vaddr); kunmap_atomic(vaddr, KM_IRQ0); local_irq_restore(flags);
Plus we should do flush_dcache_page() if the page can possibly be mapped into process pagetables. I forget whether flush_dcache_page() is safe from hard IRQ context...
If your interrupt handler is using SA_SHIRQ (and most are), then the local_irq_save() is needed even within the IRQ handler.
And lo, a bunch of places in the kernel are forgetting to disable local interrupts. So if your ode is correctly coded as above, you can scribble on their kmap, but they cannot scribble on yours.
Failing to disable local IRQs while taking KM_IRQn is a ghastly bug. I'll fix 'em up.
Quoting Andrew Morton <[email protected]>:
Quoted 4 lines
And lo, a bunch of places in the kernel are forgetting to disable local interrupts. So if your ode is correctly coded as above, you can scribble
on their kmap, but they cannot scribble on yours.
That seems to be what I'm seeing.
Quoted 3 lines
Failing to disable local IRQs while taking
KM_IRQnis a ghastly bug. I'll
fix 'em up.
Thanks!
Pls Cc me on a patch, I'm not on the list.
Signature · 1 line
MST