Skip to contentSkip to conversation

fs/smbfs/proc.c: fix data corruption in smb_proc_setattr_unix()

PATCH New Adrian Bunk 1 participant 1 message Dec 18, 2005

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 fs/smbfs/proc.c: fix data corruption in smb_proc_setattr_unix()

From: Maciej W. Rozycki <[email protected]>

This patch fixes a data corruption in smb_proc_setattr_unix() (smb_filetype_from_mode() returns an u32, and there are only four bytes reserved for it in data.

fs/smbfs/proc.c +1 -1
@@ -3113,7 +3113,7 @@ smb_proc_setattr_unix(struct dentry *d, 
 	LSET(data, 32, SMB_TIME_NO_CHANGE);
 	LSET(data, 40, SMB_UID_NO_CHANGE);
 	LSET(data, 48, SMB_GID_NO_CHANGE);
-	LSET(data, 56, smb_filetype_from_mode(attr->ia_mode));
+	DSET(data, 56, smb_filetype_from_mode(attr->ia_mode));
 	LSET(data, 60, major);
 	LSET(data, 68, minor);
 	LSET(data, 76, 0);