Skip to contentSkip to conversation

i2c: scx200_acb - cleanup and add cs5535

PATCH New Ben Gardner 2 participants 3 messages Dec 19, 2005 – Dec 23, 2005

lore
Share & tools
lore
#0 lore raw

cover i2c: scx200_acb - cleanup and add cs5535

Clean up the scx200_acb driver and add support for the AMD CS5535/CS5536 chips.

The series goes like this:
1. Whitespace and comment cleanup
2. debug log cleanup
3. refactor/simplify code (no functional changes)
4. remove use of lock_kernel()
5. Add support for the CS5535/CS5536
6. Fix and speed up the poll loop
7. Minimal documentation update

Signed-off-by Ben Gardner <bgardner at wabtec.com>
#1 lore raw

cover i2c: scx200_acb - cleanup and add cs5535

Clean up the scx200_acb driver and add support for the AMD CS5535/CS5536 chips.

The series goes like this:
1. Whitespace and comment cleanup
2. debug log cleanup
3. refactor/simplify code (no functional changes)
4. remove use of lock_kernel()
5. Add support for the CS5535/CS5536
6. Fix and speed up the poll loop
7. Minimal documentation update

Signed-off-by Ben Gardner <bgardner at wabtec.com>

---
This is the second version of the series.

#2 lore raw

cover i2c: scx200_acb - cleanup and add

In reply to Ben Gardner

Hi Ben,

Quoted 11 lines

Clean up the scx200_acb driver and add support for the AMD CS5535/CS5536 chips.

The series goes like this:
1. Whitespace and comment cleanup
2. debug log cleanup
3. refactor/simplify code (no functional changes)
4. remove use of lock_kernel()
5. Add support for the CS5535/CS5536
6. Fix and speed up the poll loop
7. Minimal documentation update

Quoted 3 lines
Signed-off-by Ben Gardner <bgardner at wabtec.com>

---
This is the second version of the series.

Looks all OK to me this time. I would only ask for a Kconfig update for this driver. This could be folded into either patch 5 or patch 7. No need to resend the whole series.

Thanks,

Signature · 1 line
Jean Delvare