Linux 2.6.14.5
Subsystems (11)
We (the -stable team) are announcing the release of the 2.6.14.5 kernel.
The diffstat and short summary of the fixes are below.
I'll also be replying to this message with a copy of the patch between 2.6.14.4 and 2.6.14.5, as it is small enough to do so.
The updated 2.6.14.y git tree can be found at:
rsync://rsync.kernel.org/pub/scm/linux/kernel/git/gregkh/linux-2.6.14.y.git
and can be browsed at the normal kernel.org git web browser:
www.kernel.org/git/
thanks,
greg k-h
--------
Makefile | 2 - drivers/acpi/video.c | 2 - drivers/scsi/dpt_i2o.c | 25 ++++++++++++++++----- drivers/scsi/scsi_lib.c | 33 +++++++++++++++++----------- drivers/scsi/sd.c | 16 ------------- drivers/scsi/sr.c | 20 ++-------------- drivers/scsi/st.c | 19 ---------------- drivers/usb/input/hid-input.c | 1 fs/nfsd/nfs2acl.c | 2 - fs/nfsd/nfs3acl.c | 2 - include/linux/rtnetlink.h | 4 +++ include/net/xfrm.h | 1 include/scsi/scsi_cmnd.h | 1 kernel/params.c | 2 - net/8021q/vlan_dev.c | 3 ++ net/bridge/br_netfilter.c | 17 +++++--------- net/ipv4/ip_gre.c | 2 - net/ipv4/netfilter/Makefile | 3 +- net/ipv4/netfilter/ip_conntrack_netlink.c | 4 +-- net/ipv4/netfilter/ip_conntrack_proto_tcp.c | 3 +- net/ipv6/addrconf.c | 16 ++++++++++--- net/ipv6/netfilter/Kconfig | 2 - net/ipv6/route.c | 2 - net/xfrm/xfrm_policy.c | 19 +++++++++++----- net/xfrm/xfrm_state.c | 5 ++++ 25 files changed, 108 insertions(+), 98 deletions(-)
Summary of changes from v2.6.14.4 to v2.6.14.5
==============================================
Andreas Gruenbacher:
setting ACLs on readonly mounted NFS filesystems (CVE-2005-3623)
Bart De Schuymer:
Fix bridge-nf ipv6 length check
David S. Miller:
Perform SA switchover immediately.
Dmitry Torokhov:
Input: fix an OOPS in HID driver
Greg Kroah-Hartman:
Linux 2.6.14.5
Herbert Xu:
Fix hardware checksum modification
Jason Wessel:
kernel/params.c: fix sysfs access with CONFIG_MODULES=n
Kristian Slavov:
Fix RTNLGRP definitions in rtnetlink.h
Krzysztof Oledzki:
Fix CTA_PROTO_NUM attribute size in ctnetlink
Patrick McHardy:
Fix unbalanced read_unlock_bh in ctnetlink Fix NAT init order
Fix incorrect dependency for IP6_NF_TARGET_NFQUEUE
Salyzyn, Mark:
dpt_i2o fix for deadlock condition
Stefan Richter:
SCSI: fix transfer direction in sd (kernel panic when ejecting iPod)
SCSI: fix transfer direction in scsi_lib and st
Stephen Hemminger:
Fix hardware rx csum errors
YOSHIFUJI Hideaki:
Fix route lifetime.
Yu Luming:
apci: fix NULL deref in video/lcd/brightness
Makefile +1 -1
@@ -1,7 +1,7 @@ VERSION = 2 PATCHLEVEL = 6 SUBLEVEL = 14 -EXTRAVERSION = .4 +EXTRAVERSION = .5 NAME=Affluent Albatross # *DOCUMENTATION*
drivers/acpi/video.c +1 -1
@@ -813,7 +813,7 @@ acpi_video_device_write_brightness(strucACPI_FUNCTION_TRACE ("acpi_video_device_write_brightness" ); -if (!dev || count +1 >sizeof str) +if (!dev || !dev->brightness || count +1 >sizeof str)return_VALUE (-EINVAL );if (copy_from_user (str, buffer, count))
drivers/scsi/dpt_i2o.c +20 -5
@@ -660,7 +660,12 @@ static int adpt_abort(struct scsi_cmnd * msg[2 ] =0 ; msg[3 ]=0 ; msg[4 ] = (u32 )cmd; -if ( (rcode =adpt_i2o_post_wait (pHba, msg,sizeof (msg),FOREVER )) !=0 ){ +if (pHba->host) +spin_lock_irq (pHba->host->host_lock); + rcode =adpt_i2o_post_wait (pHba, msg,sizeof (msg),FOREVER ); +if (pHba->host) +spin_unlock_irq (pHba->host->host_lock); +if (rcode !=0 ) {if (rcode == -EOPNOTSUPP ){printk (KERN_INFO "%s: Abort cmd not supported\n" ,pHba->name);return FAILED ;
@@ -697,10 +702,15 @@ static int adpt_device_reset(struct scsi msg[2 ] =0 ; msg[3 ] =0 ; +if (pHba->host) +spin_lock_irq (pHba->host->host_lock); old_state = d->state; d->state |=DPTI_DEV_RESET ; -if ( (rcode =adpt_i2o_post_wait (pHba, msg,sizeof (msg),FOREVER )) ){ - d->state = old_state; + rcode =adpt_i2o_post_wait (pHba, msg,sizeof (msg),FOREVER ); + d->state = old_state; +if (pHba->host) +spin_unlock_irq (pHba->host->host_lock); +if (rcode !=0 ) {if (rcode == -EOPNOTSUPP ){printk (KERN_INFO "%s: Device reset not supported\n" ,pHba->name);return FAILED ;
@@ -708,7 +718,6 @@ static int adpt_device_reset(struct scsiprintk (KERN_INFO "%s: Device reset failed\n" ,pHba->name);return FAILED ; }else { - d->state = old_state;printk (KERN_INFO "%s: Device reset successful\n" ,pHba->name);return SUCCESS ; }
@@ -721,6 +730,7 @@ static int adpt_bus_reset(struct scsi_cm {adpt_hba * pHba;u32 msg[4 ]; +u32 rcode; pHba = (adpt_hba *)cmd->device->host->hostdata[0 ];memset (msg,0 ,sizeof (msg));
@@ -729,7 +739,12 @@ static int adpt_bus_reset(struct scsi_cm msg[1 ] = (I2O_HBA_BUS_RESET <<24 |HOST_TID <<12 |pHba->channel[cmd->device->channel].tid); msg[2 ] =0 ; msg[3 ] =0 ; -if (adpt_i2o_post_wait (pHba, msg,sizeof (msg),FOREVER ) ){ +if (pHba->host) +spin_lock_irq (pHba->host->host_lock); + rcode =adpt_i2o_post_wait (pHba, msg,sizeof (msg),FOREVER ); +if (pHba->host) +spin_unlock_irq (pHba->host->host_lock); +if (rcode !=0 ) {printk (KERN_WARNING "%s: Bus reset failed.\n" ,pHba->name);return FAILED ; }else {
drivers/scsi/scsi_lib.c +21 -12
@@ -1129,6 +1129,26 @@ static void scsi_generic_done(struct scsscsi_io_completion (cmd, cmd->result ==0 ? cmd->bufflen :0 ,0 ); } +void scsi_setup_blk_pc_cmnd (struct scsi_cmnd *cmd,int retries) +{ +struct request *req = cmd->request; + +BUG_ON (sizeof (req->cmd) >sizeof (cmd->cmnd)); +memcpy (cmd->cmnd, req->cmd,sizeof (cmd->cmnd)); + cmd->cmd_len = req->cmd_len; +if (!req->data_len) + cmd->sc_data_direction =DMA_NONE ; +else if (rq_data_dir (req) ==WRITE ) + cmd->sc_data_direction =DMA_TO_DEVICE ; +else + cmd->sc_data_direction =DMA_FROM_DEVICE ; + + cmd->transfersize = req->data_len; + cmd->allowed = retries; + cmd->timeout_per_command = req->timeout; +} +EXPORT_SYMBOL_GPL (scsi_setup_blk_pc_cmnd); +static int scsi_prep_fn (struct request_queue *q,struct request *req) {struct scsi_device *sdev = q->queuedata;
@@ -1264,18 +1284,7 @@ static int scsi_prep_fn(struct request_q goto kill; } }else { -memcpy (cmd->cmnd, req->cmd,sizeof (cmd->cmnd)); - cmd->cmd_len = req->cmd_len; -if (rq_data_dir (req) ==WRITE ) - cmd->sc_data_direction =DMA_TO_DEVICE ; -else if (req->data_len) - cmd->sc_data_direction =DMA_FROM_DEVICE ; -else - cmd->sc_data_direction =DMA_NONE ; - - cmd->transfersize = req->data_len; - cmd->allowed =3 ; - cmd->timeout_per_command = req->timeout; +scsi_setup_blk_pc_cmnd (cmd,3 ); cmd->done = scsi_generic_done; } }
drivers/scsi/sd.c +1 -15
@@ -231,24 +231,10 @@ static int sd_init_command(struct scsi_c* SG_IO from block layer already setup, just copy cdb basically */ if (blk_pc_request (rq)) { -if (sizeof (rq->cmd) >sizeof (SCpnt->cmnd)) -return 0 ; - -memcpy (SCpnt->cmnd, rq->cmd,sizeof (SCpnt->cmnd)); - SCpnt->cmd_len = rq->cmd_len; -if (rq_data_dir (rq) ==WRITE ) - SCpnt->sc_data_direction =DMA_TO_DEVICE ; -else if (rq->data_len) - SCpnt->sc_data_direction =DMA_FROM_DEVICE ; -else - SCpnt->sc_data_direction =DMA_NONE ; - - this_count = rq->data_len; +scsi_setup_blk_pc_cmnd (SCpnt,SD_PASSTHROUGH_RETRIES );if (rq->timeout) timeout = rq->timeout; - SCpnt->transfersize = rq->data_len; - SCpnt->allowed =SD_PASSTHROUGH_RETRIES ; goto queue; }
drivers/scsi/sr.c +3 -17
@@ -320,25 +320,11 @@ static int sr_init_command(struct scsi_c* these are already setup, just copy cdb basically */ if (SCpnt->request->flags &REQ_BLOCK_PC ) { -struct request *rq = SCpnt->request; +scsi_setup_blk_pc_cmnd (SCpnt,MAX_RETRIES ); -if (sizeof (rq->cmd) >sizeof (SCpnt->cmnd)) -return 0 ; - -memcpy (SCpnt->cmnd, rq->cmd,sizeof (SCpnt->cmnd)); - SCpnt->cmd_len = rq->cmd_len; -if (!rq->data_len) - SCpnt->sc_data_direction =DMA_NONE ; -else if (rq_data_dir (rq) ==WRITE ) - SCpnt->sc_data_direction =DMA_TO_DEVICE ; -else - SCpnt->sc_data_direction =DMA_FROM_DEVICE ; - - this_count = rq->data_len; -if (rq->timeout) - timeout = rq->timeout; +if (SCpnt->timeout_per_command) + timeout = SCpnt->timeout_per_command; - SCpnt->transfersize = rq->data_len; goto queue; }
drivers/scsi/st.c +1 -18
@@ -4196,27 +4196,10 @@ static void st_intr(struct scsi_cmnd *SC*/ static int st_init_command (struct scsi_cmnd *SCpnt) { -struct request *rq; -if (!(SCpnt->request->flags &REQ_BLOCK_PC ))return 0 ; - rq = SCpnt->request; -if (sizeof (rq->cmd) >sizeof (SCpnt->cmnd)) -return 0 ; - -memcpy (SCpnt->cmnd, rq->cmd,sizeof (SCpnt->cmnd)); - SCpnt->cmd_len = rq->cmd_len; - -if (rq_data_dir (rq) ==WRITE ) - SCpnt->sc_data_direction =DMA_TO_DEVICE ; -else if (rq->data_len) - SCpnt->sc_data_direction =DMA_FROM_DEVICE ; -else - SCpnt->sc_data_direction =DMA_NONE ; - - SCpnt->timeout_per_command = rq->timeout; - SCpnt->transfersize = rq->data_len; +scsi_setup_blk_pc_cmnd (SCpnt,0 ); SCpnt->done = st_intr;return 1 ; }
drivers/usb/input/hid-input.c +1 -0
@@ -137,6 +137,7 @@ static void hidinput_configure_usage(strswitch (usage->hid &0xffff ) {case 0xba :map_abs (ABS_RUDDER );break ;case 0xbb :map_abs (ABS_THROTTLE );break ; +default : goto ignore; }break ;
fs/nfsd/nfs2acl.c +1 -1
@@ -107,7 +107,7 @@ static int nfsacld_proc_setacl(struct svdprintk ("nfsd: SETACL(2acl) %s\n" ,SVCFH_fmt (&argp->fh)); fh =fh_copy (&resp->fh, &argp->fh); - nfserr =fh_verify (rqstp, &resp->fh,0 ,MAY_NOP ); + nfserr =fh_verify (rqstp, &resp->fh,0 ,MAY_SATTR );if (!nfserr) { nfserr = nfserrno( nfsd_set_posix_acl(
fs/nfsd/nfs3acl.c +1 -1
@@ -101,7 +101,7 @@ static int nfsd3_proc_setacl(struct svc_int nfserr =0 ; fh =fh_copy (&resp->fh, &argp->fh); - nfserr =fh_verify (rqstp, &resp->fh,0 ,MAY_NOP ); + nfserr =fh_verify (rqstp, &resp->fh,0 ,MAY_SATTR );if (!nfserr) { nfserr = nfserrno( nfsd_set_posix_acl(
include/linux/rtnetlink.h +4 -0
@@ -866,6 +866,7 @@ enum rtnetlink_groups {#define RTNLGRP_IPV4_MROUTE RTNLGRP_IPV4_MROUTE RTNLGRP_IPV4_ROUTE,#define RTNLGRP_IPV4_ROUTE RTNLGRP_IPV4_ROUTE + RTNLGRP_NOP1, RTNLGRP_IPV6_IFADDR,#define RTNLGRP_IPV6_IFADDR RTNLGRP_IPV6_IFADDR RTNLGRP_IPV6_MROUTE,
@@ -876,8 +877,11 @@ enum rtnetlink_groups {#define RTNLGRP_IPV6_IFINFO RTNLGRP_IPV6_IFINFO RTNLGRP_DECnet_IFADDR,#define RTNLGRP_DECnet_IFADDR RTNLGRP_DECnet_IFADDR + RTNLGRP_NOP2, RTNLGRP_DECnet_ROUTE,#define RTNLGRP_DECnet_ROUTE RTNLGRP_DECnet_ROUTE +RTNLGRP_NOP3 , +RTNLGRP_NOP4 ,RTNLGRP_IPV6_PREFIX , #define RTNLGRP_IPV6_PREFIX RTNLGRP_IPV6_PREFIX __RTNLGRP_MAX
include/net/xfrm.h +1 -0
@@ -890,6 +890,7 @@ struct xfrm_state * xfrm_find_acq(u8 modextern void xfrm_policy_flush (void );extern int xfrm_sk_policy_insert (struct sock *sk,int dir,struct xfrm_policy *pol);extern int xfrm_flush_bundles (void ); +extern void xfrm_flush_all_bundles (void );extern int xfrm_bundle_ok (struct xfrm_dst *xdst,struct flowi *fl,int family);extern void xfrm_init_pmtu (struct dst_entry *dst);
include/scsi/scsi_cmnd.h +1 -0
@@ -150,5 +150,6 @@ extern struct scsi_cmnd *scsi_get_commanextern void scsi_put_command (struct scsi_cmnd *);extern void scsi_io_completion (struct scsi_cmnd *,unsigned int ,unsigned int );extern void scsi_finish_command (struct scsi_cmnd *cmd); +extern void scsi_setup_blk_pc_cmnd (struct scsi_cmnd *cmd,int retries);#endif /* _SCSI_SCSI_CMND_H */
kernel/params.c +1 -1
@@ -618,7 +618,7 @@ static void __init param_sysfs_builtin(v/* module-related sysfs stuff */ -#ifdef CONFIG_MODULES +#ifdef CONFIG_SYSFS #define to_module_attr (n) container_of(n, struct module_attribute, attr);#define to_module_kobject (n) container_of(n, struct module_kobject, kobj);
net/8021q/vlan_dev.c +3 -0
@@ -165,6 +165,9 @@ int vlan_skb_recv(struct sk_buff *skb, sskb_pull (skb,VLAN_HLEN );/* take off the VLAN header (4 bytes currently) */ +/* Need to correct hardware checksum */ +skb_postpull_rcsum (skb, vhdr,VLAN_HLEN ); +/* Ok, lets check to make sure the device (dev) we * came in on is what this VLAN is attached to. */
net/bridge/br_netfilter.c +7 -10
@@ -295,7 +295,7 @@ static int check_hbh_len(struct sk_buff len -=2 ;while (len >0 ) { -int optlen = raw[off+1 ]+2 ; +int optlen = skb->nh.raw[off+1 ]+2 ;switch (skb->nh.raw[off]) {case IPV6_TLV_PAD0 :
@@ -308,18 +308,15 @@ static int check_hbh_len(struct sk_buffcase IPV6_TLV_JUMBO :if (skb->nh.raw[off+1 ] !=4 || (off&3 ) !=2 ) goto bad; - pkt_len =ntohl (*(u32 *)(skb->nh.raw+off+2 )); - +if (pkt_len <=IPV6_MAXPLEN || + skb->nh.ipv6h->payload_len) + goto bad;if (pkt_len > skb->len -sizeof (struct ipv6hdr )) goto bad; -if (pkt_len +sizeof (struct ipv6hdr ) < skb->len) { -if (__pskb_trim (skb, - pkt_len +sizeof (struct ipv6hdr ))) - goto bad; -if (skb->ip_summed ==CHECKSUM_HW ) - skb->ip_summed =CHECKSUM_NONE ; - } +if (pskb_trim_rcsum (skb, + pkt_len+sizeof (struct ipv6hdr ))) + goto bad;break ;default :if (optlen > len)
net/ipv4/ip_gre.c +1 -1
@@ -617,7 +617,7 @@ static int ipgre_rcv(struct sk_buff *skb skb->mac.raw = skb->nh.raw; skb->nh.raw =__pskb_pull (skb, offset); -skb_postpull_rcsum (skb, skb->mac.raw, offset); +skb_postpull_rcsum (skb, skb->h.raw, offset);memset (&(IPCB (skb)->opt),0 ,sizeof (struct ip_options )); skb->pkt_type =PACKET_HOST ;#ifdef CONFIG_NET_IPGRE_BROADCAST
net/ipv4/netfilter/Makefile +2 -1
@@ -12,6 +12,7 @@ ip_nat_pptp-objs := ip_nat_helper_pptp.o # connection tracking obj-$(CONFIG_IP_NF_CONNTRACK) += ip_conntrack.o +obj-$(CONFIG_IP_NF_NAT) += ip_nat.o # conntrack netlink interface obj-$(CONFIG_IP_NF_CONNTRACK_NETLINK) += ip_conntrack_netlink.o
@@ -41,7 +42,7 @@ obj-$(CONFIG_IP_NF_IPTABLES) += ip_table # the three instances of ip_tables obj-$(CONFIG_IP_NF_FILTER) += iptable_filter.o obj-$(CONFIG_IP_NF_MANGLE) += iptable_mangle.o -obj-$(CONFIG_IP_NF_NAT) += iptable_nat.o ip_nat.o +obj-$(CONFIG_IP_NF_NAT) += iptable_nat.o obj-$(CONFIG_IP_NF_RAW) += iptable_raw.o # matches
net/ipv4/netfilter/ip_conntrack_netlink.c +2 -2
@@ -506,7 +506,7 @@ nfattr_failure: }static const int cta_min_proto[CTA_PROTO_MAX ] = { - [CTA_PROTO_NUM -1 ] =sizeof (u_int16_t), + [CTA_PROTO_NUM -1 ] =sizeof (u_int8_t), [CTA_PROTO_SRC_PORT -1 ] =sizeof (u_int16_t), [CTA_PROTO_DST_PORT -1 ] =sizeof (u_int16_t), [CTA_PROTO_ICMP_TYPE -1 ] =sizeof (u_int8_t),
@@ -532,7 +532,7 @@ ctnetlink_parse_tuple_proto(struct nfattif (!tb[CTA_PROTO_NUM -1 ])return -EINVAL ; - tuple->dst.protonum = *(u_int16_t *)NFA_DATA (tb[CTA_PROTO_NUM -1 ]); + tuple->dst.protonum = *(u_int8_t *)NFA_DATA (tb[CTA_PROTO_NUM -1 ]); proto =ip_conntrack_proto_find_get (tuple->dst.protonum);
net/ipv4/netfilter/ip_conntrack_proto_tcp.c +2 -1
@@ -341,9 +341,10 @@ static int tcp_print_conntrack(struct sestatic int tcp_to_nfattr (struct sk_buff *skb,struct nfattr *nfa,const struct ip_conntrack *ct) { -struct nfattr *nest_parms =NFA_NEST (skb,CTA_PROTOINFO_TCP ); +struct nfattr *nest_parms;read_lock_bh (&tcp_lock); + nest_parms =NFA_NEST (skb,CTA_PROTOINFO_TCP );NFA_PUT (skb,CTA_PROTOINFO_TCP_STATE ,sizeof (u_int8_t), &ct->proto.tcp.state);read_unlock_bh (&tcp_lock);
net/ipv6/addrconf.c +12 -4
@@ -1456,9 +1456,17 @@ void addrconf_prefix_rcv(struct net_devinot good. */ if (valid_lft >=0x7FFFFFFF /HZ ) - rt_expires =0 ; + rt_expires =0x7FFFFFFF - (0x7FFFFFFF %HZ );else - rt_expires = jiffies + valid_lft *HZ ; + rt_expires = valid_lft *HZ ; + +/* +* We convert this (in jiffies) to clock_t later. +* Avoid arithmetic overflow there as well. +* Overflow can happen only if HZ < USER_HZ. +*/ +if (HZ <USER_HZ && rt_expires >0x7FFFFFFF /USER_HZ ) + rt_expires =0x7FFFFFFF /USER_HZ ;if (pinfo->onlink) {struct rt6_info *rt;
@@ -1470,12 +1478,12 @@ void addrconf_prefix_rcv(struct net_deviip6_del_rt (rt,NULL ,NULL ,NULL ); rt =NULL ; }else { - rt->rt6i_expires = rt_expires; + rt->rt6i_expires = jiffies + rt_expires; } } }else if (valid_lft) {addrconf_prefix_route (&pinfo->prefix, pinfo->prefix_len, - dev, rt_expires,RTF_ADDRCONF |RTF_EXPIRES |RTF_PREFIX_RT ); + dev,jiffies_to_clock_t (rt_expires),RTF_ADDRCONF |RTF_EXPIRES |RTF_PREFIX_RT ); }if (rt)dst_release (&rt->u.dst);
net/ipv6/netfilter/Kconfig +1 -1
@@ -211,7 +211,7 @@ config IP6_NF_TARGET_REJECT config IP6_NF_TARGET_NFQUEUE tristate "NFQUEUE Target Support" - depends on IP_NF_IPTABLES + depends on IP6_NF_IPTABLES help This Target replaced the old obsolete QUEUE target.
net/ipv6/route.c +1 -1
@@ -829,7 +829,7 @@ int ip6_route_add(struct in6_rtmsg *rtms } rt->u.dst.obsolete =-1 ; - rt->rt6i_expires =clock_t_to_jiffies (rtmsg->rtmsg_info); + rt->rt6i_expires = jiffies +clock_t_to_jiffies (rtmsg->rtmsg_info);if (nlh && (r =NLMSG_DATA (nlh))) { rt->rt6i_protocol = r->rtm_protocol; }else {
net/xfrm/xfrm_policy.c +14 -5
@@ -1014,13 +1014,12 @@ int __xfrm_route_forward(struct sk_buff }EXPORT_SYMBOL (__xfrm_route_forward); -/* Optimize later using cookies and generation ids. */ -static struct dst_entry *xfrm_dst_check (struct dst_entry *dst,u32 cookie) { -if (!stale_bundle (dst)) -return dst; - +/* If it is marked obsolete, which is how we even get here, +* then we have purged it from the policy bundle list and we +* did that for a good reason. +*/ return NULL ; }
@@ -1104,6 +1103,16 @@ int xfrm_flush_bundles(void)return 0 ; } +static int always_true (struct dst_entry *dst) +{ +return 1 ; +} + +void xfrm_flush_all_bundles (void ) +{ +xfrm_prune_bundles (always_true); +} +void xfrm_init_pmtu (struct dst_entry *dst) { do {
net/xfrm/xfrm_state.c +5 -0
@@ -435,6 +435,8 @@ void xfrm_state_insert(struct xfrm_statespin_lock_bh (&xfrm_state_lock);__xfrm_state_insert (x);spin_unlock_bh (&xfrm_state_lock); + +xfrm_flush_all_bundles (); }EXPORT_SYMBOL (xfrm_state_insert);
@@ -482,6 +484,9 @@ out:spin_unlock_bh (&xfrm_state_lock);xfrm_state_put_afinfo (afinfo); +if (!err) +xfrm_flush_all_bundles (); +if (x1) {xfrm_state_delete (x1);xfrm_state_put (x1);
Quoted 6 lines · Greg KH
We (the -stable team) are announcing the release of the 2.6.14.5 kernel.
The diffstat and short summary of the fixes are below.
I'll also be replying to this message with a copy of the patch between 2.6.14.4 and 2.6.14.5, as it is small enough to do so.
netfilter is broken compared to 2.6.15-rc7 (first 2.6 kernel tested on this box) or 2.4.32 :( Same ruleset as used for months.
Fails to recognise named chains with a useless error message:
"iptables: No chain/target/match by that name"
Grant.
David S. Miller
maintainerFrom: Grant Coady <[email protected]>
Date: Tue, 27 Dec 2005 14:06:03 +1100
Quoted 6 lines
netfilter is broken compared to 2.6.15-rc7 (first 2.6 kernel tested on this box) or 2.4.32 :( Same ruleset as used for months.
Fails to recognise named chains with a useless error message:
"iptables: No chain/target/match by that name"
Please report it to the netfilter mailing list, which is where the netfilter developers listen and can attend to your report.
Thanks a lot.
Quoted 6 lines · David S. Miller
Please report it to the netfilter mailing list, which is where the netfilter developers listen and can attend to your report.
Thanks a lot.
Why bother?
"
Your request to the netfilter-devel mailing list
Posting of your message titled "Re: Linux 2.6.14.5"
has been rejected by the list moderator. The moderator gave the following reason for rejecting your request:
"Non-members are not allowed to post messages to this list."
Any questions or comments should be directed to the list administrator at:
Grant.
Quoted 1 line · Grant Coady
On Mon, 26 Dec 2005 19:33:35 -0800 (PST), "David S. Miller"
Quoted 18 lines · <[email protected]> wrote:
Quoted 5 lines
Please report it to the netfilter mailing list, which is where the netfilter developers listen and can attend to your report.
Thanks a lot.
Why bother?
"
Your request to the netfilter-devel mailing listPosting of your message titled "Re: Linux 2.6.14.5"
has been rejected by the list moderator. The moderator gave the following reason for rejecting your request:
"Non-members are not allowed to post messages to this list."
Quoted 8 lines
Any questions or comments should be directed to the list administrator at:
Grant.
I too have been rejected at that address. Like Grant, why bother seems to be the appropriate response. If they want to here soonest when there is a problem, then the moderator should clear what is obviously not a spam message to the list in a reasonable time frame. Its never happened to me but once and I was bascily told to "go away little boy."
I'm already subbed to about 40 lists, and while there are some I could drop to make room for others, my interests are best described as ecclectic.
If the netfilter folks want to be artificialy quiet, shrug.
Signature · 7 lines
Cheers, Gene People having trouble with vz bouncing email to me should add the word 'online' between the 'verizon', and the dot which bypasses vz's stupid bounce rules. I do use spamassassin too. :-) Yahoo.com and AOL/TW attorneys please note, additions to the above message by Gene Heskett are: Copyright 2005 by Maurice Eugene Heskett, all rights reserved.
Quoted 27 lines · Gene Heskett
Quoted 1 line · Grant Coady
On Mon, 26 Dec 2005 19:33:35 -0800 (PST), "David S. Miller"
Quoted 24 lines · <[email protected]> wrote:
Quoted 5 lines
Please report it to the netfilter mailing list, which is where the netfilter developers listen and can attend to your report.
Thanks a lot.
Why bother?
"
Your request to the netfilter-devel mailing listPosting of your message titled "Re: Linux 2.6.14.5"
has been rejected by the list moderator. The moderator gave the following reason for rejecting your request:
"Non-members are not allowed to post messages to this list."
Any questions or comments should be directed to the list administrator at:
Quoted 8 lines
Quoted 2 lines
Grant.
I too have been rejected at that address. Like Grant, why bother seems to be the appropriate response. If they want to here soonest when there is a problem, then the moderator should clear what is obviously not a spam message to the list in a reasonable time frame. Its never happened to me but once and I was bascily told to "go away little boy."
Moderators of mailing lists scale badly compared to number China-hosted hosts spewing tons of TCP traffic to port 25...
Quoted 5 lines
I'm already subbed to about 40 lists, and while there are some I could drop to make room for others, my interests are best described as ecclectic.
If the netfilter folks want to be artificialy quiet, shrug.
I guess they prefer bugs to be reported thru bugzilla. I just reported one yesterday.
--
vda
Quoted 37 lines · Denis Vlasenko
Quoted 27 lines · Gene Heskett
Quoted 1 line · Grant Coady
On Mon, 26 Dec 2005 19:33:35 -0800 (PST), "David S. Miller"
Quoted 24 lines · <[email protected]> wrote:
Quoted 5 lines
Please report it to the netfilter mailing list, which is where the netfilter developers listen and can attend to your report.
Thanks a lot.
Why bother?
"
Your request to the netfilter-devel mailing listPosting of your message titled "Re: Linux 2.6.14.5"
has been rejected by the list moderator. The moderator gave the following reason for rejecting your request:
"Non-members are not allowed to post messages to this list."
Any questions or comments should be directed to the list administrator at:
Quoted 8 lines
Quoted 2 lines
Grant.
I too have been rejected at that address. Like Grant, why bother seems to be the appropriate response. If they want to here soonest when there is a problem, then the moderator should clear what is obviously not a spam message to the list in a reasonable time frame. Its never happened to me but once and I was bascily told to "go away little boy."
Quoted 2 lines
Moderators of mailing lists scale badly compared to number China-hosted hosts spewing tons of TCP traffic to port 25...
So lose the moderation. It works fine on 10-20 other lists I am on and we are not buried in spam.
Lee
Quoted 11 lines · Grant Coady
Quoted 6 lines · Greg KH
We (the -stable team) are announcing the release of the 2.6.14.5 kernel.
The diffstat and short summary of the fixes are below.
I'll also be replying to this message with a copy of the patch between 2.6.14.4 and 2.6.14.5, as it is small enough to do so.
netfilter is broken compared to 2.6.15-rc7 (first 2.6 kernel tested on this box) or 2.4.32 :( Same ruleset as used for months.
Is it broken compared to 2.6.14.4 and/or 2.6.14? Care to figure out which release broke it?
thanks,
greg k-h
Quoted 7 lines · Greg KH
Quoted 6 lines · Grant Coady
Quoted 4 lines · Greg KH
We (the -stable team) are announcing the release of the 2.6.14.5 kernel.
The diffstat and short summary of the fixes are below.
Quoted 8 lines
Quoted 5 lines
Quoted 2 lines
I'll also be replying to this message with a copy of the patch between 2.6.14.4 and 2.6.14.5, as it is small enough to do so.
netfilter is broken compared to 2.6.15-rc7 (first 2.6 kernel tested on this box) or 2.4.32 :( Same ruleset as used for months.
Is it broken compared to 2.6.14.4 and/or 2.6.14? Care to figure out which release broke it?
2.6.14.4 -> 2.6.14.5 broke it, 2.6.14 also runs okay, some more info on http://bugsplatter.mine.nu/test/boxen/deltree/ -- dmesg, grep = .config.
This box is the bugsplatter web server, currently running 2.6.14.4.
iptables/netfilter is rejecting constructs containing "state NEW", see:
http://bugsplatter.mine.nu/test/boxen/deltree/iptables-vnL-2.6.14.4-dt
vs
http://bugsplatter.mine.nu/test/boxen/deltree/iptables-vnL-2.6.14.5-dt
some numbers masked with 'zxcv' to protect the guilty :)
Grant.
Quoted 5 lines · Grant Coady
netfilter is broken compared to 2.6.15-rc7 (first 2.6 kernel tested on this box) or 2.4.32 :( Same ruleset as used for months.
Fails to recognise named chains with a useless error message:
"iptables: No chain/target/match by that name"
Please give an example of a failing command.
Quoted 9 lines · Patrick McHardy
Quoted 6 lines · Grant Coady
netfilter is broken compared to 2.6.15-rc7 (first 2.6 kernel tested on this box) or 2.4.32 :( Same ruleset as used for months.
Fails to recognise named chains with a useless error message:
"iptables: No chain/target/match by that name"
Please give an example of a failing command.
+ iptables -A INPUT -p all --match state --state ESTABLISHED,RELATED -j ACCEPT
iptables: No chain/target/match by that name
+ iptables -A INPUT -p tcp --match state --state NEW --dport ftp --match limit --limit 3/min -j ACCEPT
iptables: No chain/target/match by that name
+ iptables -A INPUT -p tcp --match state --state NEW --dport ftp -j DROP
iptables: No chain/target/match by that name
+ iptables -A INPUT -p tcp --match state --state NEW --dport http --match limit --limit 12/min -j ACCEPT
iptables: No chain/target/match by that name
+ iptables -A INPUT -p tcp --match state --state NEW --dport http -j DROP
iptables: No chain/target/match by that name
FORWARD + iptables -A FORWARD -p all --match state --state ESTABLISHED,RELATED -j ACCEPT
iptables: No chain/target/match by that name
+ iptables -A egress -p tcp --match state --state NEW --match multiport --dports ftp,http,pop3,nntp,pop3s -j ACCEPT
iptables: No chain/target/match by that name
+ iptables -A egress -p tcp --match state --state NEW --match multiport --dports https,rsync -j ACCEPT
iptables: No chain/target/match by that name
+ iptables -A egress -p all --match state --state NEW --match limit --limit 12/min -j ACCEPT
iptables: No chain/target/match by that name
See also: http://bugsplatter.mine.nu/bash/firewall/rc.firewall.gz
http://bugsplatter.mine.nu/test/boxen/deltree/iptables-vnL-2.6.14.4-dt
http://bugsplatter.mine.nu/test/boxen/deltree/iptables-vnL-2.6.14.5-dt
Grant.
Quoted 9 lines · Grant Coady
Quoted 6 lines · Greg KH
We (the -stable team) are announcing the release of the 2.6.14.5 kernel.
The diffstat and short summary of the fixes are below.
I'll also be replying to this message with a copy of the patch between 2.6.14.4 and 2.6.14.5, as it is small enough to do so.
Quoted 6 lines
netfilter is broken compared to 2.6.15-rc7 (first 2.6 kernel tested on this box) or 2.4.32 :( Same ruleset as used for months.
Fails to recognise named chains with a useless error message:
"iptables: No chain/target/match by that name"
Grant, please put a "set -x" at the top of your script so that you can tell what rule causes this error.
Quoted 1 line
Grant.
Thanks,
Willy
Quoted 13 lines · Willy Tarreau
Quoted 12 lines · Grant Coady
Quoted 6 lines · Greg KH
We (the -stable team) are announcing the release of the 2.6.14.5 kernel.
The diffstat and short summary of the fixes are below.
I'll also be replying to this message with a copy of the patch between 2.6.14.4 and 2.6.14.5, as it is small enough to do so.
netfilter is broken compared to 2.6.15-rc7 (first 2.6 kernel tested on this box) or 2.4.32 :( Same ruleset as used for months.
Quoted 6 lines
Quoted 3 lines
Fails to recognise named chains with a useless error message:
"iptables: No chain/target/match by that name"
Grant, please put a "set -x" at the top of your script so that you can tell what rule causes this error.
+ iptables -A INPUT -p all --match state --state ESTABLISHED,RELATED -j ACCEPT
iptables: No chain/target/match by that name
+ iptables -A INPUT -p tcp --match state --state NEW --dport ftp --match limit --limit 3/min -j ACCEPT
iptables: No chain/target/match by that name
+ iptables -A INPUT -p tcp --match state --state NEW --dport ftp -j DROP
iptables: No chain/target/match by that name
+ iptables -A INPUT -p tcp --match state --state NEW --dport http --match limit --limit 12/min -j ACCEPT
iptables: No chain/target/match by that name
+ iptables -A INPUT -p tcp --match state --state NEW --dport http -j DROP
iptables: No chain/target/match by that name
FORWARD + iptables -A FORWARD -p all --match state --state ESTABLISHED,RELATED -j ACCEPT
iptables: No chain/target/match by that name
+ iptables -A egress -p tcp --match state --state NEW --match multiport --dports ftp,http,pop3,nntp,pop3s -j ACCEPT
iptables: No chain/target/match by that name
+ iptables -A egress -p tcp --match state --state NEW --match multiport --dports https,rsync -j ACCEPT
iptables: No chain/target/match by that name
+ iptables -A egress -p all --match state --state NEW --match limit --limit 12/min -j ACCEPT
iptables: No chain/target/match by that name
Quoted 6 lines
Quoted 2 lines
Grant.
Thanks,
Willy
Quoted 17 lines · Grant Coady
Quoted 15 lines · Willy Tarreau
Quoted 14 lines · Grant Coady
Quoted 6 lines · Greg KH
We (the -stable team) are announcing the release of the 2.6.14.5 kernel.
The diffstat and short summary of the fixes are below.
I'll also be replying to this message with a copy of the patch between 2.6.14.4 and 2.6.14.5, as it is small enough to do so.
netfilter is broken compared to 2.6.15-rc7 (first 2.6 kernel tested on this box) or 2.4.32 :( Same ruleset as used for months.
Fails to recognise named chains with a useless error message:
Quoted 7 lines
Quoted 4 lines
Quoted 1 line
"iptables: No chain/target/match by that name"
Grant, please put a "set -x" at the top of your script so that you can tell what rule causes this error.
+ iptables -A INPUT -p all --match state --state ESTABLISHED,RELATED -j ACCEPT
iptables: No chain/target/match by that name
So it's not only the NEW state, it's every "--match state".
Quoted 8 lines
+ iptables -A INPUT -p tcp --match state --state NEW --dport ftp --match limit --limit 3/min -j ACCEPT
iptables: No chain/target/match by that name
+ iptables -A INPUT -p tcp --match state --state NEW --dport ftp -j DROP
iptables: No chain/target/match by that name
+ iptables -A INPUT -p tcp --match state --state NEW --dport http --match limit --limit 12/min -j ACCEPT
iptables: No chain/target/match by that name
+ iptables -A INPUT -p tcp --match state --state NEW --dport http -j DROP
iptables: No chain/target/match by that name
Quoted 8 lines
FORWARD + iptables -A FORWARD -p all --match state --state ESTABLISHED,RELATED -j ACCEPT
iptables: No chain/target/match by that name
+ iptables -A egress -p tcp --match state --state NEW --match multiport --dports ftp,http,pop3,nntp,pop3s -j ACCEPT
iptables: No chain/target/match by that name
+ iptables -A egress -p tcp --match state --state NEW --match multiport --dports https,rsync -j ACCEPT
iptables: No chain/target/match by that name
+ iptables -A egress -p all --match state --state NEW --match limit --limit 12/min -j ACCEPT
iptables: No chain/target/match by that name
Thanks,
Willy
Quoted 20 lines · Willy Tarreau
Quoted 19 lines · Grant Coady
Quoted 17 lines · Willy Tarreau
Quoted 15 lines · Grant Coady
Quoted 6 lines · Greg KH
We (the -stable team) are announcing the release of the 2.6.14.5 kernel.
The diffstat and short summary of the fixes are below.
I'll also be replying to this message with a copy of the patch between 2.6.14.4 and 2.6.14.5, as it is small enough to do so.
netfilter is broken compared to 2.6.15-rc7 (first 2.6 kernel tested on this box) or 2.4.32 :( Same ruleset as used for months.
Fails to recognise named chains with a useless error message:
"iptables: No chain/target/match by that name"
Quoted 7 lines
Quoted 5 lines
Quoted 2 lines
Grant, please put a "set -x" at the top of your script so that you can tell what rule causes this error.
+ iptables -A INPUT -p all --match state --state ESTABLISHED,RELATED -j ACCEPT
iptables: No chain/target/match by that nameSo it's not only the NEW state, it's every "--match state".
Yep, hard evidence vs the early eyeball check (vs the wrong first impression :o)
Grant.
Quoted 5 lines · Willy Tarreau
Quoted 2 lines · Grant Coady
+ iptables -A INPUT -p all --match state --state ESTABLISHED,RELATED -j ACCEPT
iptables: No chain/target/match by that nameSo it's not only the NEW state, it's every "--match state".
Odd...works fine here
# uname -r 2.6.14.5 # iptables -nL | grep state ACCEPT all -- 0.0.0.0/0 0.0.0.0/0 state RELATED,ESTABLISHED DROP all -- 0.0.0.0/0 0.0.0.0/0 state INVALID logdrop tcp -- 0.0.0.0/0 0.0.0.0/0 tcp flags:!0x17/0x02 state NEW ACCEPT all -- 0.0.0.0/0 0.0.0.0/0 state RELATED,ESTABLISHED DROP all -- 0.0.0.0/0 0.0.0.0/0 state INVALID
Phil
Hi,
From: Phil Oester <[email protected]>
Date: Mon, 26 Dec 2005 22:07:14 -0800
Quoted 8 lines · Willy Tarreau
Quoted 5 lines · Grant Coady
Quoted 2 lines
+ iptables -A INPUT -p all --match state --state ESTABLISHED,RELATED -j ACCEPT
iptables: No chain/target/match by that nameSo it's not only the NEW state, it's every "--match state".
Odd...works fine here
Willy, which version of iptables is ?
And kernel config around netfilter would be helpful.
Regards,
-- Yasuyuki Kozakai
Hi,
From: Phil Oester <[email protected]>
Date: Mon, 26 Dec 2005 22:07:14 -0800
Quoted 8 lines · Willy Tarreau
Quoted 5 lines · Grant Coady
Quoted 2 lines
+ iptables -A INPUT -p all --match state --state ESTABLISHED,RELATED -j ACCEPT
iptables: No chain/target/match by that nameSo it's not only the NEW state, it's every "--match state".
Odd...works fine here
Willy, which version of iptables is ?
And kernel config around netfilter would be helpful.
Regards,
-- Yasuyuki Kozakai
Quoted 9 lines · Phil Oester
Quoted 5 lines · Willy Tarreau
Quoted 2 lines · Grant Coady
+ iptables -A INPUT -p all --match state --state ESTABLISHED,RELATED -j ACCEPT
iptables: No chain/target/match by that nameSo it's not only the NEW state, it's every "--match state".
Odd...works fine here
Quoted 8 lines
# uname -r 2.6.14.5 # iptables -nL | grep state ACCEPT all -- 0.0.0.0/0 0.0.0.0/0 state RELATED,ESTABLISHED DROP all -- 0.0.0.0/0 0.0.0.0/0 state INVALID logdrop tcp -- 0.0.0.0/0 0.0.0.0/0 tcp flags:!0x17/0x02 state NEW ACCEPT all -- 0.0.0.0/0 0.0.0.0/0 state RELATED,ESTABLISHED DROP all -- 0.0.0.0/0 0.0.0.0/0 state INVALID
Oops, my apologies to all, just rebuilt kernel again (third time) from scratch, using the working .config from 2.6.14.4 -- I do not know how I muffed the .config twice in a row on one box without stuffing up the seven other boxen I built/tested 2.6.14.5 on :(
Can copying a working 2.6.15-rc7 .config to 2.6.14.5, then make oldconfig do this?
Grant.
A message that is not in the archive (sent off-list or not yet received): [email protected]
Quoted 11 lines · Yasuyuki KOZAKAI
Hi,
From: Phil Oester <[email protected]>
Date: Mon, 26 Dec 2005 22:07:14 -0800Quoted 5 lines · Willy Tarreau
Quoted 4 lines · Grant Coady
Quoted 2 lines
+ iptables -A INPUT -p all --match state --state ESTABLISHED,RELATED -j ACCEPT
iptables: No chain/target/match by that name
Quoted 6 lines
Quoted 3 lines
Quoted 1 line
So it's not only the NEW state, it's every "--match state".
Odd...works fine here
Willy, which version of iptables is ?
And kernel config around netfilter would be helpful.
Hey, it's Grant who has the problem, not me. Anyway, he fixed it, it seems it was related to an invalid .config.
Quoted 3 lines
Regards,
-- Yasuyuki Kozakai
Regards,
willy
From: Willy Tarreau <[email protected]>
Quoted 11 lines · Yasuyuki KOZAKAI
Quoted 10 lines
From: Phil Oester <[email protected]>
Date: Mon, 26 Dec 2005 22:07:14 -0800Quoted 7 lines · Willy Tarreau
Quoted 5 lines · Grant Coady
Quoted 2 lines
+ iptables -A INPUT -p all --match state --state ESTABLISHED,RELATED -j ACCEPT
iptables: No chain/target/match by that nameSo it's not only the NEW state, it's every "--match state".
Quoted 7 lines
Quoted 4 lines
Quoted 1 line
Odd...works fine here
Willy, which version of iptables is ?
And kernel config around netfilter would be helpful.Hey, it's Grant who has the problem, not me. Anyway, he fixed it, it seems it was related to an invalid .config.
Sorry about this, and thanks for report.
-- Yasuyuki Kozakai
From: Willy Tarreau <[email protected]>
Quoted 11 lines · Yasuyuki KOZAKAI
Quoted 10 lines
From: Phil Oester <[email protected]>
Date: Mon, 26 Dec 2005 22:07:14 -0800Quoted 7 lines · Willy Tarreau
Quoted 5 lines · Grant Coady
Quoted 2 lines
+ iptables -A INPUT -p all --match state --state ESTABLISHED,RELATED -j ACCEPT
iptables: No chain/target/match by that nameSo it's not only the NEW state, it's every "--match state".
Quoted 7 lines
Quoted 4 lines
Quoted 1 line
Odd...works fine here
Willy, which version of iptables is ?
And kernel config around netfilter would be helpful.Hey, it's Grant who has the problem, not me. Anyway, he fixed it, it seems it was related to an invalid .config.
Sorry about this, and thanks for report.
-- Yasuyuki Kozakai