Pending patches
Subsystems (7)
Hello,
find below a list of pending patches from last weeks.
Feel free to update, correct, extend etc.
Hth,
Dirk
List of pending patches for OMAP Linux.
Last modified: 2005/12/27
Pending patches (ready for inclusion):
======================================
1) Fix OMAP audio miscompile
http://linux.omap.com/pipermail/linux-omap-open-source/2005-December/005830.html
2) Fix miscompile if CONFIG_FB_OMAP_LCDC_INTERNAL=n
http://linux.omap.com/pipermail/linux-omap-open-source/2005-December/005831.html
3) Fix omap keypad
http://linux.omap.com/pipermail/linux-omap-open-source/2005-December/005833.html
4) Convert touchscreen to input_allocate_device
http://linux.omap.com/pipermail/linux-omap-open-source/2005-December/005837.html
(input_allocate_device & timer fix)
_or_ (timer fix only!)
OMAP touchscreen timer BUG
http://linux.omap.com/pipermail/linux-omap-open-source/2005-December/005899.html
5) Fix warning in pm.c
http://linux.omap.com/pipermail/linux-omap-open-source/2005-December/005838.html
6) USB clock changes from Juha
http://linux.omap.com/pipermail/linux-omap-open-source/2005-August/004818.html
(http://linux.omap.com/pipermail/linux-omap-open-source/2005-December/005846.html)
(http://linux.omap.com/pipermail/linux-omap-open-source/2005-December/006027.html)
7) OSS Audio L/R Channel Interchanges fix
http://linux.omap.com/pipermail/linux-omap-open-source/2005-December/005890.html
8) omap1510 MPU interupt BUG
http://linux.omap.com/pipermail/linux-omap-open-source/2005-December/005894.html
9) LDM wakeup flags for OMAP keypad
http://linux.omap.com/pipermail/linux-omap-open-source/2005-December/005897.html
10) Add MMC password protection (lock/unlock) support
http://linux.omap.com/pipermail/linux-omap-open-source/2005-December/005911.html
http://linux.omap.com/pipermail/linux-omap-open-source/2005-December/005912.html
http://linux.omap.com/pipermail/linux-omap-open-source/2005-December/005913.html
http://linux.omap.com/pipermail/linux-omap-open-source/2005-December/005914.html
http://linux.omap.com/pipermail/linux-omap-open-source/2005-December/005915.html
http://linux.omap.com/pipermail/linux-omap-open-source/2005-December/005916.html
Note: Still in discussion with RMK?
11) MMC - CONFIG_HOTPLUG support
http://linux.omap.com/pipermail/linux-omap-open-source/2005-December/005963.html
Note: Still in discussion with RMK?
12) ALSA Audio L/R Channel Interchanges fix
http://linux.omap.com/pipermail/linux-omap-open-source/2005-December/005971.html
13) Disable DEBUG_LL in omap_h3_1710_defconfig
http://linux.omap.com/pipermail/linux-omap-open-source/2005-December/005997.html
14) I2C: Use struct platform_driver
http://linux.omap.com/pipermail/linux-omap-open-source/2005-December/006025.html
Experimental & test (do not apply yet):
=======================================
1) omap24xx vout and dispc library
http://linux.omap.com/pipermail/linux-omap-open-source/2005-December/005932.html
2) omap24xx spi + touchscreen
http://linux.omap.com/pipermail/linux-omap-open-source/2005-December/005980.html
3) keypad: platform_data and 24xx support -exp
http://linux.omap.com/pipermail/linux-omap-open-source/2005-December/005889.html
4) omap24xx IrDA update
http://linux.omap.com/pipermail/linux-omap-open-source/2005-December/005992.html
Already applied (by Juha, nothing to do):
=========================================
1) Omapfb: panel enable/disable reordering
http://linux.omap.com/pipermail/linux-omap-open-source/2005-December/005844.html
2) H3 LCD clocking changes suggested by the driver
http://linux.omap.com/pipermail/linux-omap-open-source/2005-December/005898.html
3) fix watchdog
http://linux.omap.com/pipermail/linux-omap-open-source/2005-December/005969.html
Quoted 14 lines
Hello,
find below a list of pending patches from last weeks.
Feel free to update, correct, extend etc.
Hth,
Dirk
List of pending patches for OMAP Linux.
Last modified: 2005/12/27
Quoted 7 lines
Pending patches (ready for inclusion):
======================================11) MMC -
CONFIG_HOTPLUGsupport
http://linux.omap.com/pipermail/linux-omap-open-source/2005-December/005963.htmlNote: Still in discussion with RMK?
I guess it's ok this one. Please, see the lastest RMK e-mail about the patch:
http://linux.omap.com/pipermail/linux-omap-open-source/2005-December/006024.html
BR,
Anderson Briglia
Quoted 7 lines · Dirk Behme
Hello,
find below a list of pending patches from last weeks.
Feel free to update, correct, extend etc. [...]
10) Add MMC password protection (lock/unlock) support
Hi,
These series of patches are not intended for inclusion on linux-omap (they are platform independent). We have CC: ed the linux-omap list because one of the patches is OMAP specific:
http://linux.omap.com/pipermail/linux-omap-open-source/2005-December/005916.html
But this patch is still in discussion, so don't apply it yet.
Regards,
--
Anderson Lizardo
Embedded Linux Lab - 10LE
Nokia Institute of Technology - INdT
Manaus - Brazil
Tony Lindgren
reviewerQuoted 3 lines · Dirk Behme
Hello,
find below a list of pending patches from last weeks.
Cool, this is a nice summary :)
Quoted 1 line
Feel free to update, correct, extend etc.
Anybody else know if pending patches?
Quoted 6 lines
List of pending patches for OMAP Linux.
6) USB clock changes from Juha
http://linux.omap.com/pipermail/linux-omap-open-source/2005-August/004818.html
(http://linux.omap.com/pipermail/linux-omap-open-source/2005-December/005846.html)
(http://linux.omap.com/pipermail/linux-omap-open-source/2005-December/006027.html)
No comments from Dave, so let's plan on pushing the USB clock patches.
Regards,
Tony
Re: Pending patches mostly pushed, please check
Hi all,
I've pushed bunch of patches listed. Please check the status of your patches below.
Also reply to this thread if you know if a patch that you think should be pushed and has not been pushed yet.
Quoted 6 lines · Dirk Behme
Hello,
find below a list of pending patches from last weeks.
Feel free to update, correct, extend etc.
Quoted 8 lines
Hth,
Dirk
List of pending patches for OMAP Linux.
Last modified: 2005/12/27
Last modified: 2006/01/03
Quoted 5 lines
Pending patches (ready for inclusion):
======================================1) Fix OMAP audio miscompile
http://linux.omap.com/pipermail/linux-omap-open-source/2005-December/005830.html
Applied.
Quoted 2 lines
2) Fix miscompile if
CONFIG_FB_OMAP_LCDC_INTERNAL=n
http://linux.omap.com/pipermail/linux-omap-open-source/2005-December/005831.html
Applied.
Quoted 2 lines
3) Fix omap keypad
http://linux.omap.com/pipermail/linux-omap-open-source/2005-December/005833.html
Applied.
Quoted 5 lines
4) Convert touchscreen to
input_allocate_device
http://linux.omap.com/pipermail/linux-omap-open-source/2005-December/005837.html
(input_allocate_device& timer fix)_or_ (timer fix only!)
Dirk, I've only pushed Todd's timer fix below like you suggested. Can you please update your patch?
Quoted 2 lines
OMAP touchscreen timer BUG
http://linux.omap.com/pipermail/linux-omap-open-source/2005-December/005899.html
Applied.
Quoted 2 lines
5) Fix warning in
pm.c
http://linux.omap.com/pipermail/linux-omap-open-source/2005-December/005838.html
Applied.
Quoted 4 lines
6) USB clock changes from Juha
http://linux.omap.com/pipermail/linux-omap-open-source/2005-August/004818.html
(http://linux.omap.com/pipermail/linux-omap-open-source/2005-December/005846.html)
(http://linux.omap.com/pipermail/linux-omap-open-source/2005-December/006027.html)
Applied.
Quoted 2 lines
7) OSS Audio L/R Channel Interchanges fix
http://linux.omap.com/pipermail/linux-omap-open-source/2005-December/005890.html
Applied.
Quoted 2 lines
8) omap1510 MPU interupt BUG
http://linux.omap.com/pipermail/linux-omap-open-source/2005-December/005894.html
Can't read this patch because of the bad formatting... Can you please repost?
Quoted 2 lines
9) LDM wakeup flags for OMAP keypad
http://linux.omap.com/pipermail/linux-omap-open-source/2005-December/005897.html
Let's think about this one a bit more. Maybe we should have u32 device_wakeup in pm.c, and then various drivers would mask it with OMAP_WAKEUP_KEYPAD etc?
Or maybe device_init_wakeup() should register a callback function in the driver, and them pm.c just calls all registered wakeup callback functions? That would move the enable/disable code to drivers.
Quoted 9 lines
10) Add MMC password protection (lock/unlock) support
http://linux.omap.com/pipermail/linux-omap-open-source/2005-December/005911.html
http://linux.omap.com/pipermail/linux-omap-open-source/2005-December/005912.html
http://linux.omap.com/pipermail/linux-omap-open-source/2005-December/005913.html
http://linux.omap.com/pipermail/linux-omap-open-source/2005-December/005914.html
http://linux.omap.com/pipermail/linux-omap-open-source/2005-December/005915.html
http://linux.omap.com/pipermail/linux-omap-open-source/2005-December/005916.htmlNote: Still in discussion with RMK?
Not applied based on comments from Andersons.
Quoted 4 lines
11) MMC -
CONFIG_HOTPLUGsupport
http://linux.omap.com/pipermail/linux-omap-open-source/2005-December/005963.htmlNote: Still in discussion with RMK?
Not applied based on comments from Andersons.
Quoted 2 lines
12) ALSA Audio L/R Channel Interchanges fix
http://linux.omap.com/pipermail/linux-omap-open-source/2005-December/005971.html
Applied.
Quoted 2 lines
13) Disable
DEBUG_LLinomap_h3_1710_defconfig
http://linux.omap.com/pipermail/linux-omap-open-source/2005-December/005997.html
Applied.
Quoted 2 lines
14) I2C: Use struct
platform_driver
http://linux.omap.com/pipermail/linux-omap-open-source/2005-December/006025.html
Applied.
15) Problem on mounting a jffs2 rootfs image
http://linux.omap.com/pipermail/linux-omap-open-source/2006-January/006064.html
Applied.
16) [PATCH] gpio expander debug cleanup
http://linux.omap.com/pipermail/linux-omap-open-source/2006-January/006061.html
Applied.
Quoted 27 lines
Experimental & test (do not apply yet):
=======================================1) omap24xx vout and dispc library
http://linux.omap.com/pipermail/linux-omap-open-source/2005-December/005932.html2) omap24xx spi + touchscreen
http://linux.omap.com/pipermail/linux-omap-open-source/2005-December/005980.html3) keypad:
platform_dataand 24xx support -exp
http://linux.omap.com/pipermail/linux-omap-open-source/2005-December/005889.html4) omap24xx IrDA update
http://linux.omap.com/pipermail/linux-omap-open-source/2005-December/005992.htmlAlready applied (by Juha, nothing to do):
=========================================1) Omapfb: panel enable/disable reordering
http://linux.omap.com/pipermail/linux-omap-open-source/2005-December/005844.html2) H3 LCD clocking changes suggested by the driver
http://linux.omap.com/pipermail/linux-omap-open-source/2005-December/005898.html3) fix watchdog
http://linux.omap.com/pipermail/linux-omap-open-source/2005-December/005969.html
Re: Pending patches mostly pushed, please check
Quoted 7 lines · Tony Lindgren
Hi all,
I've pushed bunch of patches listed. Please check the status of your patches below.
Also reply to this thread if you know if a patch that you think should be pushed and has not been pushed yet.
Umm, here is one more :-)
Remove support for board Netstar. I hope it helped to sort out various needs to drivers and now when nearly everything [1] was converted to platform device there is no more need to bother you with updates to board file :-). I'll maintain it as separate patch (using PTXdist). Thanks for all the fish :-)
Best regards,
ladis
[1] Oh, it seems USB host driver still contains those machine_is_omap_xxx. Will fix that later...
arch/arm/mach-omap1/Kconfig +0 -6
@@ -69,12 +69,6 @@ config MACH_VOICEBLUE Support for Voiceblue GSM/VoIP gateway. Say Y here if you have such a board. -config MACH_NETSTAR - bool "NetStar" - depends on ARCH_OMAP1 && ARCH_OMAP15XX - help - Support for NetStar PBX. Say Y here if you have such a board. - config MACH_OMAP_PALMTE bool "Palm Tungsten E" depends on ARCH_OMAP1 && ARCH_OMAP15XX
arch/arm/mach-omap1/Makefile +0 -1
@@ -20,7 +20,6 @@ obj-$(CONFIG_MACH_OMAP_PERSEUS2) += boar obj-$(CONFIG_MACH_OMAP_OSK) += board-osk.o obj-$(CONFIG_MACH_OMAP_H3) += board-h3.o obj-$(CONFIG_MACH_VOICEBLUE) += board-voiceblue.o -obj-$(CONFIG_MACH_NETSTAR) += board-netstar.o obj-$(CONFIG_MACH_OMAP_PALMTE) += board-palmte.o ifeq ($(CONFIG_ARCH_OMAP15XX),y)
drivers/mtd/nand/Kconfig +4 -4
@@ -50,10 +50,10 @@ config MTD_NAND_SPIA If you had to ask, you don't have one. Say 'N'. config MTD_NAND_OMAP - tristate "NAND Flash device on OMAP H3/H2/P2 or NETSTAR boards" - depends on ARM && ARCH_OMAP1 && MTD_NAND && (MACH_OMAP_H2 || MACH_OMAP_H3 || MACH_NETSTAR || MACH_OMAP_PERSEUS2) - help - Support for NAND flash on Texas Instruments H3/H2/P2/NETSTAR platforms. + tristate "NAND Flash device on OMAP H3/H2/P2 boards" + depends on ARM && ARCH_OMAP1 && MTD_NAND && (MACH_OMAP_H2 || MACH_OMAP_H3 || MACH_OMAP_PERSEUS2) + help + Support for NAND flash on Texas Instruments H3/H2/P2 platforms. config MTD_NAND_TOTO tristate "NAND Flash device on TOTO board"
include/asm-arm/arch-omap/hardware.h +0 -4
@@ -314,10 +314,6 @@#include "board-voiceblue.h" #endif -#ifdef CONFIG_MACH_NETSTAR -#include "board-netstar.h" -#endif -#endif /* !__ASSEMBLER__ */ #endif /* __ASM_ARCH_OMAP_HARDWARE_H */
include/asm-arm/arch-omap/board-netstar.h +0 -19
@@ -1,19 +0,0 @@ -/* -* Copyright (C) 2004 2N Telekomunikace, Ladislav Michl <[email protected]> -* -* Hardware definitions for OMAP5910 based NetStar board. -* -* This program is free software; you can redistribute it and/or modify -* it under the terms of the GNU General Public License version 2 as -* published by the Free Software Foundation. -*/ - -#ifndef __ASM_ARCH_NETSTAR_H -#define __ASM_ARCH_NETSTAR_H - -#include <asm/arch/tc.h> - -#define OMAP_NAND_FLASH_START1 OMAP_CS1_PHYS + (1 << 23) -#define OMAP_NAND_FLASH_START2 OMAP_CS1_PHYS + (2 << 23) - -#endif /* __ASM_ARCH_NETSTAR_H */
arch/arm/mach-omap1/board-netstar.c +0 -160
160 lines not on this page · raw message
Tony Lindgren
reviewerRe: Pending patches mostly pushed, please check
Quoted 9 lines · Ladislav Michl
Quoted 7 lines · Tony Lindgren
Hi all,
I've pushed bunch of patches listed. Please check the status of your patches below.
Also reply to this thread if you know if a patch that you think should be pushed and has not been pushed yet.
Quoted 7 lines
Umm, here is one more :-)
Remove support for board Netstar. I hope it helped to sort out various needs to drivers and now when nearly everything [1] was converted to platform device there is no more need to bother you with updates to board file :-). I'll maintain it as separate patch (using PTXdist). Thanks for all the fish :-)
OK, so long :) Pushing today.
Quoted 5 lines
Best regards,
ladis[1] Oh, it seems USB host driver still contains those
machine_is_omap_xxx. Will fix that later...
OK
Tony
Re: Pending patches mostly pushed, please check
In reply to Tony LindgrenQuoted 3 lines · Tony Lindgren
Also reply to this thread if you know if a patch that you think should be pushed and has not been pushed yet.
Here's one that probably should go in, although del_mtd_partitions + mtdblock is known broken
(http://lists.infradead.org/pipermail/linux-mtd/2004-November/011007.html).
---------- snip
OMAP MTD NOR mapping driver remove partitions created from platform data.
---
commit 54131af1a43d5ddabfd5b96fd74e51de86943894
tree 94686025ea41abb2ecd102e3bb15f93b3e77f09f
parent 91b3e09b5720c0ed00d059a3b95cdf3a4c1a18fb
author Todd Poynor <[email protected]> Tue, 03 Jan 2006 14:31:59 -0800 committer Todd Poynor <[email protected]> Tue, 03 Jan 2006 14:31:59 -0800
drivers/mtd/maps/omap_nor.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-)
drivers/mtd/maps/omap_nor.c +2 -1
@@ -137,11 +137,12 @@ out_free_info: static int __devexit omapflash_remove(struct platform_device *pdev) {struct omapflash_info *info =platform_get_drvdata (pdev); +struct flash_platform_data *pdata = pdev->dev.platform_data;platform_set_drvdata (pdev,NULL );if (info) { -if (info->parts) { +if (info->parts || (pdata && pdata->parts)) {del_mtd_partitions (info->mtd);kfree (info->parts); }else
Tony Lindgren
reviewerRe: Pending patches mostly pushed, please check
Quoted 34 lines · Todd Poynor
Quoted 3 lines · Tony Lindgren
Also reply to this thread if you know if a patch that you think should be pushed and has not been pushed yet.
Here's one that probably should go in, although
del_mtd_partitions+ mtdblock is known broken
(http://lists.infradead.org/pipermail/linux-mtd/2004-November/011007.html).---------- snip
OMAP MTD NOR mapping driver remove partitions created from platform data.
Signed-off-by Todd Poynor <[email protected]>---
commit54131af1a43d5ddabfd5b96fd74e51de86943894
tree94686025ea41abb2ecd102e3bb15f93b3e77f09f
parent91b3e09b5720c0ed00d059a3b95cdf3a4c1a18fb
author Todd Poynor <[email protected]> Tue, 03 Jan 2006 14:31:59 -0800 committer Todd Poynor <[email protected]> Tue, 03 Jan 2006 14:31:59 -0800drivers/mtd/maps/omap_nor.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-)drivers/mtd/maps/omap_nor.c +0
-0@@ -137,11 +137,12 @@ out_free_info: static int __devexit omapflash_remove(struct platform_device *pdev) {struct omapflash_info *info =platform_get_drvdata (pdev);
drivers/mtd/maps/omap_nor.c out_free_info: · line 148
Quoted 10 lines
drivers/mtd/maps/omap_nor.c +2
-1+struct flash_platform_data *pdata = pdev->dev.platform_data;platform_set_drvdata (pdev,NULL );if (info) { -if (info->parts) { +if (info->parts || (pdata && pdata->parts)) {del_mtd_partitions (info->mtd);kfree (info->parts); }else
Just pushed this one.
Tony
Re: Pending patches mostly pushed, please check
In reply to Tony LindgrenQuoted 9 lines · Tony Lindgren
Quoted 2 lines
9) LDM wakeup flags for OMAP keypad
http://linux.omap.com/pipermail/linux-omap-open-source/2005-December/005897.htmlLet's think about this one a bit more. Maybe we should have u32
device_wakeupinpm.c, and then various drivers would mask it withOMAP_WAKEUP_KEYPADetc?Or maybe
device_init_wakeup()should register a callback function in the driver, and thempm.cjust calls all registered wakeup callback functions? That would move the enable/disable code to drivers.
Agreed, I should have labeled this patch as at an RFC stage. It's the first attempt I'm aware of to apply the wakeup flags stuff begun for PCI/USB to an embedded SoC, and was intended to start a discussion on the above sorts of issues, which should also occur on [email protected] (and other embedded-oriented wakeup patches are being floated there as well). It would be nice to move the wakeup enable code to drivers, but with the per-core keypad IRQ assignments, the need to enable level-2 IRQs, etc., not sure if a platform core file ends up being more suitable, don't have a strong opinion myself so far.
On a related note, if anybody knows how to tell what source woke up an OMAP from deep/big sleep I'd appreciate hearing about it. I haven't found a register devoted to it, and keypad wakeup on my H3 seemed to show a pending Level-2 interrupt in the level-1 ITR, but the level-2 ITRs all read zero (reading prior to enabling interrupts upon deep sleep resume). Thanks,
Signature · 1 line
Todd
Tony Lindgren
reviewerRe: Pending patches mostly pushed, please check
Quoted 15 lines · Todd Poynor
Quoted 7 lines · Tony Lindgren
Quoted 2 lines
9) LDM wakeup flags for OMAP keypad
http://linux.omap.com/pipermail/linux-omap-open-source/2005-December/005897.htmlLet's think about this one a bit more. Maybe we should have u32
device_wakeupinpm.c, and then various drivers would mask it withOMAP_WAKEUP_KEYPADetc?Quoted 5 lines
Or maybe
device_init_wakeup()should register a callback function in the driver,
and thempm.cjust calls all registered wakeup callback functions? That would
move the enable/disable code to drivers.
Quoted 9 lines
Agreed, I should have labeled this patch as at an RFC stage. It's the first attempt I'm aware of to apply the wakeup flags stuff begun for PCI/USB to an embedded SoC, and was intended to start a discussion on the above sorts of issues, which should also occur on [email protected] (and other embedded-oriented wakeup patches are being floated there as well). It would be nice to move the wakeup enable code to drivers, but with the per-core keypad IRQ assignments, the need to enable level-2 IRQs, etc., not sure if a platform core file ends up being more suitable, don't have a strong opinion myself so far.
Yeah, let's discuss this on linux-pm.
Quoted 6 lines
On a related note, if anybody knows how to tell what source woke up an OMAP from deep/big sleep I'd appreciate hearing about it. I haven't found a register devoted to it, and keypad wakeup on my H3 seemed to show a pending Level-2 interrupt in the level-1 ITR, but the level-2 ITRs all read zero (reading prior to enabling interrupts upon deep sleep resume). Thanks,
I'd like to know too if there is such a register!
Tony
Re: Pending patches mostly pushed, please check
In reply to Tony LindgrenQuoted 6 lines · --- Tony Lindgren
Quoted 5 lines
Experimental & test (do not apply yet):
=======================================1) omap24xx vout and dispc library
http://linux.omap.com/pipermail/linux-omap-open-source/2005-December/005932.html
Imre,
Could you please reply on this? If needed I can re-work on integration as per your suggestions.
Quoted 11 lines
Quoted 3 lines
3) keypad:
platform_dataand 24xx support -exphttp://linux.omap.com/pipermail/linux-omap-open-source/2005-December/005889.html
Quoted 3 lines
4) omap24xx IrDA update
http://linux.omap.com/pipermail/linux-omap-open-source/2005-December/005992.html
Please comment on keypad and irda patches. If acceptable then I can regenerate them against latest git tree. Thanx.
IrDA patch is now working on H4 without crash.
Patches sitting under my ompt-git tree:
o h4 nand patch (not able to test...as got stuck with x-loader an d u-boot flashing). If someone wants to experiment, I can release.
o OMAP2 spi master controller driver + tsc2101 protocol driver as per david's framework. I have written good amount of the code for this, but not yet working successfully. If someone wants to have fun then I can submit to them.
---Komal Shah
http://komalshah.blogspot.com/
__________________________________________
Yahoo! DSL – Something to write home about.
Just $16.99/mo. or less.
dsl.yahoo.com
PATCH 1/1 Convert touchscreen to input_allocate_device
In reply to Tony LindgrenQuoted 2 lines · Tony Lindgren
Dirk, I've only pushed Todd's timer fix below like you suggested. Can you please update your patch?
ARM: OMAP: Convert touchscreen to input_allocate_device() to remove:
input: device omap_ts is statically allocated, will not register Please convert to input_allocate_device() or contact [email protected]
drivers/input/touchscreen/omap/omap_ts.c renamed from drivers/input/touchscreen/omap/omap_ts.c_orig +18 -18
@@ -65,10 +65,10 @@ static int omap_ts_read(void) ts_omap.dev->read (data); -input_report_abs (&(ts_omap.inputdevice),ABS_X , data[0 ]); -input_report_abs (&(ts_omap.inputdevice),ABS_Y , data[1 ]); -input_report_abs (&(ts_omap.inputdevice),ABS_PRESSURE , data[2 ]); -input_sync (&(ts_omap.inputdevice)); +input_report_abs (ts_omap.inputdevice,ABS_X , data[0 ]); +input_report_abs (ts_omap.inputdevice,ABS_Y , data[1 ]); +input_report_abs (ts_omap.inputdevice,ABS_PRESSURE , data[2 ]); +input_sync (ts_omap.inputdevice);DEBUG_TS ("omap_ts_read: read x=%d,y=%d,p=%d\n" , data[0 ], data[1 ], data[2 ]);
@@ -85,7 +85,7 @@ static void omap_ts_timer(unsigned longif (!ts_omap.dev->penup ()) {if (!ts_omap.touched) {DEBUG_TS ("omap_ts_timer: pen down\n" ); -input_report_key (&(ts_omap.inputdevice),BTN_TOUCH ,1 ); +input_report_key (ts_omap.inputdevice,BTN_TOUCH ,1 ); } ts_omap.touched =1 ;omap_ts_read ();
@@ -95,12 +95,12 @@ static void omap_ts_timer(unsigned longif (ts_omap.touched) {DEBUG_TS ("omap_ts_timer: pen up\n" ); ts_omap.touched =0 ; -input_report_abs (&(ts_omap.inputdevice),ABS_X ,0 ); -input_report_abs (&(ts_omap.inputdevice),ABS_Y ,0 ); -input_report_abs (&(ts_omap.inputdevice),ABS_PRESSURE , +input_report_abs (ts_omap.inputdevice,ABS_X ,0 ); +input_report_abs (ts_omap.inputdevice,ABS_Y ,0 ); +input_report_abs (ts_omap.inputdevice,ABS_PRESSURE ,0 ); -input_sync (&(ts_omap.inputdevice)); -input_report_key (&(ts_omap.inputdevice),BTN_TOUCH ,0 ); +input_sync (ts_omap.inputdevice); +input_report_key (ts_omap.inputdevice,BTN_TOUCH ,0 ); }if (!ts_omap.irq_enabled) { ts_omap.irq_enabled =1 ;
@@ -167,14 +167,14 @@ static int __init omap_ts_probe(struct preturn -EINVAL ; } -init_input_dev (&(ts_omap.inputdevice)); - ts_omap.inputdevice.name =OMAP_TS_NAME ; - ts_omap.inputdevice.dev = &pdev->dev; - ts_omap.inputdevice.evbit[0 ] =BIT (EV_KEY ) |BIT (EV_ABS ); - ts_omap.inputdevice.keybit[LONG (BTN_TOUCH )] |=BIT (BTN_TOUCH ); - ts_omap.inputdevice.absbit[0 ] = + ts_omap.inputdevice =input_allocate_device (); + ts_omap.inputdevice->name =OMAP_TS_NAME ; + ts_omap.inputdevice->dev = &pdev->dev; + ts_omap.inputdevice->evbit[0 ] =BIT (EV_KEY ) |BIT (EV_ABS ); + ts_omap.inputdevice->keybit[LONG (BTN_TOUCH )] |=BIT (BTN_TOUCH ); + ts_omap.inputdevice->absbit[0 ] =BIT (ABS_X ) |BIT (ABS_Y ) |BIT (ABS_PRESSURE ); -input_register_device (&(ts_omap.inputdevice)); +input_register_device (ts_omap.inputdevice); ts_omap.dev->enable ();
@@ -186,7 +186,7 @@ static int __init omap_ts_probe(struct pstatic int omap_ts_remove (struct platform_device *pdev) { ts_omap.dev->disable (); -input_unregister_device (&ts_omap.inputdevice); +input_unregister_device (ts_omap.inputdevice);if (ts_omap.irq !=-1 )free_irq (ts_omap.irq, &ts_omap);
drivers/input/touchscreen/omap/omap_ts.h renamed from drivers/input/touchscreen/omap/omap_ts.h_orig +1 -1
@@ -42,7 +42,7 @@ struct ts_device { };struct omap_ts_t { -struct input_dev inputdevice; +struct input_dev * inputdevice;struct timer_list ts_timer;// Timer for triggering acquisitions int touched;int irq;
Tony Lindgren
reviewerRe: [PATCH] Convert touchscreen to input_allocate_device
Quoted 9 lines · Dirk Behme
Quoted 3 lines · Tony Lindgren
Dirk, I've only pushed Todd's timer fix below like you suggested. Can you please
update your patch?ARM: OMAP: Convert touchscreen to
input_allocate_device()to remove:input: device
omap_tsis statically allocated, will not register Please convert toinput_allocate_device()or contact [email protected]
Pushing this one today, thanks.
Tony
[PATCH] Re: Pending patches mostly pushed, please check
In reply to Tony LindgrenHi Tony,
Quoted 4 lines · Tony Lindgren
Quoted 2 lines
12) ALSA Audio L/R Channel Interchanges fix
http://linux.omap.com/pipermail/linux-omap-open-source/2005-December/005971.htmlApplied.
Can you check if this is really applied? Using most recent git I can still apply it ;-)
There were two similiar patches: One for OSS (is applied, number 7 of the list) and this one for ALSA.
Best regards
Dirk
sound/arm/omap-aic23.c renamed from sound/arm/omap-aic23.c_orig +24 -0
@@ -34,6 +34,8 @@* * 2005-07-29 INdT Kernel Team - Alsa driver for omap osk. Creation of new * file omap-aic23.c +* +* 2005-12-18 Dirk Behme - Added L/R Channel Interchange fix as proposed by Ajaya Babu */ #include <linux/config.h>
@@ -156,6 +158,20 @@ static snd_pcm_hw_constraint_list_t hw_c .mask = 0, }; +/* +* HW interface start and stop helper functions +*/ +static int audio_ifc_start (void ) +{ +omap_mcbsp_start (AUDIO_MCBSP ); +return 0 ; +} + +static int audio_ifc_stop (void ) +{ +omap_mcbsp_stop (AUDIO_MCBSP ); +return 0 ; +}/* * Codec/mcbsp init and configuration section
@@ -243,12 +259,20 @@ static void omap_aic23_audio_init(structSNDRV_PCM_STREAM_PLAYBACK ; omap_aic23->s[SNDRV_PCM_STREAM_PLAYBACK ].dma_dev =OMAP_DMA_MCBSP1_TX ; + omap_aic23->s[SNDRV_PCM_STREAM_PLAYBACK ].hw_start = + audio_ifc_start; + omap_aic23->s[SNDRV_PCM_STREAM_PLAYBACK ].hw_stop = + audio_ifc_stop; omap_aic23->s[SNDRV_PCM_STREAM_CAPTURE ].id ="Alsa AIC23 in" ; omap_aic23->s[SNDRV_PCM_STREAM_CAPTURE ].stream_id =SNDRV_PCM_STREAM_CAPTURE ; omap_aic23->s[SNDRV_PCM_STREAM_CAPTURE ].dma_dev =OMAP_DMA_MCBSP1_RX ; + omap_aic23->s[SNDRV_PCM_STREAM_CAPTURE ].hw_start = + audio_ifc_start; + omap_aic23->s[SNDRV_PCM_STREAM_CAPTURE ].hw_stop = + audio_ifc_stop;/* configuring the McBSP */ omap_mcbsp_request (AUDIO_MCBSP );
sound/arm/omap-aic23.h renamed from sound/arm/omap-aic23.h_orig +4 -1
@@ -33,7 +33,8 @@* 2005/07/25 INdT-10LE Kernel Team - Alsa driver for omap osk, * original version based in sa1100 driver * and omap oss driver. -* +* +* 2005-12-18 Dirk Behme - Added L/R Channel Interchange fix as proposed by Ajaya Babu */ #ifndef __OMAP_AIC23_H
@@ -85,6 +86,8 @@ struct audio_stream {snd_pcm_substream_t *stream;/* the pcm stream */ unsigned linked:1; /* dma channels linked */int offset;/* store start position of the last period in the alsa buffer */ +int (*hw_start)(void );/* interface to start HW interface, e.g. McBSP */ +int (*hw_stop)(void );/* interface to stop HW interface, e.g. McBSP */ };/*
sound/arm/omap-alsa-dma.c renamed from sound/arm/omap-alsa-dma.c_orig +5 -1
@@ -34,7 +34,9 @@* 2005-07-19 INdT Kernel Team - Alsa port. Creation of new file omap-alsa-dma.c based in * omap-audio-dma-intfc.c oss file. Support for aic23 codec. * Removal of buffer handling (Alsa does that), modifications -* in dma handling and port to alsa structures. +* in dma handling and port to alsa structures. +* +* 2005-12-18 Dirk Behme - Added L/R Channel Interchange fix as proposed by Ajaya Babu */ #include <linux/config.h>
@@ -356,8 +358,10 @@ static int audio_start_dma_chain(structint channel = s->lch[s->dma_q_head];FN_IN ;if (!s->started) { + s->hw_stop ();/* stops McBSP Interface */ omap_start_dma (channel); s->started =1 ; + s->hw_start ();/* start McBSP interface */ }/* else the dma itself will progress forward with out our help */ FN_OUT (0 );
Tony Lindgren
reviewerRe: [PATCH] Re: Pending patches mostly pushed, please check
Quoted 7 lines · Dirk Behme
Hi Tony,
Quoted 3 lines · Tony Lindgren
Quoted 2 lines
12) ALSA Audio L/R Channel Interchanges fix
http://linux.omap.com/pipermail/linux-omap-open-source/2005-December/005971.html
Quoted 7 lines
Quoted 1 line
Applied.
Can you check if this is really applied? Using most recent git I can still apply it ;-)
There were two similiar patches: One for OSS (is applied, number 7 of the list) and this one for ALSA.
Thanks for checking, I had indeed missed this one.
Tony