Skip to contentSkip to conversation

block-destroy test06 issue in some machines

PATCH Applied Glauber de Oliveira Costa 2 participants 2 messages Jan 3, 2006 – Jan 9, 2006

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 block-destroy test06 issue in some machines

Hi all,

As hotplug events are asynchronous by its nature, the remove event seems to be missed in some environments. This patch adds a sleep (with the same
amount of time of the one after xm block-detach) between attach and detach operations, giving attach enough time to complete, making test 06 suceed.

Signature · 1 line
glommer

# HG changeset patch
# User root@kct
# Node ID 8f6d4878d02e65438dabda642d7bf84679dbd464
# Parent 5b30599761b3f0b85e6bb1768f0236294881e900
As hotplug events are asynchronous by its nature, the remove event seems to be missed in some environments. This patch adds a sleep (with the same amount of time of the one after xm block-detach) between attach and detach operations, giving attach enough time to complete, making test 06 suceed.

tools/xm-test/tests/block-destroy/06_block-destroy_check_list_pos.py +2 -0
diff -r 5b30599761b3 -r 8f6d4878d02e tools/xm-test/tests/block-destroy/06_block-destroy_check_list_pos.py
@@ -46,6 +46,8 @@
 if not checkXmLongList(domain):
     FAIL("xm long list does not show that hda1 was attached")
 
+time.sleep(2)
+
 s, o = traceCommand("xm block-detach %s hda1" % domain.getName())
 if s != 0:
     FAIL("block-detach failed")

_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xensource.com/xen-devel

Applied
#1 lore raw
Quoted 8 lines · Glauber de Oliveira Costa

Hi all,

As hotplug events are asynchronous by its nature, the remove event seems to be missed in some environments. This patch adds a sleep (with the same
amount of time of the one after xm block-detach) between attach and detach operations, giving attach enough time to complete, making test 06 suceed.

Applied, thank you.

Ewan.