Skip to contentSkip to conversation

i386: Optimize local APIC timer interrupt code

PATCH Chuck Ebbert 1 participant 1 message Jan 5, 2006

lore
Share & tools
lore
#0 lore raw

In-Reply-To: <[email protected]>

Quoted 1 line · Willy Tarreau

+ if (likely(--per_cpu(prof_counter, cpu)) <= 0) {

            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

are you sure about this ? it looks suspicious to me. I would have expected something like this instead :

+ if (likely(--per_cpu(prof_counter, cpu) <= 0)) {

Nice catch, proving yet again the value of posting code for review!

Signature · 2 lines
Chuck
Currently reading: _Thud!_ by Terry Pratchett