Allow iseries to disable input layer without CONFIG_EMBEDDED
iSeries has no keyboard, so it's valid to build a kernel with no input layer. It seems a bit absurd to call one of these 'embedded'.
drivers/input/Kconfig renamed from drivers/input/Kconfig~ +1 -1
@@ -5,7 +5,7 @@ menu "Input device support" config INPUT - tristate "Generic input layer (needed for keyboard, mouse, ...)" if EMBEDDED + tristate "Generic input layer (needed for keyboard, mouse, ...)" default y ---help--- Say Y here if you have any input device (mouse, keyboard, tablet,
Quoted 2 lines · Dave Jones
iSeries has no keyboard, so it's valid to build a kernel with no input layer. It seems a bit absurd to call one of these 'embedded'.
Please just remove the EMBEDDED here - there's tons of plattforms without input that certainly aren't embedded. In fact I've seen very few non-x86 servers with any input devices.
Quoted 7 lines · Christoph Hellwig
Quoted 2 lines · Dave Jones
iSeries has no keyboard, so it's valid to build a kernel with no input layer. It seems a bit absurd to call one of these 'embedded'.
Please just remove the EMBEDDED here - there's tons of plattforms without input that certainly aren't embedded. In fact I've seen very few non-x86 servers with any input devices.
That's what the patch did :)
Dave
Quoted 10 lines · Dave Jones
Quoted 7 lines · Christoph Hellwig
Quoted 2 lines · Dave Jones
iSeries has no keyboard, so it's valid to build a kernel with no input layer. It seems a bit absurd to call one of these 'embedded'.
Please just remove the EMBEDDED here - there's tons of plattforms without input that certainly aren't embedded. In fact I've seen very few non-x86 servers with any input devices.
That's what the patch did :)
oops, sorry. I should read the patch and not just the description..
... off and grabbing another tea to really wake up
Quoted 8 lines · Dave Jones
iSeries has no keyboard, so it's valid to build a kernel with no input layer. It seems a bit absurd to call one of these 'embedded'.
Signed-off-by Dave Jones <[email protected]>
drivers/input/Kconfig line 11
Quoted 8 lines
drivers/input/Kconfig renamed from drivers/input/Kconfig~ +1
-1@@ -5,7 +5,7 @@ menu "Input device support" config INPUT - tristate "Generic input layer (needed for keyboard, mouse, ...)" if EMBEDDED + tristate "Generic input layer (needed for keyboard, mouse, ...)" default y ---help--- Say Y here if you have any input device (mouse, keyboard, tablet,
It is there as a precaution... I wonder if we should have it changed to:
if EMBEDDED || !X86
to ensure that we don't have issues on commodity hardware.
Signature · 1 line
Dmitry