Skip to contentSkip to conversation

remove drivers/net/tulip/xircom_tulip_cb.c

PATCH In review Adrian Bunk 4 participants 4 messages Jan 6, 2006 – Jan 9, 2006

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 remove drivers/net/tulip/xircom_tulip_cb.c

This patch removes the obsolete drivers/net/tulip/xircom_tulip_cb.c driver.

---

This patch was already sent on:
- 12 Dec 2005
- 18 Nov 2005

 drivers/net/tulip/Kconfig           |   16 
 drivers/net/tulip/Makefile          |    1 
 drivers/net/tulip/xircom_tulip_cb.c | 1748 ----------------------------
 3 files changed, 1 insertion(+), 1764 deletions(-)
drivers/net/tulip/Kconfig renamed from drivers/net/tulip/Kconfig.old +1 -15
@@ -148,7 +148,7 @@
 	  be called uli526x.
 	  
 config PCMCIA_XIRCOM
-	tristate "Xircom CardBus support (new driver)"
+	tristate "Xircom CardBus support"
 	depends on NET_TULIP && CARDBUS
 	---help---
 	  This driver is for the Digital "Tulip" Ethernet CardBus adapters.
@@ -160,19 +160,5 @@
 	  <file:Documentation/networking/net-modules.txt>.  The module will
 	  be called xircom_cb.  If unsure, say N.
 
-config PCMCIA_XIRTULIP
-	tristate "Xircom Tulip-like CardBus support (old driver)"
-	depends on NET_TULIP && CARDBUS && BROKEN_ON_SMP
-	select CRC32
-	---help---
-	  This driver is for the Digital "Tulip" Ethernet CardBus adapters.
-	  It should work with most DEC 21*4*-based chips/ethercards, as well
-	  as with work-alike chips from Lite-On (PNIC) and Macronix (MXIC) and
-	  ASIX.
-
-	  To compile this driver as a module, choose M here and read
-	  <file:Documentation/networking/net-modules.txt>.  The module will
-	  be called xircom_tulip_cb.  If unsure, say N.
-
 endmenu
 
drivers/net/tulip/Makefile renamed from drivers/net/tulip/Makefile.old +0 -1
@@ -2,7 +2,6 @@
 # Makefile for the Linux "Tulip" family network device drivers.
 #
 
-obj-$(CONFIG_PCMCIA_XIRTULIP)	+= xircom_tulip_cb.o
 obj-$(CONFIG_PCMCIA_XIRCOM)	+= xircom_cb.o
 obj-$(CONFIG_DM9102)		+= dmfe.o
 obj-$(CONFIG_WINBOND_840)	+= winbond-840.o
drivers/net/tulip/xircom_tulip_cb.c deleted +0 -1748

1,748 lines not on this page · raw message

#1 lore raw
Quoted 5 lines · Adrian Bunk

This patch removes the obsolete drivers/net/tulip/xircom_tulip_cb.c driver.

NACK... xircom_cb (while written by me and thus purrrrrfect, doesn't work for everyone). This chip is so f*cked up that it may not even be possible to get all the variants working with only 1 driver ;-(

#2 lore raw
Quoted 3 lines · Arjan van de Ven
Quoted 1 line · Adrian Bunk

This patch removes the obsolete drivers/net/tulip/xircom_tulip_cb.c driver.

..

Quoted 3 lines

NACK... xircom_cb (while written by me and thus purrrrrfect, doesn't work for everyone). This chip is so f*cked up that it may not even be possible to get all the variants working with only 1 driver ;-(

Agreed (regretably).

The cardbus Xircom 10/100 + (real)modem cards only ever worked for me using the xircom_tulip_cb driver. Best to keep both drivers.

Sadly, I recently sold my ancient notebook, and the card went with it.

-ml

#3 lore raw
In reply to Arjan van de Ven
Quoted 11 lines · Arjan van de Ven
Quoted 5 lines · Adrian Bunk

This patch removes the obsolete drivers/net/tulip/xircom_tulip_cb.c driver.

NACK... xircom_cb (while written by me and thus purrrrrfect, doesn't work for everyone). This chip is so f*cked up that it may not even be possible to get all the variants working with only 1 driver ;-(

It is even more funny: i discovered that it depends on the type of ethernet switch to determine which driver i have to use.

- extreme Summit48 _or_ crossover cable to some onboard via rhine:
xircom_tulip_cb
- el-cheapo mini-switch, probably realtek inside:
xircom_cb

and yes, i tried all different autonegotiation settings etc (with xircom_tulip_cb at least since xircom_cb seems to lack ethtool support).

It also seems to additionally depend on which machine i put these cards into and of course on the chip revision and the phase of the moon.

If i ever figure out a pattern, i'll file a bug.
For now i changed to a machine with a decent built-in card instead of rtl8169 crap (which forced me to pull out the xircom cards again).

And "not working" was of course not "not working at all" but "works somehow but with inferior performance" for both drivers.

Signature · 3 lines
Stefan Seyfried                  \ "I didn't want to write for pay. I
QA / R&D Team Mobile Devices      \ wanted to be paid for what I write."
SUSE LINUX Products GmbH, Nürnberg \                    -- Leonard Cohen