scsi_transport_spi.c: make print_nego() static
PATCH 1/1 scsi_transport_spi.c: make print_nego() static
This patch makes a needlessly global function static.
Signed-off-by Adrian Bunk <[email protected]>
drivers/scsi/scsi_transport_spi.c renamed from drivers/scsi/scsi_transport_spi.c.old +1 -1
@@ -1075,7 +1075,7 @@ /* 0x04 */ "Parallel Protocol Request" }; -void print_nego (const unsigned char *msg,int per,int off,int width) +static void print_nego (const unsigned char *msg,int per,int off,int width) {if (per) {char buf[20 ];
Quoted 1 line · Adrian Bunk
This patch makes a needlessly global function static.
Sure, makes sense. Thanks.
Quoted 1 line · Adrian Bunk
This patch makes a needlessly global function static.
Ok, so this is probably a stupid question and it may have been already discussed but.....
Isn't possible that GCC would/will add an extension (a useful one) similar to the visibility thing that c++ got in GCC 4.x? It somewhat weird that we need to mark things static, instead of the contrary (marking as global the things you want to make global, would be much nicer since the functions made global would be the "API")