mark virt_to_bus/bus_to_virt as __deprecated on i386
PATCH 1/1 mark virt_to_bus/bus_to_virt as __deprecated on i386
virt_to_bus/bus_to_virt are long deprecated, mark them as __deprecated on i386.
Without such warnings people will never update their code and fix Andrew's all*config ppc64 builds.
---
This patch was already sent on:
- 13 Dec 2005
- 23 Nov 2005
- 18 Nov 2005
- 12 Nov 2005
include/asm-i386/io.h renamed from include/asm-i386/io.h.old +8 -2
@@ -144,8 +144,14 @@* * Allow them on x86 for legacy drivers, though. */ -#define virt_to_bus virt_to_phys -#define bus_to_virt phys_to_virt +static inline unsigned long __deprecated virt_to_bus (volatile void * address) +{ +return __pa (address); +} +static inline void *__deprecated bus_to_virt (unsigned long address) +{ +return __va (address); +}/* * readX/writeX() are used to access memory mapped devices. On some
Quoted 3 lines · Adrian Bunk
virt_to_bus/bus_to_virt are long deprecated, mark them as
__deprecated
on i386.
This spews screenfuls of crap at me. Crap which nobody is going to fix.
Sorry, nope.
Quoted 8 lines · Andrew Morton
Quoted 3 lines · Adrian Bunk
virt_to_bus/bus_to_virt are long deprecated, mark them as
__deprecated
on i386.This spews screenfuls of crap at me. Crap which nobody is going to fix.
Sorry, nope.
This is the usual chicken and egg problem:
Without a warning noone will fix the code.
And yes, some of the drivers affected seem to be maintained (and 49 warnings come from OSS drivers with ALSA replacements another patch I sent removes from the kernel).
They might not show up in your all*config builds that set SMP=y, but the warnings with my patch aren't worse than the one's BROKEN_ON_SMP drivers are spitting.
cu
Adrian
Signature · 4 lines
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed