Skip to contentSkip to conversation

trivial: add CDC_RAM to ide-cd capabilities mask

PATCH In review Andrey Borzenkov 2 participants 2 messages Jan 9, 2006 – Jan 10, 2006 libata

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 trivial: add CDC_RAM to ide-cd capabilities mask

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Add CDC-RAM to capability mask. This prevents udev incorrectly reporting RAM capabilities for device.

- ---

- --- linux-2.6.15/drivers/ide/ide-cd.c.orig 2006-01-03 06:21:10.000000000 +0300
+++ linux-2.6.15/drivers/ide/ide-cd.c 2006-01-09 00:31:32.000000000 +0300
@@ -2905,6 +2905,8 @@ static int ide_cdrom_register (ide_drive
devinfo->mask |= CDC_CLOSE_TRAY;
if (!CDROM_CONFIG_FLAGS(drive)->mo_drive)
devinfo->mask |= CDC_MO_DRIVE;
+ if (!CDROM_CONFIG_FLAGS(drive)->ram)
+ devinfo->mask |= CDC_RAM;

devinfo->disk = info->disk;
return register_cdrom(devinfo);
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (GNU/Linux)

iD8DBQFDwsSvR6LMutpd94wRAuyRAKDVr66aA5cGLoQAliK20dz7FbTP+wCfb8C3 qCm1Sur7eFjCh2i1J95qI68=
=i3pt
-----END PGP SIGNATURE-----

#1 lore raw
Quoted 13 lines · Andrey Borzenkov

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Add CDC-RAM to capability mask. This prevents udev incorrectly reporting RAM capabilities for device.

- ---

- --- linux-2.6.15/drivers/ide/ide-cd.c.orig 2006-01-03 06:21:10.000000000 +0300
+++ linux-2.6.15/drivers/ide/ide-cd.c 2006-01-09 00:31:32.000000000 +0300

Review static int ide_cdrom_register (ide_drive · line 2912

Quoted 8 lines
(quoted diff) +2 -0
@@ -2905,6 +2905,8 @@ static int ide_cdrom_register (ide_drive
 		devinfo->mask |= CDC_CLOSE_TRAY;
 	if (!CDROM_CONFIG_FLAGS(drive)->mo_drive)
 		devinfo->mask |= CDC_MO_DRIVE;
+	if (!CDROM_CONFIG_FLAGS(drive)->ram)
+		devinfo->mask |= CDC_RAM;
 
 	devinfo->disk = info->disk;
 	return register_cdrom(devinfo);

Thanks, patch is correct.

Signature · 1 line
Jens Axboe