Skip to contentSkip to conversation

CONFIG_AIRO needs CONFIG_CRYPTO

PATCH New dann frazier 2 participants 2 messages Jan 8, 2006 – Jan 10, 2006 4 messages not in the archive Networking drivers (wireless)

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): 20051220211944.19259.91642.reportbug@mirexpress.internal.placard.fr.eu.org

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

#4 lore raw

PATCH 1/1 CONFIG_AIRO needs CONFIG_CRYPTO

airo.c currently has MICSUPPORT enabled, which requires CONFIG_CRYPTO. A user reported a build failure which is due to the lack of a Kconfig dependency. See http://bugs.debian.org/344205.

This patch makes Kconfig enforce this dependency.

drivers/net/wireless/Kconfig renamed from drivers/net/wireless/Kconfig~ +1 -1
@@ -243,7 +243,7 @@
 
 config AIRO
 	tristate "Cisco/Aironet 34X/35X/4500/4800 ISA and PCI cards"
-	depends on NET_RADIO && ISA_DMA_API && (PCI || BROKEN)
+	depends on NET_RADIO && ISA_DMA_API && CRYPTO && (PCI || BROKEN)
 	---help---
 	  This is the standard Linux driver to support Cisco/Aironet ISA and
 	  PCI 802.11 wireless cards.
#5 lore raw

PATCH 1/1 fix AIRO{,_CS} <-> CRYPTO

Quoted 8 lines · dann frazier

airo.c currently has MICSUPPORT enabled, which requires CONFIG_CRYPTO. A user reported a build failure which is due to the lack of a Kconfig dependency. See http://bugs.debian.org/344205.

This patch makes Kconfig enforce this dependency.

...

Hi Dann,

thanks for your patch.

A more complete fix is below.

cu
Adrian

<-- snip -->

drivers/net/wireless/airo.c requires CONFIG_CRYPTO for compilations.

Therefore, AIRO and AIRO_CS should select CRYPTO.

Additionally, this patch removes the #ifdef's for the non-compiling CRYPTO=n case from drivers/net/wireless/airo.c.

Bug report by Roland Mas <[email protected]>,
initial patch by dann frazier <[email protected]>.

---

 drivers/net/wireless/Kconfig |    2 +
 drivers/net/wireless/airo.c  |   55 +----------------------------------
 2 files changed, 4 insertions(+), 53 deletions(-)
drivers/net/wireless/Kconfig renamed from drivers/net/wireless/Kconfig.old +2 -0
@@ -244,6 +244,7 @@
 config AIRO
 	tristate "Cisco/Aironet 34X/35X/4500/4800 ISA and PCI cards"
 	depends on NET_RADIO && ISA_DMA_API && (PCI || BROKEN)
+	select CRYPTO
 	---help---
 	  This is the standard Linux driver to support Cisco/Aironet ISA and
 	  PCI 802.11 wireless cards.
@@ -391,6 +392,7 @@
 config AIRO_CS
 	tristate "Cisco/Aironet 34X/35X/4500/4800 PCMCIA cards"
 	depends on NET_RADIO && PCMCIA && (BROKEN || !M32R)
+	select CRYPTO
 	---help---
 	  This is the standard Linux driver to support Cisco/Aironet PCMCIA
 	  802.11 wireless cards.  This driver is the same as the Aironet
drivers/net/wireless/airo.c renamed from drivers/net/wireless/airo.c.old +2 -53

233 lines not on this page · raw message