mm gfp_atomic comments
Subsystems (3)
PATCH v2 1/1 mm gfp_atomic comments
From: Paul Jackson <[email protected]>
Clarify in comments that GFP_ATOMIC means both "don't sleep" and "use emergency pools", hence both ALLOC_HARDER and ALLOC_HIGH.
Signed-off-by Paul Jackson <[email protected]>
---
This is the same patch that Andrew tried sending to Linus on Jan 6, 2006, except that it has been fixed to refer to ALLOC_HARDER and ALLOC_HIGH, instead of the other ALLOC_DIP_* terms that were rejected.
include/linux/gfp.h | 1 + mm/page_alloc.c | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-)
include/linux/gfp.h +1 -0
@@ -57,6 +57,7 @@ struct vm_area_struct; __GFP_NOFAIL|__GFP_NORETRY|__GFP_NO_GROW|__GFP_COMP| \ __GFP_NOMEMALLOC|__GFP_HARDWALL) +/* GFP_ATOMIC means both !wait (__GFP_WAIT not set) and use emergency pool */ #define GFP_ATOMIC (__GFP_HIGH)#define GFP_NOIO (__GFP_WAIT)#define GFP_NOFS (__GFP_WAIT | __GFP_IO)
mm/page_alloc.c +2 -1
@@ -998,7 +998,8 @@ restart:* * The caller may dip into page reserves a bit more if the caller * cannot run direct reclaim, or if the caller has realtime scheduling -* policy. +* policy or is asking for __GFP_HIGH memory. GFP_ATOMIC requests will +* set both ALLOC_HARDER (!wait) and ALLOC_HIGH (__GFP_HIGH). */ alloc_flags =ALLOC_WMARK_MIN ;if ((unlikely (rt_task (p)) && !in_interrupt ()) || !wait)
Signature · 3 lines
I won't rest till it's the best ...
Programmer, Linux Scalability
Paul Jackson <[email protected]> 1.650.933.1373