Skip to contentSkip to conversation

+ add-pselect-ppoll-system-call-implementation-tidy.patch added to -mm tree

DISCUSSION David Woodhouse 2 participants 3 messages Jan 12, 2006 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

Review

Quoted 3 lines · On Wed, 2006-01-11 at 17:05 -0800, [email protected] wrote:
(quoted diff) +2 -1
-                       memcpy(&current->saved_sigmask, &sigsaved, sizeof(sigsaved));
+                       memcpy(&current->saved_sigmask, &sigsaved,
+                                       sizeof(sigsaved));

I often use an editor in an 80x25 terminal to edit code, and I object to this kind of patch because it make the code _harder_ to read on such a terminal.

In 99.9% of cases, you don't _care_ about double-checking precisely what the third argument to that memcpy is. You glance at the line of code and it's obvious what's happening. It's _better_ if it's off the right-hand side of the screen rather than being moved down to take up a line all of its own. You just wasted one more of my precious 25 lines.

The same goes for printks, where I've seen people actually break up strings and move them onto multiple lines. In the common case, we just don't _care_ -- what fits onto the first 80 columns is _enough_.

Please don't make this kind of change.

Signature · 1 line
dwmw2
#2 lore raw
Quoted 3 lines · David Woodhouse

It's _better_ if it's off the right-hand
side of the screen

umm, not all editors do that. Some wrap the text, and it looks like crap.

#3 lore raw
Quoted 2 lines · Andrew Morton

umm, not all editors do that. Some wrap the text, and it looks like crap.

So we go for equal opportunities by making it look like crap for everyone?

Signature · 1 line
dwmw2