Skip to contentSkip to conversation

ethtool: Remove duplex info from CTRL register dump

PATCH Applied Jeff Kirsher 2 participants 2 messages Jan 12, 2006 – Jan 17, 2006

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ethtool: Remove duplex info from CTRL register dump

The duplex control register is used for setting the driver and is not necessary for debug purposes. The value of the duplex control register is what the register's current value is and may not reflect the correct status of te current connection. That is what the duplex status register is used for. To keep from confusing the user, we are removing the duplex register from the ethtool dump of the registers.

---

 e1000.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)
e1000.c +0 -2
index 77d799f..6de27ca 100644
@@ -282,7 +282,6 @@ e1000_dump_regs(struct ethtool_drvinfo *
 	reg = regs_buff[0];
 	fprintf(stdout,
 		"0x00000: CTRL (Device control register)  0x%08X\n"
-		"      Duplex:                            %s\n"
 		"      Endian mode (buffers):             %s\n"
 		"      Link reset:                        %s\n"
 		"      Set link up:                       %s\n"
@@ -291,7 +290,6 @@ e1000_dump_regs(struct ethtool_drvinfo *
 		"      Transmit flow control:             %s\n"
 		"      VLAN mode:                         %s\n",
 		reg,
-		reg & E1000_CTRL_FD     ? "full"     : "half",
 		reg & E1000_CTRL_BEM    ? "big"      : "little",
 		reg & E1000_CTRL_LRST   ? "reset"    : "normal",
 		reg & E1000_CTRL_SLU    ? "1"        : "0",
Applied
#1 lore raw
Quoted 10 lines · Jeff Kirsher

The duplex control register is used for setting the driver and is not necessary for debug purposes. The value of the duplex control register is what the register's current value is and may not reflect the correct status of te current connection. That is what the duplex status register is used for. To keep from confusing the user, we are removing the duplex register from the ethtool dump of the registers.

applied, after replacing "ethtool:" with "e1000:" in the subject line.

Jeff