2.6.15 OOPS while trying to mount cdrom
In-Reply-To: <[email protected]>
Quoted 19 lines · On Tue, 10 Jan 2006 Helge Hafting wrote:
Kernel 2.6.15 amd64, gcc 4.1.0 from debian.
The cdrom (
/dev/hda) is usually fine. I tried booting with hda=ide-scsi in order to read a scratched audio cd with cdparanoia. That way, I at least get error messages when the scratches are too bad.I forgot about hda=ide-scsi, and tried to mount
/dev/hdaas usual in order to read an ordinary iso9660 cd. This is probably not supposed to work when ide-scsi is using the device, but then I expect something like EBUSY rather than this oops:ide-scsi: unsup command: dev hda: flags =
REQ_SORTEDREQ_CMDREQ_STARTEDREQ_ELVPRIV
sector 64, nr/cnr 2/2
bioffff8100044a9b40, biotailffff8100044a9b40, bufferffff81000cb4d000, data 0000000000000000, len 0end_request: I/O error, dev hda, sector 64isofs_fill_super: bread failed, dev=hda, iso_blknum=16, block=32
Quoted 2 lines
Unable to handle kernel NULL pointer dereference at 0000000000000000 RIP:<ffffffff80235a92>{strlen+2}
The IDE driver probably shouldn't have allowed the bdev to be opened in the first place.
After that happened, mount attempted to fill the superblock and the I/O failed. Upon failure, get_sb_bdev() called deactivate_super() (fs/super.c line 718) and all hell broke loose.
- deactivate_super() called fs->kill_sb() (super.c line 176) which pointed to kill_block_super() (fs/isofs/inode.c line 1411)
- kill_block_super() called kobject_uevent() with action KOBJ_UMOUNT (Question: why is it sending UMOUNT for a mount that never happened?)
- kobject_uevent() called kobject_get_path() and one of the objects had a null kobject.name, which caused strlen() to oops.
There seem to be several bugs here:
(1) IDE shouldn't have allowed the bdev to be opened.
(2) (maybe) kobject_uevent shouldn't have been called for an unmount event when the mount never succeeded.
(3) kobject_get_path() shouldn't oops when a path component has a NULL name, or else kobject should fail registration of any such object.
Quoted 1 line
The pc didn't seem to malfunction after this.
If you attempt to mount the CD a second time, mount will hang in D state; ps(1) reports it's at text.lock.super. System cannot be cleanly shut down after that -- shutdown(8) hangs and so does sync(1).
Signature · 2 lines
Chuck Currently reading: _Olympos_ by Dan Simmons
Quoted 56 lines · Chuck Ebbert
In-Reply-To: <[email protected]>
Quoted 12 lines · On Tue, 10 Jan 2006 Helge Hafting wrote:
Kernel 2.6.15 amd64, gcc 4.1.0 from debian.
The cdrom (
/dev/hda) is usually fine. I tried booting with hda=ide-scsi in order to read a scratched audio cd with cdparanoia. That way, I at least get error messages when the scratches are too bad.I forgot about hda=ide-scsi, and tried to mount
/dev/hdaas usual in order to read an ordinary iso9660 cd. This is probably not supposed to work when ide-scsi is using the device, but then I expect something like EBUSY rather than this oops:Quoted 7 lines
ide-scsi: unsup command: dev hda: flags =
REQ_SORTEDREQ_CMDREQ_STARTEDREQ_ELVPRIVsector 64, nr/cnr 2/2 bioffff8100044a9b40, biotailffff8100044a9b40, bufferffff81000cb4d000, data 0000000000000000, len 0end_request: I/O error, dev hda, sector 64isofs_fill_super: bread failed, dev=hda, iso_blknum=16, block=32Unable to handle kernel NULL pointer dereference at 0000000000000000 RIP: <ffffffff80235a92>{strlen+2}The IDE driver probably shouldn't have allowed the bdev to be opened in the first place.
After that happened, mount attempted to fill the superblock and the I/O failed. Upon failure,
get_sb_bdev()calleddeactivate_super()(fs/super.cline 718) and all hell broke loose.-
deactivate_super()calledfs->kill_sb()(super.cline 176) which pointed tokill_block_super()(fs/isofs/inode.cline 1411)-
kill_block_super()calledkobject_uevent()with actionKOBJ_UMOUNT(Question: why is it sending UMOUNT for a mount that never happened?)-
kobject_uevent()calledkobject_get_path()and one of the objects had a null kobject.name, which causedstrlen()to oops.There seem to be several bugs here:
(1) IDE shouldn't have allowed the bdev to be opened.
(2) (maybe)
kobject_ueventshouldn't have been called for an unmount event when the mount never succeeded.(3)
kobject_get_path()shouldn't oops when a path component has a NULL name, or else kobject should fail registration of any such object.
Quoted 9 lines
Quoted 3 lines
The pc didn't seem to malfunction after this.
If you attempt to mount the CD a second time, mount will hang in D state; ps(1) reports it's at text.lock.super. System cannot be cleanly shut down after that -- shutdown(8) hangs and so does sync(1).
Correct - much later I discovered that. "sync" and another "mount" hung in D-state, so I rebooted. I am now running without ide-scsi and have no problem using cd's. :-)
Helge Hafting
Quoted 35 lines · Chuck Ebbert
In-Reply-To: <[email protected]>
Quoted 19 lines · On Tue, 10 Jan 2006 Helge Hafting wrote:
Kernel 2.6.15 amd64, gcc 4.1.0 from debian.
The cdrom (
/dev/hda) is usually fine. I tried booting with hda=ide-scsi in order to read a scratched audio cd with cdparanoia. That way, I at least get error messages when the scratches are too bad.I forgot about hda=ide-scsi, and tried to mount
/dev/hdaas usual in order to read an ordinary iso9660 cd. This is probably not supposed to work when ide-scsi is using the device, but then I expect something like EBUSY rather than this oops:ide-scsi: unsup command: dev hda: flags =
REQ_SORTEDREQ_CMDREQ_STARTEDREQ_ELVPRIV
sector 64, nr/cnr 2/2
bioffff8100044a9b40, biotailffff8100044a9b40, bufferffff81000cb4d000, data 0000000000000000, len 0end_request: I/O error, dev hda, sector 64isofs_fill_super: bread failed, dev=hda, iso_blknum=16, block=32Quoted 2 lines
Unable to handle kernel NULL pointer dereference at 0000000000000000 RIP:<ffffffff80235a92>{strlen+2}
The IDE driver probably shouldn't have allowed the bdev to be opened in the first place.
After that happened, mount attempted to fill the superblock and the I/O failed. Upon failure,
get_sb_bdev()calleddeactivate_super()(fs/super.cline 718) and all hell broke loose.
Quoted 5 lines
-
deactivate_super()calledfs->kill_sb()(super.cline 176) which pointed tokill_block_super()(fs/isofs/inode.cline 1411)-
kill_block_super()calledkobject_uevent()with actionKOBJ_UMOUNT(Question: why is it sending UMOUNT for a mount that never happened?)
Happily, all that code just got deleted:
Also the new poll() interface to /proc/mounts is a nicer way to notify about changes than sending events through the core. The uevents should only be used for driver core related requests to userspace now.
I dunno how this removal works with forward- and backward- compatible
userspace. Maybe it doesn't.
Quoted 7 lines
-
kobject_uevent()calledkobject_get_path()and one of the objects had a null kobject.name, which causedstrlen()to oops.There seem to be several bugs here:
(1) IDE shouldn't have allowed the bdev to be opened.
Maybe. We've got in trouble in the past with making mounts try to get exclusive access. I can't immediately remember what the problem was.
Quoted 2 lines
(2) (maybe)
kobject_ueventshouldn't have been called for an unmount event when the mount never succeeded.
Sounds reasonable.
Quoted 2 lines
(3)
kobject_get_path()shouldn't oops when a path component has a NULL name, or else kobject should fail registration of any such object.
The printk in kobject_register() will oops if kobj->name is null, so yes, it seems reasonable to make kobject_register() fail up-front if there's no
->name. Greg agree?
Helge, it would be good if you could try the same trick on 2.6.15-git9 or -git10, see if it behaves correctly.