Skip to contentSkip to conversation

cg-seek should not complain if run twice

PATCH In review Pavel Roskin 2 participants 4 messages Jun 15, 2016

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 cg-seek should not complain if run twice

cg-seek complains if run without arguments in a non-seeked repository:

rm: cannot remove `.git/refs/heads/cg-seek-point': No such file or directory
rm: cannot remove `.git/head-name': No such file or directory

In fact, it's OK for those files not to exist, so they should be removed silently.

cg-seek +1 -1
index 942267f..8356593 100755
@@ -60,7 +60,7 @@ if [ "$seek_mode" = "away" ]; then
 	git-symbolic-ref HEAD "refs/heads/cg-seek-point"
 else
 	git-symbolic-ref HEAD "refs/heads/$_git_head"
-	rm "$_git/refs/heads/cg-seek-point" "$_git/head-name"
+	rm -f "$_git/refs/heads/cg-seek-point" "$_git/head-name"
 	rm -f "$_git/blocked"
 fi
 
Signature · 2 lines
Regards,
Pavel Roskin
#1 lore raw

Dear diary, on Tue, Dec 20, 2005 at 05:55:36AM CET, I got a letter where Pavel Roskin <[email protected]> said that...

Quoted 9 lines

cg-seek complains if run without arguments in a non-seeked repository:

rm: cannot remove `.git/refs/heads/cg-seek-point': No such file or directory
rm: cannot remove `.git/head-name': No such file or directory

In fact, it's OK for those files not to exist, so they should be removed silently.

It seems cleaner to just make cg-seek fail with a sensible error message if it's already unseeked.

Signature · 5 lines
				Petr "Pasky" Baudis
Stuff: http://pasky.or.cz/
Of the 3 great composers Mozart tells us what it's like to be human,
Beethoven tells us what it's like to be Beethoven and Bach tells us
what it's like to be the universe.  -- Douglas Adams
#2 lore raw

Hello, Petr!

Quoting Petr Baudis <[email protected]>:

Quoted 2 lines

It seems cleaner to just make cg-seek fail with a sensible error message if it's already unseeked.

I don't like this. What if "cvs up -A" would fail if run twice? What if cg-clean would fail if there was nothing to clean? What if sync would fail if it didn't cause a single disk write? Idempotent operations are easier to work with. Please see http://en.wikipedia.org/wiki/Idempotent_(software)

I could make an exception for the case when the command invocation indicates that the user is unaware of something, and that it would endanger the user's data. But it's not the case for cg-seek without arguments on non-seeked repository. The intention is clear, and the knowledge of the current state of the repository doesn't matter, since there will be no merge or something.

--
Regards,
Pavel Roskin

#3 lore raw

Hello,

Dear diary, on Sun, Jan 15, 2006 at 07:03:35AM CET, I got a letter where Pavel Roskin <[email protected]> said that...

Quoted 10 lines

Quoting Petr Baudis <[email protected]>:

Quoted 2 lines

It seems cleaner to just make cg-seek fail with a sensible error message if it's already unseeked.

I don't like this. What if "cvs up -A" would fail if run twice? What if cg-clean would fail if there was nothing to clean? What if sync would fail if it didn't cause a single disk write? Idempotent operations are easier to work with. Please see http://en.wikipedia.org/wiki/Idempotent_(software)

Quoted 5 lines

I could make an exception for the case when the command invocation indicates that the user is unaware of something, and that it would endanger the user's data. But it's not the case for cg-seek without arguments on non-seeked repository. The intention is clear, and the knowledge of the current state of the repository doesn't matter, since there will be no merge or something.

I have my reservations to this argumentation in the specific cg-seek
case, but it's very subjective, unclear, and I personally really don't care. So let it be your way. ;-)

Thanks for your opinion,

Signature · 5 lines
				Petr "Pasky" Baudis
Stuff: http://pasky.or.cz/
Of the 3 great composers Mozart tells us what it's like to be human,
Beethoven tells us what it's like to be Beethoven and Bach tells us
what it's like to be the universe.  -- Douglas Adams