Fall back io scheduler for 2.6.15?
In-Reply-To: <[email protected]>
Quoted 1 line · Andrew Morton
OK. And I assume that AS wasn't compiled, so that's why it fell back?
As of 2.6.15 you need to use "anticipatory" instead of "as".
Maybe this patch would help?
block/elevator.c +7 -0
@@ -150,6 +150,13 @@ static void elevator_setup_default(void)if (!chosen_elevator[0 ])strcpy (chosen_elevator,CONFIG_DEFAULT_IOSCHED ); +/* +* Be backwards-compatible with previous kernels, so users +* won't get the wrong elevator. +*/ +if (!strcmp (chosen_elevator,"as" )) +strcpy (chosen_elevator,"anticipatory" ); +/* * If the given scheduler is not available, fall back to no-op. */
Signature · 2 lines
Chuck Currently reading: _Olympos_ by Dan Simmons
Quoted 18 lines · Chuck Ebbert
In-Reply-To: <[email protected]>
Quoted 1 line · Andrew Morton
OK. And I assume that AS wasn't compiled, so that's why it fell back?
As of 2.6.15 you need to use "anticipatory" instead of "as".
Maybe this patch would help?
Signed-off-by Chuck Ebbert <[email protected]>block/elevator.c +0
-0@@ -150,6 +150,13 @@ static void elevator_setup_default(void)if (!chosen_elevator[0 ])strcpy (chosen_elevator,CONFIG_DEFAULT_IOSCHED );
block/elevator.c static void elevator_setup_default(void) · line 162
Quoted 10 lines
block/elevator.c +7
-0+/* +* Be backwards-compatible with previous kernels, so users +* won't get the wrong elevator. +*/ +if (!strcmp (chosen_elevator,"as" )) +strcpy (chosen_elevator,"anticipatory" ); +/* * If the given scheduler is not available, fall back to no-op. */
We probably should apply this, since it used to be 'as'.
Signature · 1 line
Jens Axboe
Quoted 19 lines · Jens Axboe
Quoted 18 lines · Chuck Ebbert
In-Reply-To: <[email protected]>
Quoted 1 line · Andrew Morton
OK. And I assume that AS wasn't compiled, so that's why it fell back?
As of 2.6.15 you need to use "anticipatory" instead of "as".
Maybe this patch would help?
Signed-off-by Chuck Ebbert <[email protected]>block/elevator.c +0
-0@@ -150,6 +150,13 @@ static void elevator_setup_default(void)if (!chosen_elevator[0 ])strcpy (chosen_elevator,CONFIG_DEFAULT_IOSCHED );
Quoted 12 lines
block/elevator.c static void elevator_setup_default(void) · line 162
Quoted 10 lines
block/elevator.c +7
-0+/* +* Be backwards-compatible with previous kernels, so users +* won't get the wrong elevator. +*/ +if (!strcmp (chosen_elevator,"as" )) +strcpy (chosen_elevator,"anticipatory" ); +/* * If the given scheduler is not available, fall back to no-op. */ We probably should apply this, since it used to be 'as'.
i agree
NATE
Quoted 21 lines · Jens Axboe
Quoted 19 lines · Chuck Ebbert
In-Reply-To: <[email protected]>
Quoted 1 line · Andrew Morton
OK. And I assume that AS wasn't compiled, so that's why it fell back?
As of 2.6.15 you need to use "anticipatory" instead of "as".
Maybe this patch would help?
Signed-off-by Chuck Ebbert <[email protected]>block/elevator.c +0
-0@@ -150,6 +150,13 @@ static void elevator_setup_default(void)if (!chosen_elevator[0 ])strcpy (chosen_elevator,CONFIG_DEFAULT_IOSCHED );
Quoted 14 lines
block/elevator.c static void elevator_setup_default(void) · line 162
Quoted 10 lines
block/elevator.c +7
-0+/* +* Be backwards-compatible with previous kernels, so users +* won't get the wrong elevator. +*/ +if (!strcmp (chosen_elevator,"as" )) +strcpy (chosen_elevator,"anticipatory" ); +/* * If the given scheduler is not available, fall back to no-op. */ We probably should apply this, since it used to be 'as'.
Just out of curiousity, why did 'as' get renamed to 'anticipatory'?
Signature · 1 line
tejun
Quoted 37 lines · Tejun Heo
Quoted 21 lines · Jens Axboe
Quoted 19 lines · Chuck Ebbert
In-Reply-To: <[email protected]>
Quoted 1 line · Andrew Morton
OK. And I assume that AS wasn't compiled, so that's why it fell back?
As of 2.6.15 you need to use "anticipatory" instead of "as".
Maybe this patch would help?
Signed-off-by Chuck Ebbert <[email protected]>block/elevator.c +0
-0@@ -150,6 +150,13 @@ static void elevator_setup_default(void)if (!chosen_elevator[0 ])strcpy (chosen_elevator,CONFIG_DEFAULT_IOSCHED );Quoted 14 lines
block/elevator.c static void elevator_setup_default(void) · line 162
Quoted 10 lines
block/elevator.c +7
-0+/* +* Be backwards-compatible with previous kernels, so users +* won't get the wrong elevator. +*/ +if (!strcmp (chosen_elevator,"as" )) +strcpy (chosen_elevator,"anticipatory" ); +/* * If the given scheduler is not available, fall back to no-op. */ We probably should apply this, since it used to be 'as'.
Quoted 1 line
Just out of curiousity, why did 'as' get renamed to 'anticipatory'?
Side effect really, not intentional. 'as' always registered itself with the elevator core as "anticipatory", the logic to match elevator=foo string to scheduler used to be completely seperate prior to the addition of online switchable elevators. So when those two were tied together, the "as" disappeared. I guess the right thing to do at that time was to rename "anticipatory", but that didn't happen...
Signature · 1 line
Jens Axboe