Skip to contentSkip to conversation

make "struct d_cookie" dependable on CONFIG_PROFILING?

PATCH Marcelo Tosatti 2 participants 2 messages Jan 17, 2006 VFS

lore
Share & tools
lore
#0 lore raw

Hi,

Is there any good reason for not making "struct dcookie_struct *d_cookie" dependable on CONFIG_PROFILING?

Shrinks "struct dentry" from 128 bytes to 124 on x86, allowing 31 objects per slab instead of 30.

John Levon informed me that he had such selection in his original patches, but was asked but take it off (?).

fs/dcache.c renamed from fs/dcache.c.orig +2 -0
@@ -743,7 +743,9 @@ struct dentry *d_alloc(struct dentry * p
 	dentry->d_op = NULL;
 	dentry->d_fsdata = NULL;
 	dentry->d_mounted = 0;
+#ifdef CONFIG_PROFILING
 	dentry->d_cookie = NULL;
+#endif
 	INIT_HLIST_NODE(&dentry->d_hash);
 	INIT_LIST_HEAD(&dentry->d_lru);
 	INIT_LIST_HEAD(&dentry->d_subdirs);
include/linux/dcache.h renamed from include/linux/dcache.h.orig +2 -0
@@ -108,7 +108,9 @@ struct dentry {
 	struct dentry_operations *d_op;
 	struct super_block *d_sb;	/* The root of the dentry tree */
 	void *d_fsdata;			/* fs-specific data */
+#ifdef CONFIG_PROFILING
 	struct dcookie_struct *d_cookie; /* cookie, if any */
+#endif
 	int d_mounted;
 	unsigned char d_iname[DNAME_INLINE_LEN_MIN];	/* small names */
 };
#1 lore raw
Quoted 8 lines · Marcelo Tosatti

Is there any good reason for not making "struct dcookie_struct *d_cookie" dependable on CONFIG_PROFILING?

Shrinks "struct dentry" from 128 bytes to 124 on x86, allowing 31 objects per slab instead of 30.

John Levon informed me that he had such selection in his original patches, but was asked but take it off (?).

iirc this was seen usefull by other tools than profiler but fs/Makefile contains:

obj-$(CONFIG_PROFILING) += dcookies.o

and nobody complained agaisnt it.

Signature · 2 lines
regards,
Philippe Elie