Skip to contentSkip to conversation

sound/pci/cs46xx/dsp_spos_scb_lib.c: fix an assertion

PATCH In review Adrian Bunk 2 participants 3 messages Jan 17, 2006 Sound

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 sound/pci/cs46xx/dsp_spos_scb_lib.c: fix an assertion

D Binderman <[email protected]> reported the following in kernel Bugzilla #5903 [1]:

<-- snip -->

I just tried to compile kernel 2.6.15.1 with the Intel C compiler.

It said

sound/pci/cs46xx/dsp_spos_scb_lib.c(673): warning #187: use of "=" where "==" may have been intended

The source code is

           snd_assert (rate = 48000);

I agree with the compiler. Suggest new code

           snd_assert (rate == 48000);

<-- snip -->

Thankfully this bug would only become visible if the assertion was false, but anyways it's a bug.

[1] http://bugzilla.kernel.org/show_bug.cgi?id=5903

sound/pci/cs46xx/dsp_spos_scb_lib.c renamed from sound/pci/cs46xx/dsp_spos_scb_lib.c.old +1 -1
@@ -677,7 +677,7 @@
 		if (pass_through) {
 			/* wont work with any other rate than
 			   the native DSP rate */
-			snd_assert (rate = 48000);
+			snd_assert (rate == 48000);
 
 			scb = cs46xx_dsp_create_generic_scb(chip,scb_name,(u32 *)&src_task_scb,
 							    dest,"DMAREADER",parent_scb,
#1 lore raw
Quoted 2 lines · Adrian Bunk

D Binderman <[email protected]> reported the following in kernel Bugzilla #5903 [1]:

Already fixed in CVS

-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files for problems? Stop! Download the new AJAX search engine that makes searching your log files as easy as surfing the web. DOWNLOAD SPLUNK!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=103432&bid=230486&dat=121642