Skip to contentSkip to conversation

compact print_symbol() output

PATCH Chuck Ebbert 3 participants 3 messages Jan 18, 2006

lore
Share & tools
lore
#0 lore raw

In-Reply-To: <[email protected]>

Quoted 11 lines · Andi Kleen
Quoted 8 lines · Hugh Dickins

I've often found symbolsize useful. Not when looking at an oops from my own machine. But when looking at an oops posted on LKML, from someone who most likely has a different .config and different compiler, different optimization and different inlining from mine. symbolsize is a good clue as to how close their kernel is to the one I've got built on my machine, how likely guesses I make based on mine will apply to theirs, and whereabouts in the function that it oopsed.

Quoted 1 line

Yes that is why I want it too.

OK, how about this: remove the "0x" from the function size, i.e. print:

        kernel_symbol+0xd3/10e

instead of:

        kernel_symbol+0xd3/0x10e

This saves two characters per symbol and it should still be clear that the second number is hexadecimal.

Does that break any tools?

Signature · 1 line
Chuck
#1 lore raw
Quoted 21 lines · Chuck Ebbert (on Tue, 17 Jan 2006 22:05:27 -0500) wrote:

In-Reply-To: <[email protected]>

Quoted 11 lines · Andi Kleen
Quoted 8 lines · Hugh Dickins

I've often found symbolsize useful. Not when looking at an oops from my own machine. But when looking at an oops posted on LKML, from someone who most likely has a different .config and different compiler, different optimization and different inlining from mine. symbolsize is a good clue as to how close their kernel is to the one I've got built on my machine, how likely guesses I make based on mine will apply to theirs, and whereabouts in the function that it oopsed.

Quoted 1 line

Yes that is why I want it too.

OK, how about this: remove the "0x" from the function size, i.e. print:

       kernel_symbol+0xd3/10e
Quoted 8 lines

instead of:

       kernel_symbol+0xd3/0x10e

This saves two characters per symbol and it should still be clear that the second number is hexadecimal.

Does that break any tools?

Not, just CONFUSE-A-HUMAN (incorporating AMAZE-A-VOLE LTD, STUN-A-STOAT LTD, PUZZLE-A-PUMA LTD, STARTLE-A-THOMPSON'S GAZELLE LTD, BEWILDEREBEEST INC, DISTRACT-A-BEE). Yes, I need a life.

#2 lore raw
In reply to Chuck Ebbert
Quoted 10 lines · Chuck Ebbert

OK, how about this: remove the "0x" from the function size, i.e. print:

        kernel_symbol+0xd3/10e

instead of:

        kernel_symbol+0xd3/0x10e

This saves two characters per symbol and it should still be clear that the second number is hexadecimal.

Good. Now repeat for a function that's 6 bytes shorter.