Skip to contentSkip to conversation

CONFIG_DOUBLEFAULT Kconfig fix

PATCH In review Ingo Molnar 3 participants 3 messages Jan 20, 2006

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 CONFIG_DOUBLEFAULT Kconfig fix

move CONFIG_DOUBLEFAULT from the main Kconfig menu (!) into its proper
place: the "Processor Type and features" submenu.

----

 arch/i386/Kconfig |   19 ++++++++++---------
 1 files changed, 10 insertions(+), 9 deletions(-)
arch/i386/Kconfig +9 -9
Index: linux/arch/i386/Kconfig
===================================================================
@@ -55,15 +55,6 @@ config DMI
 
 source "init/Kconfig"
 
-config DOUBLEFAULT
-	default y
-	bool "Enable doublefault exception handler" if EMBEDDED
-	help
-          This option allows trapping of rare doublefault exceptions that
-          would otherwise cause a system to silently reboot. Disabling this
-          option saves about 4k and might cause you much additional grey
-          hair.
-
 menu "Processor type and features"
 
 choice
@@ -761,6 +752,15 @@ config HOTPLUG_CPU
 
 	  Say N.
 
+config DOUBLEFAULT
+	default y
+	bool "Enable doublefault exception handler" if EMBEDDED
+	help
+          This option allows trapping of rare doublefault exceptions that
+          would otherwise cause a system to silently reboot. Disabling this
+          option saves about 4k and might cause you much additional grey
+          hair.
+
 endmenu
 
 
#1 lore raw
Quoted 2 lines · Ingo Molnar

move CONFIG_DOUBLEFAULT from the main Kconfig menu (!) into its proper
place: the "Processor Type and features" submenu.

Hmm. Should have originally shown up under the CONFIG_EMBEDDED menu, I guess Andrew moved it.

I'd kind of like to keep it in the embedded features menu, so that it's clear that disabling it is a non-standard thing to do. But I don't have a strong feeling about it.

Signature · 1 line
Mathematics is the supreme nostalgia of our time.
#2 lore raw
Quoted 7 lines · Matt Mackall
Quoted 2 lines · Ingo Molnar

move CONFIG_DOUBLEFAULT from the main Kconfig menu (!) into its proper
place: the "Processor Type and features" submenu.

Hmm. Should have originally shown up under the CONFIG_EMBEDDED menu, I guess Andrew moved it.

patch(1) decided to put it somewhere else. That's happened a few times with Kconfig files.