fs/coda/: proper prototypes
PATCH 1/1 fs/coda/: proper prototypes
This patch introduces a file fs/coda/coda_int.h with proper prototypes for some code.
Signed-off-by Adrian Bunk <[email protected]>
---
fs/coda/coda_int.h | 13 +++++++++++++ fs/coda/dir.c | 3 ++- fs/coda/file.c | 2 ++ fs/coda/inode.c | 2 ++ fs/coda/psdev.c | 9 ++------- 5 files changed, 21 insertions(+), 8 deletions(-)
fs/coda/coda_int.h new file +13 -0
@@ -0,0 +1,13 @@ +#ifndef _CODA_INT_ +#define _CODA_INT_ + +extern struct file_system_type coda_fs_type; + +void coda_destroy_inodecache (void ); +int coda_init_inodecache (void ); +int coda_fsync (struct file *coda_file,struct dentry *coda_dentry, +int datasync); + +#endif /* _CODA_INT_ */ + +
fs/coda/file.c renamed from fs/coda/file.c.old +2 -0
@@ -24,6 +24,8 @@#include <linux/coda_psdev.h> #include <linux/coda_proc.h> +#include "coda_int.h" +/* if CODA_STORE fails with EOPNOTSUPP, venus clearly doesn't support * CODA_STORE/CODA_RELEASE and we fall back on using the CODA_CLOSE upcall */ static int use_coda_close;
fs/coda/dir.c renamed from fs/coda/dir.c.old +2 -1
@@ -27,6 +27,8 @@#include <linux/coda_cache.h> #include <linux/coda_proc.h> +#include "coda_int.h" +/* dir inode-ops */ static int coda_create (struct inode *dir,struct dentry *new,int mode,struct nameidata *nd);static struct dentry *coda_lookup (struct inode *dir,struct dentry *target,struct nameidata *nd);
@@ -50,7 +52,6 @@/* support routines */ static int coda_venus_readdir (struct file *filp,filldir_t filldir,void *dirent,struct dentry *dir); -int coda_fsync (struct file *,struct dentry *dentry,int datasync);/* same as fs/bad_inode.c */ static int coda_return_EIO (void )
fs/coda/inode.c renamed from fs/coda/inode.c.old +2 -0
@@ -31,6 +31,8 @@#include <linux/coda_fs_i.h> #include <linux/coda_cache.h> +#include "coda_int.h" +/* VFS super_block ops */ static void coda_clear_inode (struct inode *);static void coda_put_super (struct super_block *);
fs/coda/psdev.c renamed from fs/coda/psdev.c.old +2 -7
@@ -48,12 +48,9 @@#include <linux/coda_psdev.h> #include <linux/coda_proc.h> -#define upc_free (r) kfree(r) +#include "coda_int.h" -/* -* Coda stuff -*/ -extern struct file_system_type coda_fs_type; +#define upc_free (r) kfree(r)/* statistics */ int coda_hard;/* allows signals during upcalls */
@@ -394,8 +391,6 @@MODULE_AUTHOR ("Peter J. Braam <[email protected]>" );MODULE_LICENSE ("GPL" ); -extern int coda_init_inodecache (void ); -extern void coda_destroy_inodecache (void );static int __init init_coda (void ) {int status;
Quoted 5 lines · Adrian Bunk
This patch introduces a file
fs/coda/coda_int.hwith proper prototypes for some code.Signed-off-by Adrian Bunk <[email protected]>
Acked-by Jan Harkes <[email protected]>
Looks good. Is this going to be included in your cleanup patch series, or do you want me to forward it?
Jan
Quoted 10 lines · Jan Harkes
Quoted 5 lines · Adrian Bunk
This patch introduces a file
fs/coda/coda_int.hwith proper prototypes for some code.Signed-off-by Adrian Bunk <[email protected]>Acked-by Jan Harkes <[email protected]>Looks good. Is this going to be included in your cleanup patch series, or do you want me to forward it?
If you want you can forward it yourself.
Otherwise, I'll submit it through Andrew noting that it's maintainer-approved.
Quoted 1 line
Jan
cu
Adrian
Signature · 4 lines
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed