Skip to contentSkip to conversation

Guillemot joystick not working since 2.6.14

PATCH Applied Marek Vašut 3 participants 5 messages Jan 22, 2006 – Jan 25, 2006 Input drivers

lore
Share & tools
lore
#0 lore raw

Hi,
I found a problem with guillemot "force feedback joystick". It´s not working since 2.6.13.2-mm3. 2.6.14.2 wasn´t working too. 2.6.15-mm2 is the same. When I plug it in, it prints "configuration #1 chosen from 1 choice" "registered new driver iforce" and >"iforce: probe of 4-2:1.0 failed with error -12"< It was working well on 2.6.13.1, but now it doesnt. I am not able to debug the kernel. Could you please fix this or tell me what am I doing wrong? Thanks.

Marex

#1 lore raw
Quoted 6 lines · Marek Va?ut

I found a problem with guillemot "force feedback joystick". It?s not working since 2.6.13.2-mm3. 2.6.14.2 wasn?t working too. 2.6.15-mm2 is the same. When I plug it in, it prints "configuration #1 chosen from 1 choice" "registered new driver iforce" and >"iforce: probe of 4-2:1.0 failed with error -12"< It was working well on 2.6.13.1, but now it doesnt. I am not able to debug the kernel. Could you please fix this or tell me what am I doing wrong? Thanks.

Please try this patch

drivers/input/joystick/iforce/iforce-main.c +1 -1
@@ -345,7 +345,7 @@ int iforce_init_device(struct iforce *if
 	int i;
 
 	input_dev = input_allocate_device();
-	if (input_dev)
+	if (!input_dev)
 		return -ENOMEM;
 
 	init_waitqueue_head(&iforce->wait);
#2 lore raw
Quoted 14 lines · Alexey Dobriyan
Quoted 6 lines · Marek Va?ut

I found a problem with guillemot "force feedback joystick". It?s not working since 2.6.13.2-mm3. 2.6.14.2 wasn?t working too. 2.6.15-mm2 is the same. When I plug it in, it prints "configuration #1 chosen from 1 choice" "registered new driver iforce" and >"iforce: probe of 4-2:1.0 failed with error -12"< It was working well on 2.6.13.1, but now it doesnt. I am not able to debug the kernel. Could you please fix this or tell me what am I doing wrong? Thanks.

Please try this patch

drivers/input/joystick/iforce/iforce-main.c int iforce_init_device(struct iforce *if · line 351

Quoted 8 lines
drivers/input/joystick/iforce/iforce-main.c +1 -1
@@ -345,7 +345,7 @@ int iforce_init_device(struct iforce *if
 	int i;
 
 	input_dev = input_allocate_device();
-	if (input_dev)
+	if (!input_dev)
 		return -ENOMEM;
 
 	init_waitqueue_head(&iforce->wait);

Doh! Could you please add your signoff so I'd add it to the input tree?

Anyway, dynalloc went in 2.6.15 so something else is amiss...

Signature · 1 line
Dmitry
#3 lore raw

PATCH 1/1 iforce: fix -ENOMEM check

---

 drivers/input/joystick/iforce/iforce-main.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/input/joystick/iforce/iforce-main.c +1 -1
@@ -345,7 +345,7 @@ int iforce_init_device(struct iforce *if
 	int i;
 
 	input_dev = input_allocate_device();
-	if (input_dev)
+	if (!input_dev)
 		return -ENOMEM;
 
 	init_waitqueue_head(&iforce->wait);
#4 lore raw

Re: [PATCH] iforce: fix -ENOMEM check

Quoted 11 lines · Alexey Dobriyan

---

 drivers/input/joystick/iforce/iforce-main.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

drivers/input/joystick/iforce/iforce-main.c int iforce_init_device(struct iforce *if · line 351

Quoted 8 lines
drivers/input/joystick/iforce/iforce-main.c +1 -1
@@ -345,7 +345,7 @@ int iforce_init_device(struct iforce *if
 	int i;
 
 	input_dev = input_allocate_device();
-	if (input_dev)
+	if (!input_dev)
 		return -ENOMEM;
 
 	init_waitqueue_head(&iforce->wait);

Applied to the input tree, thank you.

Signature · 1 line
Dmitry