Skip to contentSkip to conversation

enable XFS write barrier

PATCH In review Tetsuo Takata 2 participants 2 messages Jan 23, 2006 Block layer

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 enable XFS write barrier

I found out that the q->ordered is not being set properly on XFS.

I'm testing the write barrier support of XFS.
I run the test on kernel 2.6.16-rc1-git4.
but I found out that the "-o barrier" option is automatically disabled in my environment.
For this reason I could not test the write barrier's execution path.

The error message in "/var/log/messages" is:
Filesystem "sdb1": Disabling barriers, not supported by the underlying device

This patch fixes these bugs.

Best regards,

Tetsuo Takata

The patch below fixes the aforementioned problem.

---

block/ll_rw_blk.c +1 -0
diff -urpN linux-2.6.16-rc1-git4/block/ll_rw_blk.c linux-2.6.16-rc1-git4-fixed/block/ll_rw_blk.c
@@ -332,6 +332,7 @@ int blk_queue_ordered(request_queue_t *q
 		return -EINVAL;
 	}
 
+	q->ordered = ordered;
 	q->next_ordered = ordered;
 	q->prepare_flush_fn = prepare_flush_fn;
 
#1 lore raw
Quoted 9 lines · Tetsuo Takata

I found out that the q->ordered is not being set properly on XFS.

I'm testing the write barrier support of XFS.
I run the test on kernel 2.6.16-rc1-git4.
but I found out that the "-o barrier" option is automatically disabled in my environment.
For this reason I could not test the write barrier's execution path.

Quoted 5 lines

The error message in "/var/log/messages" is:
Filesystem "sdb1": Disabling barriers, not supported by the underlying device

This patch fixes these bugs.

Woops, thanks!

Signature · 1 line
Jens Axboe