Skip to contentSkip to conversation

libata docs patches merged

PATCH New Randy.Dunlap 1 participant 1 message Jan 28, 2006

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 libata docs patches merged

This is a merger of libata docs + cleanups from Martin Waitz <[email protected]> and me.

From: Randy Dunlap <[email protected]>
From: Martin Waitz <[email protected]>

Fix libata kernel-doc comments to match code. Add some function parameters to kernel-doc. Fix some typos/spellos.
Put comments in <= 80 columns.
Make one DPRINTK string unique.
Fix sparse cast warnings.

---
 drivers/scsi/ata_piix.c    |    1 
 drivers/scsi/libata-core.c |   60 ++++++++++++++++++++++-----------------------
 drivers/scsi/libata-scsi.c |    9 +++---
 3 files changed, 36 insertions(+), 34 deletions(-)
drivers/scsi/ata_piix.c +1 -0
@@ -627,6 +627,7 @@ static int piix_disable_ahci(struct pci_
 
 /**
  *	piix_check_450nx_errata	-	Check for problem 450NX setup
+ *	@ata_dev: the PCI device to check
  *	
  *	Check for the present of 450NX errata #19 and errata #25. If
  *	they are found return an error code so we can turn off DMA
drivers/scsi/libata-scsi.c +5 -4
@@ -151,7 +151,7 @@ int ata_cmd_ioctl(struct scsi_device *sc
 	struct scsi_sense_hdr sshdr;
 	enum dma_data_direction data_dir;
 
-	if (NULL == (void *)arg)
+	if (arg == NULL)
 		return -EINVAL;
 
 	if (copy_from_user(args, arg, sizeof(args)))
@@ -201,7 +201,7 @@ int ata_cmd_ioctl(struct scsi_device *sc
 	/* Need code to retrieve data from check condition? */
 
 	if ((argbuf)
-	 && copy_to_user((void *)(arg + sizeof(args)), argbuf, argsize))
+	 && copy_to_user(arg + sizeof(args), argbuf, argsize))
 		rc = -EFAULT;
 error:
 	if (argbuf)
@@ -228,7 +228,7 @@ int ata_task_ioctl(struct scsi_device *s
 	u8 args[7];
 	struct scsi_sense_hdr sshdr;
 
-	if (NULL == (void *)arg)
+	if (arg == NULL)
 		return -EINVAL;
 
 	if (copy_from_user(args, arg, sizeof(args)))
@@ -2492,7 +2492,8 @@ out_unlock:
 
 /**
  *	ata_scsi_simulate - simulate SCSI command on ATA device
- *	@id: current IDENTIFY data for target device.
+ *	@ap: port the device is connected to
+ *	@dev: the target device
  *	@cmd: SCSI command being sent to device.
  *	@done: SCSI command completion function.
  *
drivers/scsi/libata-core.c +30 -30

143 lines not on this page · raw message

---