Skip to contentSkip to conversation

kcalloc(): INT_MAX -> ULONG_MAX

RFC PATCH New Adrian Bunk 1 participant 1 message Jan 28, 2006 Slab allocator

lore
Share & tools
lore
#0 lore raw

RFC PATCH 1/1 kcalloc(): INT_MAX -> ULONG_MAX

Since size_t has the same size as a long on all architectures, it's enough for overflow checks to check against ULONG_MAX.

This change could allow a compiler better optimization (especially in the n=1 case).

The practical effect seems to be positive, but quite small:

text data bss dec hex filename

21762380        5859870 1848928 29471178        1c1b1ca vmlinux-old
21762211        5859870 1848928 29471009        1c1b121 vmlinux-patched

---

This patch was already sent on:
- 20 Aug 2005

include/linux/slab.h renamed from include/linux/slab.h.old +1 -1
@@ -113,7 +113,7 @@
  */
 static inline void *kcalloc(size_t n, size_t size, unsigned int __nocast flags)
 {
-	if (n != 0 && size > INT_MAX / n)
+	if (n != 0 && size > ULONG_MAX / n)
 		return NULL;
 	return kzalloc(n * size, flags);
 }