Skip to contentSkip to conversation

ieee1394: allow building with absolute SUBDIRS path

PATCH Applied Johannes Berg 3 participants 7 messages Jan 26, 2006 – Feb 4, 2006 1 message not in the archive

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ieee1394: allow building with absolute SUBDIRS path

This patch allows building the modules with an absolute SUBDIRS path, especially for building them out of tree.

drivers/ieee1394/Makefile +1 -1
@@ -18,7 +19,7 @@ obj-$(CONFIG_IEEE1394_AMDTP) += amdtp.o
 obj-$(CONFIG_IEEE1394_CMP) += cmp.o
 
 quiet_cmd_oui2c = OUI2C   $@
-      cmd_oui2c = $(CONFIG_SHELL) $(srctree)/$(src)/oui2c.sh < $< > $@
+      cmd_oui2c = $(CONFIG_SHELL) $(src)/oui2c.sh < $< > $@
 
 targets := oui.c
 $(obj)/oui.o: $(obj)/oui.c
#1 lore raw
Quoted 9 lines · Johannes Berg

This patch allows building the modules with an absolute SUBDIRS path, especially for building them out of tree.

drivers/ieee1394/Makefile obj-$(CONFIG_IEEE1394_AMDTP) += amdtp.o · line 25

Quoted 8 lines
drivers/ieee1394/Makefile +1 -1
@@ -18,7 +19,7 @@ obj-$(CONFIG_IEEE1394_AMDTP) += amdtp.o
 obj-$(CONFIG_IEEE1394_CMP) += cmp.o
 
 quiet_cmd_oui2c = OUI2C   $@
-      cmd_oui2c = $(CONFIG_SHELL) $(srctree)/$(src)/oui2c.sh < $< > $@
+      cmd_oui2c = $(CONFIG_SHELL) $(src)/oui2c.sh < $< > $@
 
 targets := oui.c
 $(obj)/oui.o: $(obj)/oui.c

Looks good, although you should rediff against current sources and post at linux1394-devel. :-)

If you want to develop on top of latest 1394 sources but with a released kernel underneath, you could check out my quilt trees.
http://me.in-berlin.de/~s5r6/linux1394/updates/

Signature · 3 lines
Stefan Richter
-=====-=-==- ---= ==-=-
http://arcgraph.de/sr/
#2 lore raw
Quoted 3 lines

Looks good, although you should rediff against current sources and post at linux1394-devel. :-)

Right.

Quoted 3 lines

If you want to develop on top of latest 1394 sources but with a released kernel underneath, you could check out my quilt trees.
http://me.in-berlin.de/~s5r6/linux1394/updates/

Thanks, will take a look.

johannes

#3 lore raw
In reply to Johannes Berg
Quoted 2 lines · Johannes Berg

This patch allows building the modules with an absolute SUBDIRS path, especially for building them out of tree.

Applied, thanks.

Does anyone else feel like killing oui.c?

Quoted 1 line

Minor nit: This should be Signed-off-by:

I doubt anyone cares :)

Cheers,
Jody

Quoted 13 lines
drivers/ieee1394/Makefile +1 -1
@@ -18,7 +19,7 @@ obj-$(CONFIG_IEEE1394_AMDTP) += amdtp.o
 obj-$(CONFIG_IEEE1394_CMP) += cmp.o
 
 quiet_cmd_oui2c = OUI2C   $@
-      cmd_oui2c = $(CONFIG_SHELL) $(srctree)/$(src)/oui2c.sh < $< > $@
+      cmd_oui2c = $(CONFIG_SHELL) $(src)/oui2c.sh < $< > $@
 
 targets := oui.c
 $(obj)/oui.o: $(obj)/oui.c
#4 lore raw

ieee1394/oui.db (was Re: [PATCH] ieee1394: allow building with absolute SUBDIRS path)

Quoted 1 line · Jody McIntyre

Does anyone else feel like killing oui.c?

I have no strong feelings for or against oui.db. It is nice to have the vendor names decoded in sysfs, although the footprint is considerable:

$ du oui.o ieee1394.ko
252K    oui.o
356K    ieee1394.ko

OTOH, nobody is forced to compile it in. And except for the Makefile patch and .gitignore patch which came in this month, oui.db does not impose a real maintenance burden. The fact that we are too lazy to update the db saves us work too. :-)

BTW, oui.db has 7048 entries but IEEE lists 8949 today. Either people vote oui.db off the island now, or I will submit an update.

Signature · 3 lines
Stefan Richter
-=====-=-==- ---= =====
http://arcgraph.de/sr/
#5 lore raw

Re: ieee1394/oui.db (was Re: [PATCH] ieee1394: allow building with absolute SUBDIRS path)

Quoted 3 lines · Stefan Richter

I have no strong feelings for or against oui.db. It is nice to have the vendor names decoded in sysfs, although the footprint is considerable:

I guess it's nice (I've never compiled it in until a few days ago mind you) but this type of thing is userland's job. I've been meaning to write a good ls1394 for some time now. I have one that's too crappy to release :)

Quoted 8 lines
$ du oui.o ieee1394.ko
252K    oui.o
356K    ieee1394.ko

OTOH, nobody is forced to compile it in. And except for the Makefile patch and .gitignore patch which came in this month, oui.db does not impose a real maintenance burden. The fact that we are too lazy to update the db saves us work too. :-)

No, it doesn't, but its existance offends me :)

I don't care deeply though. If people want it, I'll live with it being in.

Cheers,
Jody

Quoted 11 lines

BTW, oui.db has 7048 entries but IEEE lists 8949 today. Either people vote oui.db off the island now, or I will submit an update.

Signature · 8 lines
Stefan Richter
-=====-=-==- ---= =====
http://arcgraph.de/sr/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

A message that is not in the archive (sent off-list or not yet received): 1138739715.4456.302.camel@grayson

#7 lore raw

Re: ieee1394/oui.db (was Re: [PATCH] ieee1394: allow building with absolute SUBDIRS path)

Ben Collins wrote on 2006-01-31:

Quoted 10 lines · Stefan Richter
Quoted 9 lines
Quoted 1 line · Jody McIntyre

Does anyone else feel like killing oui.c?

I have no strong feelings for or against oui.db. It is nice to have the vendor names decoded in sysfs, although the footprint is considerable:

$ du oui.o ieee1394.ko
252K    oui.o
356K    ieee1394.ko
Quoted 7 lines
Quoted 3 lines

OTOH, nobody is forced to compile it in. And except for the Makefile patch and .gitignore patch which came in this month, oui.db does not impose a real maintenance burden. The fact that we are too lazy to update the db saves us work too. :-)

BTW, oui.db has 7048 entries but IEEE lists 8949 today. Either people vote oui.db off the island now, or I will submit an update.

I vote update it. I really think something like OUI needs to be part of the kernel lib/ though. Lots of things, like ethernet and bluetooth can use it. No one really does though.

Yes, drivers/ieee1394/ is the wrong place for oui.db. In case oui.db was not killed by then, I will submit patches to move oui.db to lib/ later this month.

Signature · 3 lines
Stefan Richter
-=====-=-==- --=- --=--
http://arcgraph.de/sr/