Skip to contentSkip to conversation

sysctl initialization of zone_reclaim_mode

PATCH In review Stephen Hemminger 3 participants 3 messages Feb 1, 2006 Proc sysctl

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 sysctl initialization of zone_reclaim_mode

Fix warning about initialization of sysctl table in current 2.6.16-rc1 git tree. It could cause a nasty if anyone wrote to it.

kernel/sysctl.c +2 -1
@@ -878,7 +878,8 @@ static ctl_table vm_table[] = {
 		.maxlen		= sizeof(zone_reclaim_mode),
 		.mode		= 0644,
 		.proc_handler	= &proc_dointvec,
-		.strategy	= &zero,
+		.strategy	= &sysctl_intvec,
+		.extra1		= &zero,
 	},
 #endif
 	{ .ctl_name = 0 }
#1 lore raw
Quoted 3 lines · Stephen Hemminger

Fix warning about initialization of sysctl table in current 2.6.16-rc1 git tree. It could cause a nasty if anyone wrote to it.

Already fixed in the current tree by Christoph Lameter,

Linus

#2 lore raw
In reply to Stephen Hemminger

A cleanup patch has been in Andrews tree for awhile and I hope that Linus applies it today. This is the ., hmm .... 4th time the patch was posted.

Quoted 23 lines · Stephen Hemminger

Fix warning about initialization of sysctl table in current 2.6.16-rc1 git tree. It could cause a nasty if anyone wrote to it.

kernel/sysctl.c +2 -2
@@ -878,7 +878,8 @@ static ctl_table vm_table[] = {
 		.maxlen		= sizeof(zone_reclaim_mode),
 		.mode		= 0644,
 		.proc_handler	= &proc_dointvec,
-		.strategy	= &zero,
+		.strategy	= &sysctl_intvec,
+		.extra1		= &zero,
 	},
 #endif
 	{ .ctl_name = 0 }
-

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/