Skip to contentSkip to conversation

AMD64: fix mce_cpu_quirks typos

PATCH In review Florian Weimer 2 participants 3 messages Feb 1, 2006

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 AMD64: fix mce_cpu_quirks typos

The spurious MCE is TLB-related. I *think* the bit for the correct status code is stored at position 10 HEX, not 10 DEC. At least I still get those MCEs on a two-way Opteron box, even though they are supposed to be filtered out.

---

 arch/x86_64/kernel/mce.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

102dfead12550ecaf7363a8ca7269ac0f1241bac

arch/x86_64/kernel/mce.c +2 -2
index 13a2ead..975d128 100644
@@ -350,9 +350,9 @@ static void __cpuinit mce_cpu_quirks(str
 { 
 	/* This should be disabled by the BIOS, but isn't always */
 	if (c->x86_vendor == X86_VENDOR_AMD && c->x86 == 15) {
-		/* disable GART TBL walk error reporting, which trips off 
+		/* disable GART TLB walk error reporting, which trips off
 		   incorrectly with the IOMMU & 3ware & Cerberus. */
-		clear_bit(10, &bank[4]);
+		clear_bit(0x10, &bank[4]);
 		/* Lots of broken BIOS around that don't clear them
 		   by default and leave crap in there. Don't log. */
 		mce_bootlog = 0;
Signature · 1 line
1.1.5
#1 lore raw
Quoted 2 lines · Florian Weimer

The spurious MCE is TLB-related. I *think* the bit for the correct status code is stored at position 10 HEX, not 10 DEC

not true. According to the BIOS writer guide, it's bit 10.
The register only defines bits up to bit 12

Your patch makes it poke a reserved part of the register, which is definitly undesired.

Dave

#2 lore raw

* Dave Jones:

Quoted 6 lines · Florian Weimer
Quoted 2 lines

The spurious MCE is TLB-related. I *think* the bit for the correct status code is stored at position 10 HEX, not 10 DEC

not true. According to the BIOS writer guide, it's bit 10.
The register only defines bits up to bit 12

Okay, so why I'm still getting these MCEs?

MCE 0
CPU 0 4 northbridge TSC 91ec03f09330
ADDR 104500000
Northbridge GART error
bit61 = error uncorrected
TLB error 'generic transaction, level generic'
STATUS a40000000005001b MCGSTATUS 0

They are supposed to be disabled by the quirks routine, aren't they?