Skip to contentSkip to conversation

__cmpxchg() must really always be inlined on alpha

PATCH New Steve Langasek 1 participant 1 message Feb 2, 2006 Alpha port

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 __cmpxchg() must really always be inlined on alpha

Hi folks,

With the latest 2.6.15 kernel builds for alpha on Debian, we ran into a problem with undefined references to __cmpxchg_called_with_bad_pointer() in a couple of kernel modules (xfs.ko and drm.ko; see
http://bugs.debian.org/347556). It looks like people have been trying to out-clever each other wrt the definition of "inline" on this architecture :), with the result that __cmpxchg(), which must be inlined so the compiler can see its argument is const, is not guaranteed to be inlined. Indeed, it was not being inlined when building with -Os.

I was asked to forward the attached patch to these two lists, which fixes the issue by adding an __attribute__((always_inline)) explicitly to the definition of __cmpxchg() instead of relying on redefines of "inline" elsewhere to make this happen. Please let me know if I should be submitting the patch in a different format.

Thanks,

Signature · 3 lines
Steve Langasek                   Give me a lever long enough and a Free OS
Debian Developer                   to set it on, and I can move the world.
[email protected]                                   http://www.debian.org/
include/asm-alpha/system.h renamed from include/asm-alpha/system.h.orig +1 -1
@@ -562,7 +562,7 @@
    if something tries to do an invalid cmpxchg().  */
 extern void __cmpxchg_called_with_bad_pointer(void);
 
-static inline unsigned long
+static inline __attribute__((always_inline)) unsigned long
 __cmpxchg(volatile void *ptr, unsigned long old, unsigned long new, int size)
 {
 	switch (size) {