hwmon: Support for Pentium M VRM
PATCH 1/1 hwmon: Support for Pentium M VRM
Hi all,
The following patch adds support for the Intel Pentium M series to the hwmon-vid driver.
Rudolf, does it look OK to you?
Thanks.
Add support for the Intel Pentium M series to the hwmon-vid driver.
--- drivers/hwmon/hwmon-vid.c | 7 +++++++ 1 file changed, 7 insertions(+)
drivers/hwmon/hwmon-vid.c +7 -0
@@ -54,6 +54,10 @@(IMVP-II). You can find more information in the datasheet of Max1718 http://www.maxim-ic.com/quick_view2.cfm/qv_pk/2452 +The 13 specification corresponds to the Intel Pentium M series. There +doesn't seem to be any named specification for these. The conversion +tables are detailed directly in the various Pentium M datasheets: +http://www.intel.com/design/intarch/pentiumm/docs_pentiumm.htm */ /* vrm is the VRM/VRD document version multiplied by 10.
@@ -100,6 +104,8 @@case 17 :/* Intel IMVP-II */ return (val &0x10 ?975 - (val &0xF ) *25 :1750 - val *50 ); +case 13 : +return (1708 - (val &0x3f ) *16 );default :/* report 0 for unknown */ printk (KERN_INFO "hwmon-vid: requested unknown VRM version\n" );return 0 ;
@@ -131,6 +137,7 @@ {X86_VENDOR_AMD, 0xF, ANY, ANY, 24}, /* Athlon 64, Opteron and above VRM 24 */ {X86_VENDOR_INTEL, 0x6, 0x9, ANY, 85}, /* 0.13um too */ {X86_VENDOR_INTEL, 0x6, 0xB, ANY, 85}, /* Tualatin */ + {X86_VENDOR_INTEL, 0x6, 0xD, ANY, 13}, /* Pentium M */ {X86_VENDOR_INTEL, 0x6, ANY, ANY, 82}, /* any P6 */ {X86_VENDOR_INTEL, 0x7, ANY, ANY, 0}, /* Itanium */ {X86_VENDOR_INTEL, 0xF, 0x0, ANY, 90}, /* P4 */
Signature · 1 line
Jean Delvare
PATCH 1/1 hwmon: Support for Pentium M VRM (v.2)
Hi all,
Quoting myself:
Quoted 2 lines
The following patch adds support for the Intel Pentium M series to the hwmon-vid driver.
Looks like 130 nm Pentium M series have a product id of 9 (product ID of 13 is for the 90 nm series), and need the new VRM conversion too. For some reason our code used to attribute VRM 8.5 to product ID 9 but I was probably not correct, as none of the Intel document I could read would back up that decision.
So, here comes an updated patch.
Thanks.
* * * * *
Add support for the Intel Pentium M series to the hwmon-vid driver.
--- drivers/hwmon/hwmon-vid.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-)
drivers/hwmon/hwmon-vid.c +8 -1
@@ -54,6 +54,10 @@(IMVP-II). You can find more information in the datasheet of Max1718 http://www.maxim-ic.com/quick_view2.cfm/qv_pk/2452 +The 13 specification corresponds to the Intel Pentium M series. There +doesn't seem to be any named specification for these. The conversion +tables are detailed directly in the various Pentium M datasheets: +http://www.intel.com/design/intarch/pentiumm/docs_pentiumm.htm */ /* vrm is the VRM/VRD document version multiplied by 10.
@@ -100,6 +104,8 @@case 17 :/* Intel IMVP-II */ return (val &0x10 ?975 - (val &0xF ) *25 :1750 - val *50 ); +case 13 : +return (1708 - (val &0x3f ) *16 );default :/* report 0 for unknown */ printk (KERN_INFO "hwmon-vid: requested unknown VRM version\n" );return 0 ;
@@ -129,8 +135,9 @@static struct vrm_model vrm_models[] = { {X86_VENDOR_AMD ,0x6 ,ANY ,ANY ,90 },/* Athlon Duron etc */ {X86_VENDOR_AMD ,0xF ,ANY ,ANY ,24 },/* Athlon 64, Opteron and above VRM 24 */ - {X86_VENDOR_INTEL ,0x6 ,0x9 ,ANY ,85 },/* 0.13um too */ + {X86_VENDOR_INTEL ,0x6 ,0x9 ,ANY ,13 },/* Pentium M (130 nm) */ {X86_VENDOR_INTEL ,0x6 ,0xB ,ANY ,85 },/* Tualatin */ + {X86_VENDOR_INTEL ,0x6 ,0xD ,ANY ,13 },/* Pentium M (90 nm) */ {X86_VENDOR_INTEL ,0x6 ,ANY ,ANY ,82 },/* any P6 */ {X86_VENDOR_INTEL ,0x7 ,ANY ,ANY ,0 },/* Itanium */ {X86_VENDOR_INTEL ,0xF ,0x0 ,ANY ,90 },/* P4 */
Signature · 1 line
Jean Delvare