Skip to contentSkip to conversation

unexport lookup_hash

PATCH Dave Jones 3 participants 3 messages Feb 3, 2006 – Feb 4, 2006

Subsystems (2)
lore
Share & tools
lore

Dave Jones

author
#0 lore raw

I just stumbled across this whilst checking for planned feature removal, and missed any discussion why this didn't happen, so I assume Christoph forgot.

fs/namei.c renamed from fs/namei.c~ +0 -1
@@ -2668,7 +2668,6 @@ EXPORT_SYMBOL(follow_up);
 EXPORT_SYMBOL(get_write_access); /* binfmt_aout */
 EXPORT_SYMBOL(getname);
 EXPORT_SYMBOL(lock_rename);
-EXPORT_SYMBOL(lookup_hash);
 EXPORT_SYMBOL(lookup_one_len);
 EXPORT_SYMBOL(page_follow_link_light);
 EXPORT_SYMBOL(page_put_link);
Documentation/feature-removal-schedule.txt renamed from Documentation/feature-removal-schedule.txt~ +0 -7
@@ -116,13 +116,6 @@ Who:	Harald Welte <[email protected]
 
 ---------------------------
 
-What:	EXPORT_SYMBOL(lookup_hash)
-When:	January 2006
-Why:	Too low-level interface.  Use lookup_one_len or lookup_create instead.
-Who:	Christoph Hellwig <[email protected]>
-
----------------------------
-
 What:	CONFIG_FORCED_INLINING
 When:	June 2006
 Why:	Config option is there to see if gcc is good enough. (in january
#1 lore raw
Quoted 3 lines · Dave Jones

I just stumbled across this whilst checking for planned feature removal, and missed any discussion why this didn't happen, so I assume Christoph forgot.
...

I did beat you by a few minutes. :-)

This patch wasn't possible before the latest -mm since net/sunrpc/rpc_pipe.c still used it.

cu
Adrian

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed
#2 lore raw
Quoted 6 lines · Adrian Bunk
Quoted 3 lines · Dave Jones

I just stumbled across this whilst checking for planned feature removal, and missed any discussion why this didn't happen, so I assume Christoph forgot.
...

I did beat you by a few minutes. :-)

and your patch also makes it static which is possible now. Andrew also queued up the patch already, so this one won't apply anymore.