Skip to contentSkip to conversation

MODULE_VERSION()

PATCH In review Matthew Martin 5 participants 5 messages Feb 4, 2006 Kernel janitors

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 MODULE_VERSION()

OK, Sorry about last time. Here it is. Could you please tell me what you mean by "the filenames need to begin with linux-x.y.z/" Is that 2.6.x or something else?

--- /home/matthew/src/linux-2.6.15.2/drivers/usb/storage/usb.c

2006-01-31 00:25:07.000000000 -0600

+++ /home/matthew/linux-2.6.15.2/drivers/usb/storage/usb.c 2006-02-03
14:31:09.000000000 -0600
@@ -95,10 +95,13 @@
#include "onetouch.h"
#endif

+#define DRV_VERSION "1.75"
+
/* Some informational data */
MODULE_AUTHOR("Matthew Dharm <[email protected]>"); MODULE_DESCRIPTION("USB Mass Storage driver for Linux"); MODULE_LICENSE("GPL");
+MODULE_VERSION(DRV_VERSION);

static unsigned int delay_use = 5; module_param(delay_use, uint, S_IRUGO | S_IWUSR);

_______________________________________________
Kernel-janitors mailing list
[email protected]
https://lists.osdl.org/mailman/listinfo/kernel-janitors

#1 lore raw
Quoted 4 lines · Matthew Martin

OK, Sorry about last time. Here it is. Could you please tell me what you mean by "the filenames need to begin with linux-x.y.z/" Is that 2.6.x or something else?

What is meant is that your patches should be generated so they apply with 'patch -p1' from inside the source dir.

Quoted 1 line

--- /home/matthew/src/linux-2.6.15.2/drivers/usb/storage/usb.c

^^^ that should be

--- linux-2.6.15.2/drivers/usb/storage/usb.c

You seem to be doing

diff -up /home/matthew/src/linux-2.6.15.2/drivers/usb/storage/usb.c \
/home/matthew/linux-2.6.15.2/drivers/usb/storage/usb.c

Where instead you should be doing something like

cd /home/matthew/
diff -up linux-2.6.15.2/drivers/usb/storage/usb.c.old \
linux-2.6.15.2/drivers/usb/storage/usb.c

or

cd /home/matthew/
diff -up linux-2.6.15.2-original/drivers/usb/storage/usb.c \
linux-2.6.15.2/drivers/usb/storage/usb.c

See the difference?

--
Jesper Juhl <[email protected]>
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please http://www.expita.com/nomime.html

_______________________________________________
Kernel-janitors mailing list
[email protected]
https://lists.osdl.org/mailman/listinfo/kernel-janitors

#2 lore raw
In reply to Matthew Martin

Review line 104

Quoted 13 lines · Matthew Martin

...

(quoted diff) +3 -0
@@ -95,10 +95,13 @@
 #include "onetouch.h"
 #endif
 
+#define DRV_VERSION "1.75"
+
 /* Some informational data */
 MODULE_AUTHOR("Matthew Dharm <[email protected]>");
 MODULE_DESCRIPTION("USB Mass Storage driver for Linux");
 MODULE_LICENSE("GPL");
+MODULE_VERSION(DRV_VERSION);
...

Do we really want to make each ancient driver version string user-visible?

This is not your fault, it does IMHO not belong to the TODO.

There is a very limited area where active driver maintainers are maintaining a version number in a way that printing it does make sense.

But in all other cases, the kernel version is the best way to identify a driver.

E.g. in this case, the driver in the more than two years old kernel 2.6.0 prints exactly the same version 1.75 .

cu
Adrian

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

_______________________________________________
Kernel-janitors mailing list
[email protected]
https://lists.osdl.org/mailman/listinfo/kernel-janitors

#3 lore raw
In reply to Matthew Martin
Quoted 20 lines · Adrian Bunk

Review line 104

Quoted 13 lines · Matthew Martin

...

(quoted diff) +3 -0
@@ -95,10 +95,13 @@
 #include "onetouch.h"
 #endif
 
+#define DRV_VERSION "1.75"
+
 /* Some informational data */
 MODULE_AUTHOR("Matthew Dharm <[email protected]>");
 MODULE_DESCRIPTION("USB Mass Storage driver for Linux");
 MODULE_LICENSE("GPL");
+MODULE_VERSION(DRV_VERSION);
...

Do we really want to make each ancient driver version string user-visible?

This is not your fault, it does IMHO not belong to the TODO.

Quoted 8 lines

There is a very limited area where active driver maintainers are maintaining a version number in a way that printing it does make sense.

But in all other cases, the kernel version is the best way to identify a driver.

E.g. in this case, the driver in the more than two years old kernel 2.6.0 prints exactly the same version 1.75 .

I removed the item. Adding hundreds of module versions just to forget about them...

_______________________________________________
Kernel-janitors mailing list
[email protected]
https://lists.osdl.org/mailman/listinfo/kernel-janitors

#4 lore raw
In reply to Matthew Martin
Quoted 24 lines · On Sat, 4 Feb 2006 20:29:49 +0300 Alexey Dobriyan wrote:
Quoted 23 lines · Adrian Bunk

Review line 104

Quoted 13 lines · Matthew Martin

...

(quoted diff) +3 -0
@@ -95,10 +95,13 @@
 #include "onetouch.h"
 #endif
 
+#define DRV_VERSION "1.75"
+
 /* Some informational data */
 MODULE_AUTHOR("Matthew Dharm <[email protected]>");
 MODULE_DESCRIPTION("USB Mass Storage driver for Linux");
 MODULE_LICENSE("GPL");
+MODULE_VERSION(DRV_VERSION);
...

Do we really want to make each ancient driver version string user-visible?

This is not your fault, it does IMHO not belong to the TODO.

There is a very limited area where active driver maintainers are maintaining a version number in a way that printing it does make sense.

Quoted 8 lines
Quoted 5 lines

But in all other cases, the kernel version is the best way to identify a driver.

E.g. in this case, the driver in the more than two years old kernel 2.6.0 prints exactly the same version 1.75 .

I removed the item. Adding hundreds of module versions just to forget about them...

Thanks. I third that.

---
~Randy

_______________________________________________
Kernel-janitors mailing list
[email protected]
https://lists.osdl.org/mailman/listinfo/kernel-janitors