Skip to contentSkip to conversation

x86_64: unexport ia32_sys_call_table

PATCH In review Adrian Bunk 2 participants 3 messages Feb 5, 2006 User-mode Linux (UML)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 x86_64: unexport ia32_sys_call_table

This export doesn't seem to do anything but bloating the kernel by a few bytes.

---

 arch/um/include/sysdep-x86_64/syscalls.h |    2 --
 arch/x86_64/ia32/ia32entry.S             |    1 -
 arch/x86_64/ia32/sys_ia32.c              |    2 --
 3 files changed, 5 deletions(-)
arch/um/include/sysdep-x86_64/syscalls.h renamed from arch/um/include/sysdep-x86_64/syscalls.h.old +0 -2
@@ -12,8 +12,6 @@
 
 typedef long syscall_handler_t(void);
 
-extern syscall_handler_t *ia32_sys_call_table[];
-
 extern syscall_handler_t *sys_call_table[];
 
 #define EXECUTE_SYSCALL(syscall, regs) \
arch/x86_64/ia32/sys_ia32.c renamed from arch/x86_64/ia32/sys_ia32.c.old +0 -2
@@ -1004,5 +1004,3 @@
 
 __initcall(ia32_init);
 
-extern unsigned long ia32_sys_call_table[];
-EXPORT_SYMBOL(ia32_sys_call_table);
arch/x86_64/ia32/ia32entry.S renamed from arch/x86_64/ia32/ia32entry.S.old +0 -1
@@ -371,7 +371,6 @@
 
 	.section .rodata,"a"
 	.align 8
-	.globl ia32_sys_call_table
 ia32_sys_call_table:
 	.quad sys_restart_syscall
 	.quad sys_exit
#1 lore raw
Quoted 2 lines · Adrian Bunk

This export doesn't seem to do anything but bloating the kernel by a few bytes.

ACK. The native syscall table isn't exported, so the 32bit compat one shouldn't either - and afaik isn't on any other port.

#2 lore raw
Quoted 6 lines · Christoph Hellwig
Quoted 2 lines · Adrian Bunk

This export doesn't seem to do anything but bloating the kernel by a few bytes.

ACK. The native syscall table isn't exported, so the 32bit compat one shouldn't either - and afaik isn't on any other port.

It is also exported on sparc64 because the Solaris binary emulation uses it there.

cu
Adrian

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed